| Message ID | 20220707134552.2436442-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: PCI: qcom: fix typo in condition guarding resets | expand |
On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote: > Fix the typo (compatibles vs compatible) in the condition guarding the > resets being required everywhere except MSM8996. > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I already posted a fix for this a week ago as you probably noticed as I was the one pointing the issue out to you: https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/ > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12b849e..9b3ebee938e8 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -614,7 +614,7 @@ allOf: > - if: > not: > properties: > - compatibles: > + compatible: > contains: > enum: > - qcom,pcie-msm8996 Johan
On 07/07/2022 16:56, Johan Hovold wrote: > On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote: >> Fix the typo (compatibles vs compatible) in the condition guarding the >> resets being required everywhere except MSM8996. >> >> Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > I already posted a fix for this a week ago as you probably noticed as I > was the one pointing the issue out to you: > > https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/ Please excuse me then for duplicating your work. I checked linux-next and missed the mentioned patch. Bjorn, Lorenzo, could you please pick it up? >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 0b69b12b849e..9b3ebee938e8 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -614,7 +614,7 @@ allOf: >> - if: >> not: >> properties: >> - compatibles: >> + compatible: >> contains: >> enum: >> - qcom,pcie-msm8996 > > Johan
On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote: > Fix the typo (compatibles vs compatible) in the condition guarding the > resets being required everywhere except MSM8996. > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Applied for v5.20, thanks! > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12b849e..9b3ebee938e8 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -614,7 +614,7 @@ allOf: > - if: > not: > properties: > - compatibles: > + compatible: > contains: > enum: > - qcom,pcie-msm8996 > -- > 2.35.1 >
On Tue, Jul 12, 2022 at 02:51:37PM -0500, Bjorn Helgaas wrote: > On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote: > > Fix the typo (compatibles vs compatible) in the condition guarding the > > resets being required everywhere except MSM8996. > > > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Applied for v5.20, thanks! Glad to see this fixed, Bjorn H, but was there any particular reason why you picked this version over the patch I submitted a week earlier when reporting the issue? I posted a link to it earlier in this thread: https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/ > > --- > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index 0b69b12b849e..9b3ebee938e8 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -614,7 +614,7 @@ allOf: > > - if: > > not: > > properties: > > - compatibles: > > + compatible: > > contains: > > enum: > > - qcom,pcie-msm8996 > > -- > > 2.35.1 > > Johan
On Wed, Jul 13, 2022 at 08:04:02AM +0200, Johan Hovold wrote: > On Tue, Jul 12, 2022 at 02:51:37PM -0500, Bjorn Helgaas wrote: > > On Thu, Jul 07, 2022 at 04:45:52PM +0300, Dmitry Baryshkov wrote: > > > Fix the typo (compatibles vs compatible) in the condition guarding the > > > resets being required everywhere except MSM8996. > > > > > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Applied for v5.20, thanks! > > Glad to see this fixed, Bjorn H, but was there any particular reason why > you picked this version over the patch I submitted a week earlier when > reporting the issue? Sorry, my mistake. I'll drop this and replace with your patch. > I posted a link to it earlier in this thread: > > https://lore.kernel.org/lkml/20220629141000.18111-2-johan+linaro@kernel.org/ > > > > --- > > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index 0b69b12b849e..9b3ebee938e8 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -614,7 +614,7 @@ allOf: > > > - if: > > > not: > > > properties: > > > - compatibles: > > > + compatible: > > > contains: > > > enum: > > > - qcom,pcie-msm8996 > > > -- > > > 2.35.1 > > > > > Johan
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 0b69b12b849e..9b3ebee938e8 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -614,7 +614,7 @@ allOf: - if: not: properties: - compatibles: + compatible: contains: enum: - qcom,pcie-msm8996
Fix the typo (compatibles vs compatible) in the condition guarding the resets being required everywhere except MSM8996. Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)