diff mbox series

[v5,2/8] dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms

Message ID 20220429213032.3724066-3-dmitry.baryshkov@linaro.org
State New
Headers show
Series dt-bindings: YAMLify pci/qcom,pcie schema | expand

Commit Message

Dmitry Baryshkov April 29, 2022, 9:30 p.m. UTC 
On MSM8996/APQ8096 platforms the PCIe controller doesn't have any
resets. So move the requirement stance under the corresponding if
condition.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../devicetree/bindings/pci/qcom,pcie.yaml         | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Comments

Bjorn Helgaas April 29, 2022, 10:02 p.m. UTC | #1 
On Sat, Apr 30, 2022 at 12:30:26AM +0300, Dmitry Baryshkov wrote:
> On MSM8996/APQ8096 platforms the PCIe controller doesn't have any
> resets. So move the requirement stance under the corresponding if
> condition.

Nit: Pretty sure you mean "stanza" instead of "stance".  Only
mentioning it because I pointed it out last time but it was buried
down in some text that I should have trimmed out.
Dmitry Baryshkov April 29, 2022, 10:40 p.m. UTC | #2 
On 30/04/2022 01:02, Bjorn Helgaas wrote:
> On Sat, Apr 30, 2022 at 12:30:26AM +0300, Dmitry Baryshkov wrote:
>> On MSM8996/APQ8096 platforms the PCIe controller doesn't have any
>> resets. So move the requirement stance under the corresponding if
>> condition.
> 
> Nit: Pretty sure you mean "stanza" instead of "stance".  Only
> mentioning it because I pointed it out last time but it was buried
> down in some text that I should have trimmed out.

Yes, and you even pointed that out. Completely forgot about it while 
updating the patches.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 16f765e96128..ce4f53cdaba0 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -114,8 +114,6 @@  required:
   - interrupt-map
   - clocks
   - clock-names
-  - resets
-  - reset-names
 
 allOf:
   - $ref: /schemas/pci/pci-bus.yaml#
@@ -504,6 +502,18 @@  allOf:
       required:
         - power-domains
 
+  - if:
+      not:
+        properties:
+          compatibles:
+            contains:
+              enum:
+                - qcom,pcie-msm8996
+    then:
+      required:
+        - resets
+        - reset-names
+
 unevaluatedProperties: false
 
 examples: