Message ID | 20210721192650.594990678@linutronix.de |
---|---|
State | New |
Headers | show |
Series | PCI/MSI, x86: Cure a couple of inconsistencies | expand |
--- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -612,8 +612,11 @@ static int msi_verify_entries(struct pci { struct msi_desc *entry; + if (!dev->no_64bit_msi) + return 0; + for_each_pci_msi_entry(entry, dev) { - if (entry->msg.address_hi && dev->no_64bit_msi) { + if (entry->msg.address_hi) { pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n", entry->msg.address_hi, entry->msg.address_lo); return -EIO;
No point in looping over all entries when 64bit addressing mode is enabled for nothing. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org --- drivers/pci/msi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)