From patchwork Thu Jun 24 21:33:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 1496833 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=je0lJSUk; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4G9tgG5SbSz9sRf for ; Fri, 25 Jun 2021 07:34:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232705AbhFXVgV (ORCPT ); Thu, 24 Jun 2021 17:36:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbhFXVgU (ORCPT ); Thu, 24 Jun 2021 17:36:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3A7F613B7; Thu, 24 Jun 2021 21:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624570441; bh=ticgXE7CjNhWfVymrLf5bGBpQYvv4IhRaSX2oXSsd1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=je0lJSUkjWr6LfhmkY1QEILZbvNQwe8wmPRM/TrXmK1AjiIKFHuB5dK1TjC7vQ2H7 Q+UUhqcw18blwKk+JBNE3j0MipA4pwbaSgSAdQFmLp3kvMHKKS4ddIwQQcwamz0iVN nxxI57PuJUXjYyGchYvhyN1SQmiVVMPbpfY5XDkpBuYg6nbc3mzQWK5y02BX8c88nr OVCSxio5AaC3KGaYE71Wy3udYilJBd7MCUobi0VF1BINrS/Bpvim0YyMtsJ67auJrt SRXRGezrr+rG7w29mktUwxw9KHlWRSrBqBV+7p7YFPcAhSVPlhZFzf0+IJ62u5NJDl Up2vvC69POWNQ== Received: by pali.im (Postfix) id 0E1EB96D; Thu, 24 Jun 2021 23:33:59 +0200 (CEST) From: =?utf-8?q?Pali_Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas Cc: =?utf-8?q?Marek_Beh=C3=BAn?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 1/3] PCI: aardvark: Fix checking for PIO Non-posted Request Date: Thu, 24 Jun 2021 23:33:43 +0200 Message-Id: <20210624213345.3617-2-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624213345.3617-1-pali@kernel.org> References: <20210624213345.3617-1-pali@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org PIO_NON_POSTED_REQ for PIO_STAT register is incorrectly defined. Bit 10 in register PIO_STAT indicates the response is to a non-posted request. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Cc: stable@vger.kernel.org --- drivers/pci/controller/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index e3f5e7ab7606..2f8380a1f84f 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -57,7 +57,7 @@ #define PIO_COMPLETION_STATUS_UR 1 #define PIO_COMPLETION_STATUS_CRS 2 #define PIO_COMPLETION_STATUS_CA 4 -#define PIO_NON_POSTED_REQ BIT(0) +#define PIO_NON_POSTED_REQ BIT(10) #define PIO_ADDR_LS (PIO_BASE_ADDR + 0x8) #define PIO_ADDR_MS (PIO_BASE_ADDR + 0xc) #define PIO_WR_DATA (PIO_BASE_ADDR + 0x10)