| Message ID | 20200721151735.41181-1-weiyongjun1@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] PCI: rpadlpar: Make some functions static | expand |
On Tue, Jul 21, 2020 at 11:17:35PM +0800, Wei Yongjun wrote: > The sparse tool report build warnings as follows: > > drivers/pci/hotplug/rpadlpar_core.c:355:5: warning: > symbol 'dlpar_remove_pci_slot' was not declared. Should it be static? > drivers/pci/hotplug/rpadlpar_core.c:461:12: warning: > symbol 'rpadlpar_io_init' was not declared. Should it be static? > drivers/pci/hotplug/rpadlpar_core.c:473:6: warning: > symbol 'rpadlpar_io_exit' was not declared. Should it be static? > > Those functions are not used outside of this file, so marks them > static. > Also mark rpadlpar_io_exit() as __exit. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied to pci/hotplug for v5.9, thanks! > --- > drivers/pci/hotplug/rpadlpar_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index c5eb509c72f0..f979b7098acf 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -352,7 +352,7 @@ static int dlpar_remove_vio_slot(char *drc_name, struct device_node *dn) > * -ENODEV Not a valid drc_name > * -EIO Internal PCI Error > */ > -int dlpar_remove_pci_slot(char *drc_name, struct device_node *dn) > +static int dlpar_remove_pci_slot(char *drc_name, struct device_node *dn) > { > struct pci_bus *bus; > struct slot *slot; > @@ -458,7 +458,7 @@ static inline int is_dlpar_capable(void) > return (int) (rc != RTAS_UNKNOWN_SERVICE); > } > > -int __init rpadlpar_io_init(void) > +static int __init rpadlpar_io_init(void) > { > > if (!is_dlpar_capable()) { > @@ -470,7 +470,7 @@ int __init rpadlpar_io_init(void) > return dlpar_sysfs_init(); > } > > -void rpadlpar_io_exit(void) > +static void __exit rpadlpar_io_exit(void) > { > dlpar_sysfs_exit(); > } >
diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c index c5eb509c72f0..f979b7098acf 100644 --- a/drivers/pci/hotplug/rpadlpar_core.c +++ b/drivers/pci/hotplug/rpadlpar_core.c @@ -352,7 +352,7 @@ static int dlpar_remove_vio_slot(char *drc_name, struct device_node *dn) * -ENODEV Not a valid drc_name * -EIO Internal PCI Error */ -int dlpar_remove_pci_slot(char *drc_name, struct device_node *dn) +static int dlpar_remove_pci_slot(char *drc_name, struct device_node *dn) { struct pci_bus *bus; struct slot *slot; @@ -458,7 +458,7 @@ static inline int is_dlpar_capable(void) return (int) (rc != RTAS_UNKNOWN_SERVICE); } -int __init rpadlpar_io_init(void) +static int __init rpadlpar_io_init(void) { if (!is_dlpar_capable()) { @@ -470,7 +470,7 @@ int __init rpadlpar_io_init(void) return dlpar_sysfs_init(); } -void rpadlpar_io_exit(void) +static void __exit rpadlpar_io_exit(void) { dlpar_sysfs_exit(); }
The sparse tool report build warnings as follows: drivers/pci/hotplug/rpadlpar_core.c:355:5: warning: symbol 'dlpar_remove_pci_slot' was not declared. Should it be static? drivers/pci/hotplug/rpadlpar_core.c:461:12: warning: symbol 'rpadlpar_io_init' was not declared. Should it be static? drivers/pci/hotplug/rpadlpar_core.c:473:6: warning: symbol 'rpadlpar_io_exit' was not declared. Should it be static? Those functions are not used outside of this file, so marks them static. Also mark rpadlpar_io_exit() as __exit. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/pci/hotplug/rpadlpar_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)