From patchwork Sun Dec 9 22:45:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederick Lawler X-Patchwork-Id: 1010185 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=fredlawl.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=fredlawl-com.20150623.gappssmtp.com header.i=@fredlawl-com.20150623.gappssmtp.com header.b="xxShai0K"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43ChCP2hVZz9s3C for ; Mon, 10 Dec 2018 09:46:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726313AbeLIWqj (ORCPT ); Sun, 9 Dec 2018 17:46:39 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:34057 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbeLIWqj (ORCPT ); Sun, 9 Dec 2018 17:46:39 -0500 Received: by mail-oi1-f196.google.com with SMTP id h25so7583770oig.1 for ; Sun, 09 Dec 2018 14:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fredlawl-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=guAieEX3tnWHuuM1l8KzNMGuDYrTMkG1L3tUfFzs1SM=; b=xxShai0KajxFgh0/VSCAlsn3fDuzfhHfpfoD40ifgx/381jEBgNQBcpK/t6kViJTcQ TP4gKm2asshj+a97qW77hB9To4ksVun+et79b4r6DBGl768mqN+fz3sMlBGT2c67f4o6 0NEjCNZ/t+KuZek23xwHl4XgmH26fIQnaAZIzZT6rPwprQp8+rf+bNpYaf7Xm0ZwMdbQ TMtQeYJ73U0P1rCENmo6mnZP8QojmHR6KsfjdkgDSlj/Lg/boklpNo4hvLhPdMhPxW7z V5eDNMb+K9l9Odt/rPzsyhnlDDghT+w+cuqB0m1eFfLa6d9J6I0VTxDhnzauBr5H+A8g wksw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=guAieEX3tnWHuuM1l8KzNMGuDYrTMkG1L3tUfFzs1SM=; b=Xvs7qaOqZytHUy+Doj+qfDpRxXHOTNZgDSgnbBKZzb5scy7oz6hglhbIQbPmGgzUG9 sH9WZIi8WJY/7p1D1B4DngFHXmNN9HOzmwPkOg7gRCgD6O0W82+jF+59FEr5OTHRNmzq lBDRD0+grKDaWUOQlLGLOW6eFbOtLdd8PbgYD0QFGp3zpWbvVaW3U6AHZ/LWKvbGTmAe 0Y0aZwCaz5ykUoKjQ6BHtzqo1ZuLjHjlNjJAlcVwda2aiQgwVpiYO3bpcVqqtWGD1Sph G9VYUlHJ8XHBCo6/uz1icBCpjUf6fhkDT5vNjbLkGEp7zfG5VcuEuEMptdCfzQZyJA9Q yDmQ== X-Gm-Message-State: AA+aEWbwxRcyMzoro/GUA0wE4GQuAjYJ3U0uc/xLgM4W0DQcUTNaE7VU kTyw7RyXg1wKYVM2y81HkNYH7w== X-Google-Smtp-Source: AFSGD/WubISG1uQFa6RUJfFbxT0euSoeTyWtixN6znufigZydWaf0gAyZCVkz7cMa8Rs2wwxSTSUpA== X-Received: by 2002:aca:d64d:: with SMTP id n74mr5931462oig.199.1544395598444; Sun, 09 Dec 2018 14:46:38 -0800 (PST) Received: from ubuntu-fredlawl.attlocal.net ([2600:1702:3be0:4340:e5c0:b776:5e38:6371]) by smtp.gmail.com with ESMTPSA id c23sm4339179otn.21.2018.12.09.14.46.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Dec 2018 14:46:37 -0800 (PST) From: Frederick Lawler To: helgaas@kernel.org Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ptalbert@redhat.com, Frederick Lawler Subject: [PATCH] PCI/ASPM: Remove unused lists from struct pcie_link_state Date: Sun, 9 Dec 2018 16:45:50 -0600 Message-Id: <20181209224550.18931-1-fred@fredlawl.com> X-Mailer: git-send-email 2.17.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org ASPM does not make use of the children or link LIST_HEADs declared in struct pcie_link_state and defined in alloc_pcie_link_state(). Therefore, remove these lists. No functional change intended. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/aspm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index dcb29cb76dc6..2330ebf6df72 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -53,8 +53,6 @@ struct pcie_link_state { struct pcie_link_state *root; /* pointer to the root port link */ struct pcie_link_state *parent; /* pointer to the parent Link state */ struct list_head sibling; /* node in link_list */ - struct list_head children; /* list of child link states */ - struct list_head link; /* node in parent's children list */ /* ASPM state */ u32 aspm_support:7; /* Supported ASPM state */ @@ -850,8 +848,6 @@ static struct pcie_link_state *alloc_pcie_link_state(struct pci_dev *pdev) return NULL; INIT_LIST_HEAD(&link->sibling); - INIT_LIST_HEAD(&link->children); - INIT_LIST_HEAD(&link->link); link->pdev = pdev; link->downstream = pci_function_0(pdev->subordinate); @@ -877,7 +873,6 @@ static struct pcie_link_state *alloc_pcie_link_state(struct pci_dev *pdev) link->parent = parent; link->root = link->parent->root; - list_add(&link->link, &parent->children); } list_add(&link->sibling, &link_list); @@ -1001,7 +996,6 @@ void pcie_aspm_exit_link_state(struct pci_dev *pdev) /* All functions are removed, so just disable ASPM for the link */ pcie_config_aspm_link(link, 0); list_del(&link->sibling); - list_del(&link->link); /* Clock PM is for endpoint device */ free_link_state(link);