| Message ID | 20180627122919.23926-5-vigneshr@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | pci-dra7xx: Enable errata i870 workaround for RC mode | expand |
On Wednesday 27 June 2018 05:59 PM, Vignesh R wrote: > Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and > PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are > incorrectly documented in the TRM. In fact, the bit positions are > swapped. Update the DT bindings for PCIe EP to reflect the same. > > Signed-off-by: Vignesh R <vigneshr@ti.com> Shouldn't this be sent to stable fixes? Thanks Kishon > --- > arch/arm/boot/dts/dra7.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 7bfe7f28e3bd..27ad193e1a87 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -355,7 +355,7 @@ > ti,hwmods = "pcie1"; > phys = <&pcie1_phy>; > phy-names = "pcie-phy0"; > - ti,syscon-unaligned-access = <&scm_conf1 0x14 2>; > + ti,syscon-unaligned-access = <&scm_conf1 0x14 1>; > status = "disabled"; > }; > }; >
Hi Tony, On Tuesday 17 July 2018 03:25 PM, Kishon Vijay Abraham I wrote: > > > On Wednesday 27 June 2018 05:59 PM, Vignesh R wrote: >> Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and >> PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are >> incorrectly documented in the TRM. In fact, the bit positions are >> swapped. Update the DT bindings for PCIe EP to reflect the same. >> >> Signed-off-by: Vignesh R <vigneshr@ti.com> > > Shouldn't this be sent to stable fixes? This patch fixes: Fixes: d23f3839fe97 ("ARM: dts: DRA7: Add pcie1 dt node for EP mode") Cc: stable@vger.kernel.org let me know if this needs to be resent with Fixes tag. Regards Vignesh > > Thanks > Kishon >> --- >> arch/arm/boot/dts/dra7.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 7bfe7f28e3bd..27ad193e1a87 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -355,7 +355,7 @@ >> ti,hwmods = "pcie1"; >> phys = <&pcie1_phy>; >> phy-names = "pcie-phy0"; >> - ti,syscon-unaligned-access = <&scm_conf1 0x14 2>; >> + ti,syscon-unaligned-access = <&scm_conf1 0x14 1>; >> status = "disabled"; >> }; >> }; >>
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 7bfe7f28e3bd..27ad193e1a87 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -355,7 +355,7 @@ ti,hwmods = "pcie1"; phys = <&pcie1_phy>; phy-names = "pcie-phy0"; - ti,syscon-unaligned-access = <&scm_conf1 0x14 2>; + ti,syscon-unaligned-access = <&scm_conf1 0x14 1>; status = "disabled"; }; };
Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are incorrectly documented in the TRM. In fact, the bit positions are swapped. Update the DT bindings for PCIe EP to reflect the same. Signed-off-by: Vignesh R <vigneshr@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)