From patchwork Wed Aug 2 07:32:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 796528 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xMlJx3Byzz9sRW for ; Wed, 2 Aug 2017 17:32:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751164AbdHBHcs (ORCPT ); Wed, 2 Aug 2017 03:32:48 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48934 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbdHBHcr (ORCPT ); Wed, 2 Aug 2017 03:32:47 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BCE980D; Wed, 2 Aug 2017 00:32:47 -0700 (PDT) Received: from why.wild-wind.fr.eu.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42E063F577; Wed, 2 Aug 2017 00:32:46 -0700 (PDT) Date: Wed, 2 Aug 2017 08:32:34 +0100 From: Marc Zyngier To: kbuild test robot Cc: , , Bjorn Helgaas Subject: Re: [pci:for-linus 1/2] drivers/pci/pci.c:4283:7: error: implicit declaration of function 'pci_dev_reset' Message-ID: <20170802083234.30c18a83@why.wild-wind.fr.eu.org> In-Reply-To: <201708020922.GaknMGx6%fengguang.wu@intel.com> References: <201708020922.GaknMGx6%fengguang.wu@intel.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 2 Aug 2017 09:53:26 +0800 kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git for-linus > head: 39d14168af01c696cfcab4770e2b9a56d6e73679 > commit: 39767ee127c680aed6d94bbcd429bb5242ef4f1f [1/2] PCI: Add pci_reset_function_locked() > config: i386-randconfig-x019-201731 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > git checkout 39767ee127c680aed6d94bbcd429bb5242ef4f1f > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > drivers/pci/pci.c: In function 'pci_reset_function_locked': > >> drivers/pci/pci.c:4283:7: error: implicit declaration of function 'pci_dev_reset' [-Werror=implicit-function-declaration] > rc = pci_dev_reset(dev, 1); > ^~~~~~~~~~~~~ > >> drivers/pci/pci.c:4289:7: error: implicit declaration of function '__pci_dev_reset' [-Werror=implicit-function-declaration] > rc = __pci_dev_reset(dev, 0); > ^~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors [...] Ah, the patch has raced against 52354b9d1f46 ("PCI: Remove __pci_dev_reset() and pci_dev_reset()") and applies on top of mainline without conflicts. Bah... The fixlet below addresses the issue (tested with 4.13-rc3 on AMD Seattle). Thanks, M. Without deviation from the norm, progress is not possible. diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index ffddd574a79e..e20ce77e7ec3 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4280,13 +4280,13 @@ int pci_reset_function_locked(struct pci_dev *dev) { int rc; - rc = pci_dev_reset(dev, 1); + rc = pci_probe_reset_function(dev); if (rc) return rc; pci_dev_save_and_disable(dev); - rc = __pci_dev_reset(dev, 0); + rc = __pci_reset_function_locked(dev); pci_dev_restore(dev); --