Message ID | 20130113232743.7225.11180.stgit@bhelgaas.mtv.corp.google.com |
---|---|
State | Accepted |
Headers | show |
Hello, On Sun, Jan 13, 2013 at 04:27:43PM -0700, Bjorn Helgaas wrote: > e24dcbef93 ("shpchp: update workqueue usage") was described as adding > non-ordered shpchp_wq, but it actually made it an *ordered* workqueue. > > This patch changes shpchp_wq to be non-ordered, as described in the > e24dcbef93 commit log and as was done for pciehp by a827ea307b ("pciehp: > update workqueue usage"). > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > CC: Tejun Heo <tj@kernel.org> Yeap, my mistake. Acked-by: Tejun Heo <tj@kernel.org> Thanks!
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c index b6de307..59ca86c 100644 --- a/drivers/pci/hotplug/shpchp_core.c +++ b/drivers/pci/hotplug/shpchp_core.c @@ -366,7 +366,7 @@ static int __init shpcd_init(void) { int retval = 0; - shpchp_wq = alloc_ordered_workqueue("shpchp", 0); + shpchp_wq = alloc_workqueue("shpchp", 0, 0); if (!shpchp_wq) return -ENOMEM;
e24dcbef93 ("shpchp: update workqueue usage") was described as adding non-ordered shpchp_wq, but it actually made it an *ordered* workqueue. This patch changes shpchp_wq to be non-ordered, as described in the e24dcbef93 commit log and as was done for pciehp by a827ea307b ("pciehp: update workqueue usage"). Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: Tejun Heo <tj@kernel.org> --- drivers/pci/hotplug/shpchp_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html