| Message ID | 20120920161603.Horde.aF7BBcL8999QWyUjk2AmsNA@webmail.df.eu |
|---|---|
| State | Rejected |
| Headers | show |
On Thu, Sep 20, 2012 at 8:16 AM, Stephan Schreiber <info@fs-driver.org> wrote: > description of the symptoms which you have already read on the initial > RFC/PATCH======> > > > Kernel 3.2.23 with Debian patches (Debian Wheezy, testing) > Debian bug#679545 (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679545) > > Machine: Dell PowerEdge 3250 (equivalent with Intel SR870BH2) > Processor: 2x Itanium Madison 1.5GHz 6M > Memory: 4GB > > Intel ICH4 (82801DB), IDE host adapter. The ata_piix module fails to > initialize. > > A snippet from dmesg: > [ 0.000000] Initializing cgroup subsys cpuset > [ 0.000000] Initializing cgroup subsys cpu > [ 0.000000] Linux version 3.2.0-3-mckinley (Debian 3.2.23-1) > (debian-kernel@lists.debian.org) (gcc version 4.6.3 (Debian 4.6.3-8) ) #1 > SMP Mon Jul 23 09:01:02 UTC 2012 > ... > [ 0.065516] pci 0000:00:1f.1: [8086:24cb] type 0 class 0x000101 > [ 0.065530] pci 0000:00:1f.1: reg 10: [io 0x0000-0x0007] > [ 0.065541] pci 0000:00:1f.1: reg 14: [io 0x0000-0x0003] > [ 0.065552] pci 0000:00:1f.1: reg 18: [io 0x0000-0x0007] > [ 0.065563] pci 0000:00:1f.1: reg 1c: [io 0x0000-0x0003] > [ 0.065574] pci 0000:00:1f.1: reg 20: [io 0x1000-0x100f] > [ 0.065585] pci 0000:00:1f.1: reg 24: [mem 0x00000000-0x000003ff] > ... > [ 1.640965] libata version 3.00 loaded. > [ 1.641656] ata_piix 0000:00:1f.1: version 2.13 > [ 1.641671] ata_piix 0000:00:1f.1: device not available (can't reserve > [mem 0x00000000-0x000003ff]) > [ 1.641747] ata_piix: probe of 0000:00:1f.1 failed with error -22 > ... > > lspci -vvxxx reports: > > 00:1f.1 IDE interface: Intel Corporation 82801DB (ICH4) IDE Controller (rev > 02) (prog-if 8a [Master SecP PriP]) > Subsystem: Intel Corporation Device 3404 > Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- > Stepping- SERR- FastB2B- DisINTx- > Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- > <TAbort- <MAbort- >SERR- <PERR- INTx- > Latency: 0 > Interrupt: pin A routed to IRQ 0 > Region 0: I/O ports at 01f0 [size=8] > Region 1: I/O ports at 03f4 [size=1] > Region 2: I/O ports at 0170 [size=8] > Region 3: I/O ports at 0374 [size=1] > Region 4: I/O ports at 1000 [size=16] > 00: 86 80 cb 24 05 00 80 02 02 8a 01 01 00 00 00 00 > 10: 01 00 00 00 01 00 00 00 01 00 00 00 01 00 00 00 > 20: 01 10 00 00 00 00 00 00 00 00 00 00 86 80 04 34 > 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 > 40: 03 a3 00 80 00 00 00 00 01 00 02 00 00 00 00 00 > 50: 00 00 00 00 00 04 00 00 00 00 00 00 00 00 00 00 > 60: 08 00 00 00 00 00 00 00 08 00 00 00 00 00 00 00 > 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > f0: 00 00 00 00 00 00 00 00 60 0f 00 00 00 00 00 00 > > > You can read in the "Intel 82801DB I/O Controller Hub 4 (ICH4)" datasheet > (http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82801db-io-controller-hub-4-datasheet.pdf) > about the EXBAR register at offset 0x24 (4 bytes): > "EXBAR register > This is a memory mapped BAR that requires 1 KB of DWord-aligned memory that > is Intel reserved > for future functionality. BIOS needs to program the base address for a 1-KB > memory space." > > The dump shows that EXBAR is 0x0000, equal to the default value after reset; > EFI doesn't initialize it. > > ata_piix uses pcim_enable_device() which enables this along with the I/O > BARs. In systems based on the Intel SR870 platform the firmware does not > initialize the EXBAR and pcim_enable_device() fails because the memory > region 0x0-0x3FF cannot be allocated. > > <=====description of the symptoms which you have already read on the initial > RFC/PATCH > > > > >> My only disagreement here would be putting it in the ia64 paths. If >> someone does the same for x86-32 (and this is EFI so it'll presumbly >> smell the same on all platforms) then we'll want the same. >> >> Better I think to generically catch the 0/0 case. >> >> Alan > > > > Here is a new patch. It extends some existing code in pci_setup_device() > which maintains some hard-coded io regions on ide controllers in legacy > mode. > The idea is hiding an uninitialized EXBAR just as on the initial patch. > The patch is defensive; it does nothing if > - the controller isn't in legacy mode, > - BAR5 (EXBAR) isn't a memory resource, or > - BAR5 is already initialized. > > The patch is generic because it works on both x86-32 and ia64 and also for > other ICH4 variants than my rare 82801DB_11 ICH4. > Even the added 'if' statement of this patch is also executed on IDE > controllers of other vendors than Intel or on other Intel ICHs, I believe > that it won't break anything. This still isn't very generic. It only looks at BAR 5 and only for IDE controllers, so it fixes the problem for this device and this BIOS, but there's no reason the same problem couldn't happen on other devices and other BARs. My proposal was basically: pci_read_config_word(dev, PCI_COMMAND, &cmd); for (i = 0; i < 6; i++) { /* read BAR i here */ r = dev->resource[i]; if (((r->flags & IORESOURCE_MEM) && (cmd & PCI_COMMAND_MEMORY)) || ((r->flags & IORESOURCE_IO) && (cmd & PCI_COMMAND_IO))) { /* treat resource as valid */ } else { /* treat resource as unassigned; try to assign it later */ } } (This is just to show the idea; the actual Linux code isn't structured like this.) > --- linux-3.2.23/drivers/pci/probe.c.orig 2012-07-12 > 05:32:21.000000000 +0200 > +++ linux-3.2.23/drivers/pci/probe.c 2012-09-19 20:52:24.000000000 +0200 > @@ -898,146 +898,158 @@ int pci_setup_device(struct pci_dev *dev > { > u32 class; > u8 hdr_type; > struct pci_slot *slot; > int pos = 0; > > if (pci_read_config_byte(dev, PCI_HEADER_TYPE, &hdr_type)) > return -EIO; > > dev->sysdata = dev->bus->sysdata; > dev->dev.parent = dev->bus->bridge; > dev->dev.bus = &pci_bus_type; > dev->hdr_type = hdr_type & 0x7f; > dev->multifunction = !!(hdr_type & 0x80); > dev->error_state = pci_channel_io_normal; > set_pcie_port_type(dev); > > list_for_each_entry(slot, &dev->bus->slots, list) > if (PCI_SLOT(dev->devfn) == slot->number) > dev->slot = slot; > > /* Assume 32-bit PCI; let 64-bit PCI cards (which are far rarer) > set this higher, assuming the system even supports it. */ > dev->dma_mask = 0xffffffff; > > dev_set_name(&dev->dev, "%04x:%02x:%02x.%d", > pci_domain_nr(dev->bus), > dev->bus->number, PCI_SLOT(dev->devfn), > PCI_FUNC(dev->devfn)); > > pci_read_config_dword(dev, PCI_CLASS_REVISION, &class); > dev->revision = class & 0xff; > class >>= 8; /* upper 3 bytes */ > dev->class = class; > class >>= 8; > > dev_printk(KERN_DEBUG, &dev->dev, "[%04x:%04x] type %d class > %#08x\n", > dev->vendor, dev->device, dev->hdr_type, class); > > /* need to have dev->class ready */ > dev->cfg_size = pci_cfg_space_size(dev); > > /* "Unknown power state" */ > dev->current_state = PCI_UNKNOWN; > > /* Early fixups, before probing the BARs */ > pci_fixup_device(pci_fixup_early, dev); > /* device class may be changed after fixup */ > class = dev->class >> 8; > > switch (dev->hdr_type) { /* header type */ > case PCI_HEADER_TYPE_NORMAL: /* standard header */ > if (class == PCI_CLASS_BRIDGE_PCI) > goto bad; > pci_read_irq(dev); > pci_read_bases(dev, 6, PCI_ROM_ADDRESS); > pci_read_config_word(dev, PCI_SUBSYSTEM_VENDOR_ID, > &dev->subsystem_vendor); > pci_read_config_word(dev, PCI_SUBSYSTEM_ID, > &dev->subsystem_device); > > /* > * Do the ugly legacy mode stuff here rather than > broken chip > * quirk code. Legacy mode ATA controllers have fixed > * addresses. These are not always echoed in BAR0-3, > and > * BAR0-3 in a few cases contain junk! > + * BAR5 is a memory resource on Intel ICH4 which isn't > + * functional at all. Some BIOS or EFI don't initialize > + * it and would break ata_piix. If the controller is in > + * legacy mode and BAR5 is an uninitialized memory > + * resource, hide it. > */ > if (class == PCI_CLASS_STORAGE_IDE) { > u8 progif; > pci_read_config_byte(dev, PCI_CLASS_PROG, &progif); > if ((progif & 1) == 0) { > dev->resource[0].start = 0x1F0; > dev->resource[0].end = 0x1F7; > dev->resource[0].flags = LEGACY_IO_RESOURCE; > dev->resource[1].start = 0x3F6; > dev->resource[1].end = 0x3F6; > dev->resource[1].flags = LEGACY_IO_RESOURCE; > } > if ((progif & 4) == 0) { > dev->resource[2].start = 0x170; > dev->resource[2].end = 0x177; > dev->resource[2].flags = LEGACY_IO_RESOURCE; > dev->resource[3].start = 0x376; > dev->resource[3].end = 0x376; > dev->resource[3].flags = LEGACY_IO_RESOURCE; > } > + if ((progif & 5) == 0 > + && (dev->resource[5].flags & IORESOURCE_MEM) > + && dev->resource[5].start == 0 > + && dev->resource[5].end != 0) { > + dev->resource[5].flags = 0; > + dev->resource[5].end = 0; > + } > } > break; > > case PCI_HEADER_TYPE_BRIDGE: /* bridge header */ > if (class != PCI_CLASS_BRIDGE_PCI) > goto bad; > /* The PCI-to-PCI bridge spec requires that subtractive > decoding (i.e. transparent) bridge must have programming > interface code of 0x01. */ > pci_read_irq(dev); > dev->transparent = ((dev->class & 0xff) == 1); > pci_read_bases(dev, 2, PCI_ROM_ADDRESS1); > set_pcie_hotplug_bridge(dev); > pos = pci_find_capability(dev, PCI_CAP_ID_SSVID); > if (pos) { > pci_read_config_word(dev, pos + PCI_SSVID_VENDOR_ID, > &dev->subsystem_vendor); > pci_read_config_word(dev, pos + PCI_SSVID_DEVICE_ID, > &dev->subsystem_device); > } > break; > > case PCI_HEADER_TYPE_CARDBUS: /* CardBus bridge header > */ > if (class != PCI_CLASS_BRIDGE_CARDBUS) > goto bad; > pci_read_irq(dev); > pci_read_bases(dev, 1, 0); > pci_read_config_word(dev, PCI_CB_SUBSYSTEM_VENDOR_ID, > &dev->subsystem_vendor); > pci_read_config_word(dev, PCI_CB_SUBSYSTEM_ID, > &dev->subsystem_device); > break; > > default: /* unknown header */ > dev_err(&dev->dev, "unknown header type %02x, " > "ignoring device\n", dev->hdr_type); > return -EIO; > > bad: > dev_err(&dev->dev, "ignoring class %02x (doesn't match > header " > "type %02x)\n", class, dev->hdr_type); > dev->class = PCI_CLASS_NOT_DEFINED; > } > > /* We found a fine healthy device, go go go... */ > return 0; > } > > static void pci_release_capabilities(struct pci_dev *dev) > { > pci_vpd_release(dev); > pci_iov_release(dev); > } > > /** > * pci_release_dev - free a pci device structure when all users of it are > finished. > * @dev: device that's been disconnected > * > * Will be called only by the device core when all users of this pci device > are > * done. > */ > static void pci_release_dev(struct device *dev) > { > struct pci_dev *pci_dev; > > pci_dev = to_pci_dev(dev); > pci_release_capabilities(pci_dev); > > > > Signed-off-by: Stephan Schreiber <info@fs-driver.org> > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Mpfff, there aren't many replies; seems I didn't satisfy what you want to have... At first I want to mention that I just want to help the Debian project and started testing Debian Wheezy my old ia64 box. Since these are my first messages on the kernel lists, I really don't feel me in a position to tell you what's right or wrong for the Kernel - I guess you have much more Linux Kernel knowledge than me. > The firmware left the memory BAR at 0x24 cleared (0x00000000), but it > also left the MEM bit in the command register disabled. So it seems > like a Linux bug that we're trying to use that zero address from the > BAR. If the firmware left the MEM or IO decode enable bit cleared, > why would we assume it put anything useful in the corresponding BARs? Your idea would be a fundamental change in the Kernel; I just want to fix the ata_piix problem in Debian Wheezy. I can't tell you whether the developer of the EFI thought this. Maybe it is simply a bug. If you would evaluate the command registers, which the BIOS or EFI has initialized, you would work around some wrong BARs. You might run into trouble due to wrong command register values instead. Are you sure that any BIOS or EFI sets the command registers correctly? Currently the Linux Kernel sets and clears the IORESOURCE_MEM and IORESOURCE_IO bits in the command registers as needed. Windows reconfigures any PCI device. The settings of the BIOS or EFI do not matter at all; the user doesn't experience any BIOS bug at all. > This still isn't very generic. It only looks at BAR 5 and only for > IDE controllers, so it fixes the problem for this device and this > BIOS, but there's no reason the same problem couldn't happen on other > devices and other BARs. > > My proposal was basically: > > pci_read_config_word(dev, PCI_COMMAND, &cmd); > for (i = 0; i < 6; i++) { > /* read BAR i here */ > r = dev->resource[i]; > if (((r->flags & IORESOURCE_MEM) && (cmd & PCI_COMMAND_MEMORY)) || > ((r->flags & IORESOURCE_IO) && (cmd & PCI_COMMAND_IO))) { > /* treat resource as valid */ > } else { > /* treat resource as unassigned; try to assign it later */ > } > } Both of my two patches hide the BAR5 when we know that BAR5 is not functional. The first patch makes sure that the PCI device id matches; the second one checks whether it is an ide controller in legacy mode. The associated ide/piix or ata/ata_piix doesn't need the BAR5 memory resource at all. The other BARs are functional and needed. I don't know what regression can occur when you hide *any* uninitialized BAR of *any* pci device. Some drivers might be screwed up when a needed mem resource is absend - after pci_enable_device() or pcim_enable_device() returned success. Ben Hutchings of the Debian project pointed to some interesting detail about ide/piix: "By the way, the reason the old IDE driver worked is that drivers/ide/setup-pci.c has a fallback for this: if (pci_enable_device(dev)) { ret = pci_enable_device_io(dev); It was added almost exactly 10 years ago without any specific comment." Debian had both ide/piix and ata/ata_piix in the past. When ata_piix didn't initialize, ide/piix took over the device. The user didn't experience any problem. The old ide/piix has been removed with recent Debian versions (due to problems with shared interrupts). Thus, the ICH4 problem is on the table again. Since you don't want to take my patches, I need some new ideas. The patch shouldn't be a fundamental, experimental change with the risk of regression because it is intended for a *stable* Debian release. Suggestions or comments are appreciated. Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-3.2.23/drivers/pci/probe.c.orig 2012-07-12 05:32:21.000000000 +0200 +++ linux-3.2.23/drivers/pci/probe.c 2012-09-19 20:52:24.000000000 +0200 @@ -898,146 +898,158 @@ int pci_setup_device(struct pci_dev *dev { u32 class; u8 hdr_type; struct pci_slot *slot; int pos = 0; if (pci_read_config_byte(dev, PCI_HEADER_TYPE, &hdr_type)) return -EIO; dev->sysdata = dev->bus->sysdata; dev->dev.parent = dev->bus->bridge; dev->dev.bus = &pci_bus_type; dev->hdr_type = hdr_type & 0x7f; dev->multifunction = !!(hdr_type & 0x80); dev->error_state = pci_channel_io_normal; set_pcie_port_type(dev); list_for_each_entry(slot, &dev->bus->slots, list) if (PCI_SLOT(dev->devfn) == slot->number) dev->slot = slot; /* Assume 32-bit PCI; let 64-bit PCI cards (which are far rarer) set this higher, assuming the system even supports it. */ dev->dma_mask = 0xffffffff; dev_set_name(&dev->dev, "%04x:%02x:%02x.%d", pci_domain_nr(dev->bus), dev->bus->number, PCI_SLOT(dev->devfn), PCI_FUNC(dev->devfn)); pci_read_config_dword(dev, PCI_CLASS_REVISION, &class); dev->revision = class & 0xff; class >>= 8; /* upper 3 bytes */ dev->class = class; class >>= 8; dev_printk(KERN_DEBUG, &dev->dev, "[%04x:%04x] type %d class %#08x\n", dev->vendor, dev->device, dev->hdr_type, class); /* need to have dev->class ready */ dev->cfg_size = pci_cfg_space_size(dev); /* "Unknown power state" */ dev->current_state = PCI_UNKNOWN; /* Early fixups, before probing the BARs */ pci_fixup_device(pci_fixup_early, dev); /* device class may be changed after fixup */ class = dev->class >> 8; switch (dev->hdr_type) { /* header type */ case PCI_HEADER_TYPE_NORMAL: /* standard header */ if (class == PCI_CLASS_BRIDGE_PCI) goto bad; pci_read_irq(dev); pci_read_bases(dev, 6, PCI_ROM_ADDRESS); pci_read_config_word(dev, PCI_SUBSYSTEM_VENDOR_ID, &dev->subsystem_vendor); pci_read_config_word(dev, PCI_SUBSYSTEM_ID, &dev->subsystem_device); /* * Do the ugly legacy mode stuff here rather than broken chip * quirk code. Legacy mode ATA controllers have fixed * addresses. These are not always echoed in BAR0-3, and * BAR0-3 in a few cases contain junk! + * BAR5 is a memory resource on Intel ICH4 which isn't + * functional at all. Some BIOS or EFI don't initialize + * it and would break ata_piix. If the controller is in + * legacy mode and BAR5 is an uninitialized memory + * resource, hide it. */ if (class == PCI_CLASS_STORAGE_IDE) { u8 progif; pci_read_config_byte(dev, PCI_CLASS_PROG, &progif); if ((progif & 1) == 0) { dev->resource[0].start = 0x1F0; dev->resource[0].end = 0x1F7; dev->resource[0].flags = LEGACY_IO_RESOURCE; dev->resource[1].start = 0x3F6; dev->resource[1].end = 0x3F6; dev->resource[1].flags = LEGACY_IO_RESOURCE; } if ((progif & 4) == 0) { dev->resource[2].start = 0x170; dev->resource[2].end = 0x177; dev->resource[2].flags = LEGACY_IO_RESOURCE; dev->resource[3].start = 0x376; dev->resource[3].end = 0x376; dev->resource[3].flags = LEGACY_IO_RESOURCE; } + if ((progif & 5) == 0 + && (dev->resource[5].flags & IORESOURCE_MEM) + && dev->resource[5].start == 0 + && dev->resource[5].end != 0) { + dev->resource[5].flags = 0; + dev->resource[5].end = 0; + } } break; case PCI_HEADER_TYPE_BRIDGE: /* bridge header */ if (class != PCI_CLASS_BRIDGE_PCI) goto bad; /* The PCI-to-PCI bridge spec requires that subtractive decoding (i.e. transparent) bridge must have programming interface code of 0x01. */ pci_read_irq(dev); dev->transparent = ((dev->class & 0xff) == 1); pci_read_bases(dev, 2, PCI_ROM_ADDRESS1); set_pcie_hotplug_bridge(dev); pos = pci_find_capability(dev, PCI_CAP_ID_SSVID); if (pos) { pci_read_config_word(dev, pos + PCI_SSVID_VENDOR_ID, &dev->subsystem_vendor); pci_read_config_word(dev, pos + PCI_SSVID_DEVICE_ID, &dev->subsystem_device); } break; case PCI_HEADER_TYPE_CARDBUS: /* CardBus bridge header */ if (class != PCI_CLASS_BRIDGE_CARDBUS) goto bad; pci_read_irq(dev); pci_read_bases(dev, 1, 0); pci_read_config_word(dev, PCI_CB_SUBSYSTEM_VENDOR_ID, &dev->subsystem_vendor); pci_read_config_word(dev, PCI_CB_SUBSYSTEM_ID, &dev->subsystem_device); break; default: /* unknown header */ dev_err(&dev->dev, "unknown header type %02x, " "ignoring device\n", dev->hdr_type); return -EIO; bad: dev_err(&dev->dev, "ignoring class %02x (doesn't match header " "type %02x)\n", class, dev->hdr_type); dev->class = PCI_CLASS_NOT_DEFINED; } /* We found a fine healthy device, go go go... */ return 0; } static void pci_release_capabilities(struct pci_dev *dev) { pci_vpd_release(dev); pci_iov_release(dev); } /** * pci_release_dev - free a pci device structure when all users of it are finished. * @dev: device that's been disconnected * * Will be called only by the device core when all users of this pci device are * done. */ static void pci_release_dev(struct device *dev)