From patchwork Thu Jun 21 20:24:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Myron Stowe X-Patchwork-Id: 166384 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E2FE0B6FA1 for ; Fri, 22 Jun 2012 06:26:18 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932760Ab2FUUZJ (ORCPT ); Thu, 21 Jun 2012 16:25:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41034 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932219Ab2FUUZE (ORCPT ); Thu, 21 Jun 2012 16:25:04 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5LKOmCx022803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Jun 2012 16:24:48 -0400 Received: from amt.stowe (ovpn-113-41.phx2.redhat.com [10.3.113.41]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5LKOlfv021678; Thu, 21 Jun 2012 16:24:48 -0400 From: Myron Stowe Subject: [PATCH 5/9] parisc/PCI: move final fixup quirks from __init to __devinit To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux@arm.linux.org.uk, ralf@linux-mips.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org Date: Thu, 21 Jun 2012 14:24:47 -0600 Message-ID: <20120621202447.16865.32486.stgit@amt.stowe> In-Reply-To: <20120621202415.16865.6226.stgit@amt.stowe> References: <20120621202415.16865.6226.stgit@amt.stowe> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The PCI subsystem's final fixups are executed once during boot, after the pci-device is found. As long as the system does not support hot-plug, specifying __init is fine. With hot-plug, either physically based hot-plug events or pseudo hot-plug events such as "echo 1 > /sys/bus/pci/rescan", it is possible to remove a PCI bus during run time and have it rediscovered which will require the call of the fixups again in order for the device to function properly. This patch prepares specific quirk(s) for use with hot-plug events. Signed-off-by: Myron Stowe --- drivers/parisc/superio.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c index 5003458..2d24cf2 100644 --- a/drivers/parisc/superio.c +++ b/drivers/parisc/superio.c @@ -149,8 +149,7 @@ superio_interrupt(int parent_irq, void *devp) } /* Initialize Super I/O device */ -static void -superio_init(struct pci_dev *pcidev) +static void __devinit superio_init(struct pci_dev *pcidev) { struct superio_device *sio = &sio_dev; struct pci_dev *pdev = sio->lio_pdev;