Message ID | 20120521170539.GA13635@google.com |
---|---|
State | Not Applicable |
Headers | show |
On Mon, May 21, 2012 at 10:05 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: > > Please pull the signed tag "pci-for-3.5" to get these PCI changes for the > v3.5 merge window. I'm a newbie, so don't hesitate to help me improve my > pull requests :) Looks fine, except please actually mention the tag itself on the repo pull line. IOW, not like this: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next but simply git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-for-3.5 otherwise it's much too easy for my to just cut-and-paste the line you supplied without noticing that there was a tag mentioned earlier.. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 21, 2012 at 4:26 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > Looks fine, except please actually mention the tag itself on the repo > pull line. IOW, not like this: > >> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next > > but simply > > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git tags/pci-for-3.5 git request-pull seems to look for branches before tags when generating this text. It just did exactly the same thing for me (since the tag I created also pointed to my "next" branch). This would seem to be the common case for people following the rules and sending you stuff in the merge window that they have had cooking in linux-next. Can "request-pull" be smarter - or is their some magic I should be using on the "git request-pull" command line that will tell it that I really mean the tag and not the branch? Or is "smarter" already in a newer version of git - I have: $ git --version git version 1.7.9.5 -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 23, 2012 at 9:41 AM, Tony Luck <tony.luck@gmail.com> wrote: > > Or is "smarter" already in a newer version of git - I have: > > $ git --version > git version 1.7.9.5 I think you want 1.7.10 for anything to do with tagged messages. You can do everything with 1.7.9 (it can still handle the tags correctly), but it doesn't DTRT by default: you have to explicitly mention the "tag" part (ie you need to use "tags/xyz" instead of just "xyz"), and git pull-request doesn't realize that pulling a signed tag does more than just pulling the commit it points to etc etc. So with 1.7.9 you can make things work, but you would end up to work around the fact that the whole signed tag pulling wasn't really a real feature before that. So 1.7.10 is when pulling a signed tag was really introduced: it's just that earlier versions can still *create* those tags (so the only one who *had* to have 1.7.10 was the person doing the pull). I would strongly recommend just doing git clone git://github.com/gitster/git cd git make make install as just a normal user (*NOT* as root), which will install git in your ~/bin directory. Then, just make sure that you have ~/bin in your PATH before /usr/bin, and you're all set. No need to mess with or worry about distro git binaries - leave them alone, but get the best and the brightest for your own use. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 23, 2012 at 9:52 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > I would strongly recommend just doing > > git clone git://github.com/gitster/git > cd git > make > make install My distro needed some "curl" and "expat" bits added ... but that worked and I now have shiny new: $ git --version git version 1.7.10.2.552.gaa3bb87 which does indeed have a smarter git request-pull. Thanks -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html