| Message ID | 1723534943-28499-3-git-send-email-hongxing.zhu@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add dbi2 and atu for i.MX8M PCIe EP | expand |
On 13/08/2024 09:42, Richard Zhu wrote: > Add dbi2 and iatu reg for i.MX8MQ PCIe EP. > > For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the > driver. This method is not good. > > In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), > Frank suggests to fetch the dbi2 and atu from DT directly. This commit is > preparation to do that for i.MX8MQ PCIe EP. > > These changes wouldn't break driver function. When "dbi2" and "atu" > properties are present, i.MX PCIe driver would fetch the according base > addresses from DT directly. If only two reg properties are provided, i.MX > PCIe driver would fall back to the old method. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> Stop adding fake tags. This never happened. If it happened, provide lore link. Best regards, Krzysztof
On 13/08/2024 10:54, Krzysztof Kozlowski wrote: > On 13/08/2024 09:42, Richard Zhu wrote: >> Add dbi2 and iatu reg for i.MX8MQ PCIe EP. >> >> For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the >> driver. This method is not good. >> >> In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), >> Frank suggests to fetch the dbi2 and atu from DT directly. This commit is >> preparation to do that for i.MX8MQ PCIe EP. >> >> These changes wouldn't break driver function. When "dbi2" and "atu" >> properties are present, i.MX PCIe driver would fetch the according base >> addresses from DT directly. If only two reg properties are provided, i.MX >> PCIe driver would fall back to the old method. >> >> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> >> Reviewed-by: Frank Li <Frank.Li@nxp.com> > > Stop adding fake tags. This never happened. If it happened, provide lore > link. > Ah, my bad, now I see it. It's fine, sorry. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index e03186bbc415..d51de8d899b2 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -1819,9 +1819,11 @@ pcie1: pcie@33c00000 { pcie1_ep: pcie-ep@33c00000 { compatible = "fsl,imx8mq-pcie-ep"; - reg = <0x33c00000 0x000400000>, - <0x20000000 0x08000000>; - reg-names = "dbi", "addr_space"; + reg = <0x33c00000 0x100000>, + <0x20000000 0x8000000>, + <0x33d00000 0x100000>, + <0x33f00000 0x100000>; + reg-names = "dbi", "addr_space", "dbi2", "atu"; num-lanes = <1>; interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "dma";
Add dbi2 and iatu reg for i.MX8MQ PCIe EP. For i.MX8M PCIe EP, the dbi2 and atu addresses are pre-defined in the driver. This method is not good. In commit b7d67c6130ee ("PCI: imx6: Add iMX95 Endpoint (EP) support"), Frank suggests to fetch the dbi2 and atu from DT directly. This commit is preparation to do that for i.MX8MQ PCIe EP. These changes wouldn't break driver function. When "dbi2" and "atu" properties are present, i.MX PCIe driver would fetch the according base addresses from DT directly. If only two reg properties are provided, i.MX PCIe driver would fall back to the old method. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)