From patchwork Tue Sep 18 15:18:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Douglas X-Patchwork-Id: 971158 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cadence.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="H/wM8pat"; dkim=pass (1024-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="jlAnVyeM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42F69X40Qpz9s9h for ; Wed, 19 Sep 2018 01:19:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728982AbeIRUwo (ORCPT ); Tue, 18 Sep 2018 16:52:44 -0400 Received: from mx0b-0014ca01.pphosted.com ([208.86.201.193]:59685 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727756AbeIRUwo (ORCPT ); Tue, 18 Sep 2018 16:52:44 -0400 Received: from pps.filterd (m0042333.ppops.net [127.0.0.1]) by mx0b-0014ca01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8IFJ0T6011110; Tue, 18 Sep 2018 08:19:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=proofpoint; bh=kcWCffm62qcV9t78gr7YinoBmsqYOWmSzIJTeCfC1Ms=; b=H/wM8patGLTlP2YR6Mfk5v/Vz2M7lmSIYVc1ygjeM3+GfMzCXVjU/zrpEohcTA+aqP5U U5oR+/jQhEejoM6uSeAtryizo2QlSrFY4Dxl9Fo0Umn8HuNU7+aBKfRYDx7cMSABtmTV OtBryDaS4FJVyrfQDTTTTdVkKqAtM3hwX8lFN6pFwd8HZ8sq5cxFjjRQPksGSv/5rqXn YLtebJRTc16FfBE0ttTkf6jGgpeLQ++vnmdbFTO7k27VSQIWPwiz12gWCiR5drCto7uz YBP4kJz3nwoBF1WL3uM/1XNeYCiYDu3Z81xByv2oURIni8Mp4ID/sA0ZM1e2U1RQb/zW Tw== Authentication-Results: cadence.com; spf=pass smtp.mailfrom=adouglas@cadence.com Received: from nam03-dm3-obe.outbound.protection.outlook.com (mail-dm3nam03lp0024.outbound.protection.outlook.com [207.46.163.24]) by mx0b-0014ca01.pphosted.com with ESMTP id 2mgwnv7q41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 18 Sep 2018 08:19:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcWCffm62qcV9t78gr7YinoBmsqYOWmSzIJTeCfC1Ms=; b=jlAnVyeMD/zpptTN3T3gUm4PbMBXhqbvPdTb357TOjRtWNKcC40x9+ZJ35NqNoG7lBfzM6/l5qtWfP0gAq7IKElog1pXH6+ub/JuZKcRLJXWfKnbrNXlr2S7nsKuqMFV7tBDBsiOtTiFRy6AkL6IZHqd6YU6kjNkiP1K4MK+VmE= Received: from CY1PR07CA0028.namprd07.prod.outlook.com (2a01:111:e400:c60a::38) by BN4PR07MB2164.namprd07.prod.outlook.com (2a01:111:e400:59c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Tue, 18 Sep 2018 15:19:25 +0000 Received: from DM3NAM05FT003.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::200) by CY1PR07CA0028.outlook.office365.com (2a01:111:e400:c60a::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1143.15 via Frontend Transport; Tue, 18 Sep 2018 15:19:25 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx1.cadence.com (158.140.1.28) by DM3NAM05FT003.mail.protection.outlook.com (10.152.98.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.1185.5 via Frontend Transport; Tue, 18 Sep 2018 15:19:24 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx1.cadence.com (8.14.4/8.14.4) with ESMTP id w8IFJMuY022233 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 18 Sep 2018 08:19:23 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 18 Sep 2018 17:19:08 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Tue, 18 Sep 2018 17:19:08 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w8IFJ0EO018462; Tue, 18 Sep 2018 16:19:00 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w8IFIx55018443; Tue, 18 Sep 2018 16:18:59 +0100 From: Alan Douglas To: CC: , , , , , Alan Douglas Subject: [PATCH v3 2/5] PCI: cadence: Write MSI data with 32bits Date: Tue, 18 Sep 2018 16:18:56 +0100 Message-ID: <1537283936-18335-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(136003)(39860400002)(376002)(396003)(346002)(2980300002)(36092001)(189003)(199004)(316002)(54906003)(126002)(8676002)(26005)(476003)(2906002)(356003)(16586007)(426003)(14444005)(105596002)(42186006)(486006)(336012)(106466001)(2616005)(86362001)(7636002)(47776003)(186003)(2351001)(246002)(8936002)(478600001)(4326008)(48376002)(50466002)(5660300001)(36756003)(305945005)(51416003)(26826003)(50226002)(6666003)(6916009)(107886003)(87636003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN4PR07MB2164; H:sjmaillnx1.cadence.com; FPR:; SPF:SoftFail; LANG:en; PTR:corp.cadence.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; DM3NAM05FT003; 1:pLs2rTx0XLTT7/PvV2XORT10Vzrv4tvt3oWvtFtNgR9afsJNIP5UxGPaL/1LowQuFZU0dMpdWk44+Kf3Pfmq17hYThMgZo6or1lswu8UpbV9JHJkT3WPElaUtBKId9rg X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1bf929b0-88d3-4e1b-bd1c-08d61d7a1e57 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060); SRVR:BN4PR07MB2164; X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2164; 3:tpPKFcqbk4TjCqanSoP1d4tmuVwZU/IjfNCeJq8mjFgEt8lPsW9puc3yOdis98VitOxymNCnYClsicbuTi54gX9Cs06r8e8SUngMNRlafXcij1f+QDeIvfyYzI6bCONXyeU5pW3msdO2C03MjPfdqZoNfI9lfnNAYv0WJJYTfmsRQfearveNqOLalmpVBpPeCcI2Za7yC9P4RNiTvtyxPgpWDQDaZAFfYiRHNWO7SMokGMWExE3vstdSIBSv60exiUSXhy/JaNWKK8kv4svUS/31Srqqrpljl7sfh7QZkzeljkG9OQv0ioKdewUA92f+txc7IsAyQGEYjBnKZCt3aEZOC5DfY0h6rY/FaSe1xrQ=; 25:bfA0isyYItYB73iT5v+kOxk6G1fYP95HVZ/sVc5zs2iQj/5JOkkQ9H5e+PeVn7aM8a1LCqE/FBwiXmEE5vxsU8JG+5aSMlzO5EZ9UosOx4WwCKtWSdNmHf2g7wvr7Ym3/G3oU5ptyWBZCdkB6PypjqmIS8j03QdhViL8GbHUjqGwW0m+Nd5/JWycV51vM52sjym8GXq5PDGDa/vUMB6svSPYiWwy1CZO2h5w/r7qKLQ1ICi3avhzFGXL1eG4dU9VyRqIdbigBIJH/S1R45m9nuySaXF/NKQ4soTZjaucIj58iQbu/jPRwRE16ZsXGLU8i7t7YAKRUYf22a8g6yFLTQ== X-MS-TrafficTypeDiagnostic: BN4PR07MB2164: X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2164; 31:fqb+uoMnZ/igg0SSexrzCw8ePptvr2meHnII36/tU0zr6d6LA5HNGqBqZu1OWyg0RBmj7FNTgY+RmemCeDMKa7gEwWgzA4oZot4/tVQtUDkKp8EAGsop18jYWY52uv7HL0/r1KDT71hpelnnPAvWqREmeNKM23wXNsakp3c691TyR2/yOBmkFM+18NIHkK3iOiCzljuZsYr2T0jrM5u37vndiCJ5SZxDlclclqp0kbA=; 20:Wk+Py6qpStK6U72pFCjrSSNAhSrqiWOLmQInv559aAebNxBC5zv/IZHH0I2fEQDM6+F1hK5NtCcgogewfL1MFOykcyhTGzT6FkWVzt1QjrG8pRIbJP1Ze7OvJgITeWasSpX+6ot5VQiyKlukmyjv6SS3OoDHo6/ABjOWSeqEDZWEmv08vLGfv+8Xln3UicLLQV78vQVtVhb+h8qNcP66+tU3h/pEJrTK+maQ8AUoVIec3zd3gZJf/poHvP1q+6QXGCdNF778G4+ImpfXAVacC7M8+o2qK5nze5BsignIUYFaPBlepWjYTwWbMqw/y/5gSvsr9u1Dkf0Dqnfw/NH8UoRgEk6uVQbz+wvf+87cWQeoCVDtbMmXAyguuGlB6tlZTpHUa7C59ydACdcEHRmrSkFrvYBUHdwDHN1bFkFgRLr1CHBod0XDzhhmNimFQ+Qyhd585i0JJMI+FlUP7E/tR1umDx41cQlhApibTmE0YNkTmEfQ6i0nTeLdrYKeuA5z X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93003095)(3002001)(3231355)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699050); SRVR:BN4PR07MB2164; BCL:0; PCL:0; RULEID:; SRVR:BN4PR07MB2164; X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2164; 4:a2I1UTRexgnmhmt6mjq9dq/jcA2iNrrzUro4fGzfUpOg+Pq4+rPXg0tkiu0Gt9OKlLdSXA52PH4xu8iOU3Y6EG8spXXEQQDhpe/w6KXfQnIzqdHbl2LPXA7jD8Z7GHumhHDFpgJr1ooCzRvMTRAB8TxWHFTkYaFw7QUwne35CkkRFskKp/b/ObLH7V528WWBJ3Htaw4TrPWxH0kk2CbmDXSq5BrzviqJilaj8qzyDlprrU+OdUT9tO2zf5Wt7izN8hKA4UEv1jmmdVBmPwG/6X0hUlTe6hlHNgHPDRBbLUw21uzPPNpOf1n1uXP6wnqO X-Forefront-PRVS: 0799B1B2D7 X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2164; 23:Y0BCbRUHbjHtZgz6ke2Ln56ive1DbXvhweEoXuN/2+ZXgmPia/0MmO91wDlURd+bP/28o5/qZDMTKxKHWYnOTIBvgaX864EM/wA1wP4l0KqUGeaLk/0aug7t6VCKbJ1kJ38ciPThyrl8dwkpLnw+MZ6Yexg2J0fP2ULhDGhf3SKFr3Jl09JZAys+kTo3lkPwfvJJD0rKwD+x49aYLKUPRsSqgdt55SmaIefC/I/PnbhIB4u1TFMJ6ui+uPvdepERvGClDA+XTa9KPHJurpsBrz+tgZVnkxswjMFNCtG/WSKjqM1XSgdw2WsTDU21MeNlJLOy3V8EI6gq/RDNhKn1I7DOg/ueRyq/caSjzA4a65n8BvCteD0suDPPjBG07AHJkAwalOTMYeMtHIxctfNmllSYKGMm31u+rlTBBxRyy5p2hBrFOliAEN7izpHHTc+sm9g1vPxNE7+fpUhfoDqhFKz1eWYmIGZBtJp65YrpyYdLTAwGLXGa3pPSNaFkxfskdDhUEMZbrYZuApDVSftCihMh03W8NcmTScfYcZcnu1NiI7Wk7V5XlRrQCG+Miaw1SB5+/rw88OK5cCysR4x2dPEc9yncpGR4MziYouHyKo5Y4uD1jzDSTQ0dGGr7q6xIVo5rtSdWsEV/RfCDnfy2t6qWMd8SJ8zRr65dVq/47kw9H1P3spO0wvqWbsUs67sxiQ+uJyIW8nrmClHcW09EkpkDuNXvbqj2W15igJmWYsreLqBRGV8kOeJ1uEtjsWn3AGDMTt/xpb2CslUnFgE+HFUYZJ0QQ+JoLhf/gbulIPbyMUcJBk81OcFHrCiOb6JUBuDyO65Nw+g9tqTTLMJXJClWhpKhuGGEp6Cd6Ctd1Gy+qskYsW+oOhvydpeBYzC2r/cb3yRh2u8T3X806GJ1QSiILkEobxJFC6wuGOQx0z4JtDXhXvB8oxtkgdRyhZs0sLyBPq0zOJywwDg2G6Esqi+23MMz9mtou5f7W15M9MJ+Zsir1BIepNZf6DEnW+8sS5caTc1i39ueVYLRgxc8oYS2ysj+9jgI831/UniXPmM= X-Microsoft-Antispam-Message-Info: LZqoXyCnB5wNDoLjZdfq8yXth4g6Hze/+9ZJUqxExunlJQ//mlpoOp0qW19QXly1cUC5dvzgb2Kg/Xyam/3hnNABTstxnGvmZe4EowjqNJVxtl2K1ufSgzo6JyIx4SBMlLyqMuab8wLAeCvugGDJWBFHy6b8cX72zVZ2px6PIODYLcoR+KjADjZgVMDiyHGnDcfj/u6Ixvmc+KZ2D642hdIztVOROeJe+pQlGYwmQZM+d4NP7f7s8k5TCCV3OHxyl8YxBw3P2M9tZo78WMquNrRJtbKOBBA9dtUD2Y5lMY+CNbu7au92T6CUSu8Lr63mztu7w5aMcaVQgHVZLmazh0nFHfmlw5IhV6JB568NGjgteTetok3u3ZZM4JRVhJM1EUNOob7RgzCjjWX+ORWX3Q== X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2164; 6:AsUTmnZsDXDtYVuu32q3sNzEljXs93UpTlTKrAQB+5+Ho69hw5clMqLrC3hlY6md8siTz0UhBWx+745GOqjfIGpdz5kMfFRpXWy7nf6S5c1gzCPqEnip+DiUk1bl8ojd/Kul0kxB4owtsP9bysN2VNHkjDSSe4ldN8MreJYCdGOpBl3L3LkidYENNUiWx8AUtVvL8LmIkUTMsTHH9EDZfqbLIe53OpiJZPDcPWLyLGRT4jDdxnUZzglNvfjEk+mPJ9uL0gbXvpwnv6bk7fJpXAddRJJ7WvkGsh3vGnL18OGx35bly4iD1t+XVCOdumHWi1aZ5UARZx38qKthwljbmnWTpjWVw428eLFsBcp+AMJ17/xLN5f1CFSkjVDFtRRdtJ0aPeIBxC1b+j6FRGuwKRIPFdNIzFP8hKVT3ZRnyhGz1RqW3TFqidNgJKag8/3Ux+MgYF+atFD/bNLYbt9k7g==; 5:CgfQaU33CnjrCR+2umbw3W5VpRrfK+jytVPTw+qrDT7wqLpIINihhLqrMjXo0qGSwlu283S5Bjs0WVA691RCUto8AZal0tEGg1lOXtl2Brx/DluOp2HG46pSpSw731d9lNI5lbb36vUdXIkH416axGHb0Y6BLLJaj7GsffQqU+w=; 7:IBst6k+1BOqNwgW3aB+8izP3bXlmDrgSHLir8iwjIs5+ImIumjNWHvq8vU8SDXGIBzXiiuC1yWPqOPggf84iefUeBxhwdHm11UTeMIbwrZPYjaR2iXT/ddJIp3OF0ZOLfz5fsurmfpv3GRnoXLCKInlMt+aFF908rcqt3gdTPSQQwESQ3hDN1u5T/Y/ulKL5u/7mtfvVO1yA6yMGc94ZJq+QyIRv69hBjmC5jo3AirNNaYX7tOF/nEatm4Mc7swL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2164; 20:imWhQbistT26rIrshmzZsxzwTQ/5Orp6VdotYkvMgFFZ1o/LYRksbKRXebrTaGv2g/tg+te1iytOB7so54nbKSBpO1AxOyq0XI3F+l6xWXKgDy0fDDjN9Lga1bvIN+9miKYJ/bLPW4Jj+kEcSJvWAJmXLQKm/YPBUdCPKR1UJcKlp+ZU50W8ZTnM9boF3lZNWgGG2R8tgdY2I9LZQPwG8titxbaRZjSgU6bKOTZBPwLjSjukOz7wTo8A9PqZQ93j X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2018 15:19:24.8192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1bf929b0-88d3-4e1b-bd1c-08d61d7a1e57 X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[158.140.1.28]; Helo=[sjmaillnx1.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2164 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 a:mx-sanjose2.Cadence.COM a:mx-sanjose4.Cadence.COM a:mx-sanjose5.Cadence.COM include:mktomail.com include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com include:auth.msgapp.com include:spf.mandrillapp.com ~all X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-09-18_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=810 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809180154 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org According to the PCIe specification, although the MSI data is only 16bits, the upper 16bits should be written as 0. Use writel instead of writew when writing the MSI data to the host. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas --- drivers/pci/controller/pcie-cadence-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index a67dc91..970d934 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -356,7 +356,7 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, ep->irq_pci_addr = (pci_addr & ~pci_addr_mask); ep->irq_pci_fn = fn; } - writew(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); + writel(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); return 0; }