From patchwork Mon Sep 5 20:05:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 666047 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sSgrj3cfPz9sBX for ; Tue, 6 Sep 2016 06:12:53 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=pptIuSQp; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935954AbcIEUIM (ORCPT ); Mon, 5 Sep 2016 16:08:12 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34601 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935919AbcIEUHT (ORCPT ); Mon, 5 Sep 2016 16:07:19 -0400 Received: by mail-lf0-f44.google.com with SMTP id u14so9939440lfd.1 for ; Mon, 05 Sep 2016 13:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DcQQtUQ4acqozErS36Vi8ijnizJVxmknq4k/mEYVHYI=; b=pptIuSQpqJQf3uKhGGN/obuz1WonSx2Hv/TU19ZbaKlSjU6GIe4tsZi7mFmREnlV2R Z33P5irPvNI6hSQedw4ZTJpJ5sYJ+vJ1GiSyQ7zKOGYyZT8iLqL4S7fcaecvrZ8mzSq6 b4O114qUNfk29RBsNjTd3EjleqgqFvHyqaMrvtD2v9zhfnJo4ivuC++TFGVayCq62FXP 2PTalFMHjqADr5aeXhDmQM/UKnJTp60+tm09f58QKqHkUJ8wX3Uc0oMeaPfmKzS8kaQ1 W1F+1dE85IME8sDrsrbdsM/356DIkF3K4QUfhEdV/jaCXBOBGnggZZPQZ6HJAR0cFRSe 4tog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DcQQtUQ4acqozErS36Vi8ijnizJVxmknq4k/mEYVHYI=; b=Em9eFE4djOH3ur55KgLO0ZQrasqaxai9Zeag2AngkxNOVRKodOhM8sPtKEBJLoViKd B3tQXw+y7U3B6oOyxte9+dqsKc3MoDNQEMxQp+0sKjp0ZbdYR+NlC9TXUHxB8eMrcvFM CnZ7BAp1sHEr6mDkJzGT0tzBwGskpsoxEf1tthBSjLC6qyxiiFA9ckrmHr/t0dZXwVus pd9V4TPeWaRsH5FziJEBuIJRcWrz2x8HtvyUpJA63O2YCCyVwn7eRM4IBwtOSU6oEW4P K2p9HEZSnFLr2ORIroXPkZ0i18Zyyx+GjfpCIBW/6/UE1HI0HwmHa3E45SaiF8XsR170 n2Zg== X-Gm-Message-State: AE9vXwPOV0lOCSjMPRwZA0sQ6G9n8E/F3HPeOCkheyrv8T6FYsUhBXaWaF2XYgW1yO1nZg== X-Received: by 10.25.21.160 with SMTP id 32mr8886231lfv.1.1473106037964; Mon, 05 Sep 2016 13:07:17 -0700 (PDT) Received: from localhost.localdomain (50-233-148-156-static.hfc.comcastbusiness.net. [50.233.148.156]) by smtp.gmail.com with ESMTPSA id p82sm5068405lfd.15.2016.09.05.13.07.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Sep 2016 13:07:17 -0700 (PDT) From: Tomasz Nowicki To: marc.zyngier@arm.com, tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, helgaas@kernel.org, rafael@kernel.org, Lorenzo.Pieralisi@arm.com Cc: will.deacon@arm.com, catalin.marinas@arm.com, hanjun.guo@linaro.org, shijie.huang@arm.com, robert.richter@caviumnetworks.com, mw@semihalf.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, andrea.gallo@linaro.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, al.stone@linaro.org, graeme.gregory@linaro.org, ddaney.cavm@gmail.com, okaya@codeaurora.org, Tomasz Nowicki Subject: [PATCH V9 4/8] irqchip/gicv3-its: Cleanup for ITS domain initialization Date: Mon, 5 Sep 2016 22:05:36 +0200 Message-Id: <1473105940-9761-5-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1473105940-9761-1-git-send-email-tn@semihalf.com> References: <1473105940-9761-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org There is no point to initialize ITS without having msi-controller property in corresponding DT node. However, its_probe is checking msi-controller presence at the end, so we can save our time and do that check prior to its_probe call. Also, for the code clarity purpose, we put domain initialization to separate function. Signed-off-by: Tomasz Nowicki Acked-by: Marc Zyngier Reviewed-by: Hanjun Guo --- drivers/irqchip/irq-gic-v3-its.c | 57 ++++++++++++++++++++++++---------------- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 36b9c28..943442d 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -1614,13 +1614,37 @@ static void its_enable_quirks(struct its_node *its) gic_enable_quirks(iidr, its_quirks, its); } +static int its_init_domain(struct device_node *node, struct its_node *its, + struct irq_domain *parent) +{ + struct irq_domain *inner_domain; + struct msi_domain_info *info; + + info = kzalloc(sizeof(*info), GFP_KERNEL); + if (!info) + return -ENOMEM; + + inner_domain = irq_domain_add_tree(node, &its_domain_ops, its); + if (!inner_domain) { + kfree(info); + return -ENOMEM; + } + + inner_domain->parent = parent; + inner_domain->bus_token = DOMAIN_BUS_NEXUS; + info->ops = &its_msi_domain_ops; + info->data = its; + inner_domain->host_data = info; + + return 0; +} + static int __init its_probe(struct device_node *node, struct irq_domain *parent) { struct resource res; struct its_node *its; void __iomem *its_base; - struct irq_domain *inner_domain; u32 val; u64 baser, tmp; int err; @@ -1712,28 +1736,9 @@ static int __init its_probe(struct device_node *node, writeq_relaxed(0, its->base + GITS_CWRITER); writel_relaxed(GITS_CTLR_ENABLE, its->base + GITS_CTLR); - if (of_property_read_bool(node, "msi-controller")) { - struct msi_domain_info *info; - - info = kzalloc(sizeof(*info), GFP_KERNEL); - if (!info) { - err = -ENOMEM; - goto out_free_tables; - } - - inner_domain = irq_domain_add_tree(node, &its_domain_ops, its); - if (!inner_domain) { - err = -ENOMEM; - kfree(info); - goto out_free_tables; - } - - inner_domain->parent = parent; - inner_domain->bus_token = DOMAIN_BUS_NEXUS; - info->ops = &its_msi_domain_ops; - info->data = its; - inner_domain->host_data = info; - } + err = its_init_domain(node, its, parent); + if (err) + goto out_free_tables; spin_lock(&its_lock); list_add(&its->entry, &its_nodes); @@ -1784,6 +1789,12 @@ int __init its_init(struct device_node *node, struct rdists *rdists, for (np = of_find_matching_node(node, its_device_id); np; np = of_find_matching_node(np, its_device_id)) { + if (!of_property_read_bool(np, "msi-controller")) { + pr_warn("%s: no msi-controller property, ITS ignored\n", + np->full_name); + continue; + } + its_probe(np, parent_domain); }