From patchwork Tue Jun 28 07:53:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 641397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rdyn95hjjz9s9Y for ; Tue, 28 Jun 2016 17:56:45 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=EDVa+MMp; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbcF1Hy1 (ORCPT ); Tue, 28 Jun 2016 03:54:27 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34159 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbcF1HyZ (ORCPT ); Tue, 28 Jun 2016 03:54:25 -0400 Received: by mail-lf0-f44.google.com with SMTP id h129so5564493lfh.1 for ; Tue, 28 Jun 2016 00:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wTIAf9xuuz/A0G7jasjypLHG4h3FMepc23ubCgLX3Uc=; b=EDVa+MMpyda7yMTnUrx7T3S/yESUyctxxbhWujAuS7rOvG3rseG4dTMJSXc2gxMsWh OeKqddfQQJS2DlbQAhTq5qZQytnZqgnn0uwkkEpAInRolSu7U+/D/ttsvDk0maWtuzWj Edk5K+SEVffqYcqCTOt8PHhi3cJJu89oXVIUC8woLupndSlNY8qhZkfvKSXLAjRfrmUa Bq0rhHTTYMz5MjCXVY3ncPLcSSebhjOdUjgyQxX0yjPJYPX59SQK3lSeDu+8RLeL8KSo 7t/EL98A4h3dB+ODqIUC4jArG7vX1Cq/anY9Nn2OKF7NJO7Tsv+blvhtfbdAlro9bdGz ueNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wTIAf9xuuz/A0G7jasjypLHG4h3FMepc23ubCgLX3Uc=; b=U5tgSnSTAOFfKWsv9NGdvfqZjQ8RbySPYld+zJ8MN9NsUwIbFnGS/7ppYvJ9mU/zc7 sEVxkqpBvoWa/kkfha+kcyFFuryOvmlkZVFgWHZODu1wvDdiE84t/a+58DIxZ7oOIE3L eU5JDk7792t8rXWIywJtOB6hLyiyTr9H9phdNTPUIHKWLFPE+GstjzC2Dfb7bNtUM2Hz /mRCGH43cLxnJqLecZe+sf3c/vBkaB2DFywcDbDLegEHyiB23FCiNxRd1M07hv9Ia4LD 3B1F27kvkeCI1pHVzZnelbW4WPABLDcQ63p16S4zIaK/vKFiEWMUC6IuhaA/pEc3ibXk aAxA== X-Gm-Message-State: ALyK8tLWToXyM95gBkWamYbykgSN/te9eR2Hx6RmTQ+o9pZfGFBxX5ZtjaD1RhRmZ0VY9Q== X-Received: by 10.25.21.169 with SMTP id 41mr445681lfv.124.1467100464033; Tue, 28 Jun 2016 00:54:24 -0700 (PDT) Received: from tn-HP-4.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id f66sm3856201lji.13.2016.06.28.00.54.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Jun 2016 00:54:23 -0700 (PDT) From: Tomasz Nowicki To: helgaas@kernel.org, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jchandra@broadcom.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, liudongdong3@huawei.com, cov@codeaurora.org, gabriele.paoloni@huawei.com, jhugo@codeaurora.org, Tomasz Nowicki Subject: [RFC PATCH v4 1/5] PCI: Embed pci_ecam_ops in pci_config_window structure Date: Tue, 28 Jun 2016 09:53:58 +0200 Message-Id: <1467100442-28078-2-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467100442-28078-1-git-send-email-tn@semihalf.com> References: <1467100442-28078-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org pci_config_window keeps pointer to pci_ecam_ops and every time we want to deallocate pci_config_window (pci_ecam_free()) we need to make sure to free pci_ecam_ops in case it was dynamically allocated prior to pci_ecam_create() call. To avoid that extra effort, embed pci_ecam_ops in pci_config_window, instead of just a pointer. Signed-off-by: Tomasz Nowicki To: Jayachandran C --- arch/arm64/kernel/pci.c | 2 +- drivers/pci/ecam.c | 6 +++--- include/linux/pci-ecam.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c index 94cd43c..cb4dee7 100644 --- a/arch/arm64/kernel/pci.c +++ b/arch/arm64/kernel/pci.c @@ -196,7 +196,7 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) return NULL; } - acpi_pci_root_ops.pci_ops = &ri->cfg->ops->pci_ops; + acpi_pci_root_ops.pci_ops = &ri->cfg->ops.pci_ops; bus = acpi_pci_root_create(root, &acpi_pci_root_ops, &ri->common, ri->cfg); if (!bus) diff --git a/drivers/pci/ecam.c b/drivers/pci/ecam.c index 43ed08d..24242f0 100644 --- a/drivers/pci/ecam.c +++ b/drivers/pci/ecam.c @@ -52,7 +52,7 @@ struct pci_config_window *pci_ecam_create(struct device *dev, return ERR_PTR(-ENOMEM); cfg->parent = dev; - cfg->ops = ops; + cfg->ops = *ops; cfg->busr.start = busr->start; cfg->busr.end = busr->end; cfg->busr.flags = IORESOURCE_BUS; @@ -138,7 +138,7 @@ void __iomem *pci_ecam_map_bus(struct pci_bus *bus, unsigned int devfn, int where) { struct pci_config_window *cfg = bus->sysdata; - unsigned int devfn_shift = cfg->ops->bus_shift - 8; + unsigned int devfn_shift = cfg->ops.bus_shift - 8; unsigned int busn = bus->number; void __iomem *base; @@ -149,7 +149,7 @@ void __iomem *pci_ecam_map_bus(struct pci_bus *bus, unsigned int devfn, if (per_bus_mapping) base = cfg->winp[busn]; else - base = cfg->win + (busn << cfg->ops->bus_shift); + base = cfg->win + (busn << cfg->ops.bus_shift); return base + (devfn << devfn_shift) + where; } diff --git a/include/linux/pci-ecam.h b/include/linux/pci-ecam.h index 7adad20..0ce2920 100644 --- a/include/linux/pci-ecam.h +++ b/include/linux/pci-ecam.h @@ -39,7 +39,7 @@ struct pci_config_window { struct resource res; struct resource busr; void *priv; - struct pci_ecam_ops *ops; + struct pci_ecam_ops ops; union { void __iomem *win; /* 64-bit single mapping */ void __iomem **winp; /* 32-bit per-bus mapping */