From patchwork Thu Feb 4 17:28:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 579057 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 24027140324 for ; Fri, 5 Feb 2016 04:34:48 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=lrTV6pls; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161030AbcBDReC (ORCPT ); Thu, 4 Feb 2016 12:34:02 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34467 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966146AbcBDR3R (ORCPT ); Thu, 4 Feb 2016 12:29:17 -0500 Received: by mail-wm0-f51.google.com with SMTP id 128so37634598wmz.1 for ; Thu, 04 Feb 2016 09:29:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XrfDmVfWXPZosi0D5+XQRLLvXCuNNfjdGgq1dgRxg5M=; b=lrTV6plslyDy83b/xUnqgM8OjVVnYIjTxAa5bvx90Ij+YOS95LhrjAcGgBgto72RHQ YmEmQr5BMgnsYj/4+jq9otuMZacJk8UOTgl6TEogXewheJn2OPN4xTc5S5W5yp1edl6Y 32pTGGU8f5Hc7EctE5Q/L1dLm5wTocHos5Zz80x8N913xgLR7pwDWhNwTCRKUZ025Bvr P9Jgvk6ECeeODl/9S1lMyF8RJ2ODg9PlDsTqUz+XDQ/VoCA6vCyZybc3+7tbee7dfyo1 DfpvxrI2mH0W9NNn9K6dEBF/Zy0CaOVdeYJ6DqahwLv+MYulb5FUqclmE+O5YESxZVrg 1bug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XrfDmVfWXPZosi0D5+XQRLLvXCuNNfjdGgq1dgRxg5M=; b=YPOItNGTFate0AOkTREN2CabzkYDt4JyQySHK66sH2ZkMcz9juGwqSuk1Mrp3NyED9 bQhofUvtJSiLNzlM7IWTW91D3KOWAzft2YB1fYyJznFNhVyLwDqUWeUWQ6hg8XRNPkd+ qVTB1yM8o6rfj7CbsWQVzl7tZ59Uoetr9ZU4iexND1N5RnEo6ollDhGLF6f9f8BLa0fc qn17SjXp5XmpvsClMaegRNazYd6Fk8SzJs/5r1NtfczjEPbSMmfsJS0k+mKsGFdJGF4j dxSKgAGCgjL+DzoGS3YIFvlaR8ohQ34wfZEFjpwsOIDUtw7p+eieCnrb35uUVaDZcZbw cDHw== X-Gm-Message-State: AG10YOSyi2/5SqryRc0AotE3Tm/6lBJeWOIS0X70tQf8PrG/dRhKBFnDlag1DQNBKkjM0g== X-Received: by 10.28.57.131 with SMTP id g125mr11062088wma.17.1454606956455; Thu, 04 Feb 2016 09:29:16 -0800 (PST) Received: from tn-HP-4.semihalf.local (cardhu.semihalf.com. [213.17.239.108]) by smtp.gmail.com with ESMTPSA id w8sm12238889wjx.21.2016.02.04.09.29.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Feb 2016 09:29:15 -0800 (PST) From: Tomasz Nowicki To: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com, Tomasz Nowicki Subject: [PATCH V4 10/23] x86, pci: Cleanup platform specific MCFG data by using ECAM hot_added flag. Date: Thu, 4 Feb 2016 18:28:48 +0100 Message-Id: <1454606941-9523-11-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1454606941-9523-1-git-send-email-tn@semihalf.com> References: <1454606941-9523-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Because of two facts: 1. MCFG region has hot_added flag 2. struct acpi_pci_root has topology info (domain, bus number) we can get rid of arch specific mcfg data from x86 struct pci_root_info. Signed-off-by: Tomasz Nowicki Tested-by: Suravee Suthikulpanit Tested-by: Duc Dang Tested-by: Dongdong Liu Tested-by: Hanjun Guo Tested-by: Graeme Gregory Tested-by: Sinan Kaya --- arch/x86/pci/acpi.c | 36 ++++++++++++++---------------------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c index a997d7c..8e89921 100644 --- a/arch/x86/pci/acpi.c +++ b/arch/x86/pci/acpi.c @@ -12,11 +12,6 @@ struct pci_root_info { struct acpi_pci_root_info common; struct pci_sysdata sd; -#ifdef CONFIG_PCI_MMCONFIG - bool mcfg_added; - u8 start_bus; - u8 end_bus; -#endif }; static bool pci_use_crs = true; @@ -180,16 +175,13 @@ static int check_segment(u16 seg, struct device *dev, char *estr) static int setup_mcfg_map(struct acpi_pci_root_info *ci) { - int result, seg; - struct pci_root_info *info; + int result, seg, start, end; struct acpi_pci_root *root = ci->root; struct device *dev = &ci->bridge->dev; - info = container_of(ci, struct pci_root_info, common); - info->start_bus = (u8)root->secondary.start; - info->end_bus = (u8)root->secondary.end; - info->mcfg_added = false; - seg = info->sd.domain; + seg = root->segment; + start = root->secondary.start; + end = root->secondary.end; /* return success if MMCFG is not in use */ if (raw_pci_ext_ops && raw_pci_ext_ops != &pci_mmcfg) @@ -198,13 +190,11 @@ static int setup_mcfg_map(struct acpi_pci_root_info *ci) if (!(pci_probe & PCI_PROBE_MMCONF)) return check_segment(seg, dev, "MMCONFIG is disabled,"); - result = pci_mmconfig_insert(dev, seg, info->start_bus, info->end_bus, - root->mcfg_addr); + result = pci_mmconfig_insert(dev, seg, start, end, root->mcfg_addr); if (result == 0) { /* enable MMCFG if it hasn't been enabled yet */ if (raw_pci_ext_ops == NULL) raw_pci_ext_ops = &pci_mmcfg; - info->mcfg_added = true; } else if (result != -EEXIST) return check_segment(seg, dev, "fail to add MMCONFIG information,"); @@ -214,14 +204,16 @@ static int setup_mcfg_map(struct acpi_pci_root_info *ci) static void teardown_mcfg_map(struct acpi_pci_root_info *ci) { - struct pci_root_info *info; + struct acpi_pci_root *root = ci->root; + struct pci_mmcfg_region *cfg; - info = container_of(ci, struct pci_root_info, common); - if (info->mcfg_added) { - pci_mmconfig_delete(info->sd.domain, - info->start_bus, info->end_bus); - info->mcfg_added = false; - } + cfg = pci_mmconfig_lookup(root->segment, root->secondary.start); + if (!cfg) + return; + + if (cfg->hot_added) + pci_mmconfig_delete(root->segment, root->secondary.start, + root->secondary.end); } #else static int setup_mcfg_map(struct acpi_pci_root_info *ci)