From patchwork Wed Jan 13 13:21:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 566914 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 709AB14076E for ; Thu, 14 Jan 2016 00:22:09 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=AW+qnAbJ; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933229AbcAMNVs (ORCPT ); Wed, 13 Jan 2016 08:21:48 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38663 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760253AbcAMNVq (ORCPT ); Wed, 13 Jan 2016 08:21:46 -0500 Received: by mail-wm0-f52.google.com with SMTP id b14so371536035wmb.1 for ; Wed, 13 Jan 2016 05:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7X8lWrfwaYXHNueZthGDkOeufhFovaXfxS4ACjIMSkM=; b=AW+qnAbJQ3uEr8JDarbe++TNNqUY560eZ0A4venElli9acgF/fszvjOaXjN7j4PuWc yy7wBHl/zTOz9Hf2ggN4BsHAPwzuZYgAz4oqpFZQpZtfr4wLf2Ow3GOr9U25Bp/RM0nP I6Cl5xNvn5pY5iQkVhEuMmWmy1OhI/+zgb6RYQvncqVAwSmB2zKrYmh6zPTtjn4pBOfS 1FX8Hhs5DPGR3vlxDckCuumn/ovBYvXmeJhAyOKhF1kY4UTRQ/hckasGafoxIR6jWZfb 9HmqZ7myfFPVUq56XaHDAJV7+CaIrtxXa6vgiL0g7+x27LUFD5bx1pn/0852dRASR61G gQmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7X8lWrfwaYXHNueZthGDkOeufhFovaXfxS4ACjIMSkM=; b=IEIUG3wFxyPd32kJqwqIJNqY0jw6FYulU25U100QNs0M8860rgTA/7PGOo4O0Nt78q MV+MZQiix9jVcdsIXTBVxa61WeTQOL+3DfKUrbH88tiNLzYTmq+ETWwloi8oKgek7qZH wVwRCS1p/N+UZ0E3m6SQaXv+dajbJNpXHkeK/cPldUarlTq9IPzI3+nWXAPmECNpBMvj 7z3DtSXv2ffvPRGg6Thz3uiobhhxoB++qWJEqBKImVNT19UIetuaUmko0Il30qRr1mq8 OT1ybvZWdK7yOmwfxTZZl4VV0Ygsy11YDuxfmAFaqL5e071Ycd+CuY6cXNW9UkC6Sb5t 92jw== X-Gm-Message-State: ALoCoQl2yc4aAYGAiHJVGlxRAHNjVggeex/Q0w6O4n4xjbXkrmAJs2jxiOgK1oC1OQeytXVITy3VYIwIhI83f+eWDKuTYaslMg== X-Received: by 10.194.222.135 with SMTP id qm7mr146436715wjc.106.1452691305580; Wed, 13 Jan 2016 05:21:45 -0800 (PST) Received: from tn-HP-4.semihalf.local (cardhu.semihalf.com. [213.17.239.108]) by smtp.gmail.com with ESMTPSA id y124sm8858741wmg.3.2016.01.13.05.21.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jan 2016 05:21:44 -0800 (PST) From: Tomasz Nowicki To: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, tglx@linutronix.de, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com, Tomasz Nowicki Subject: [PATCH V3 14/21] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation. Date: Wed, 13 Jan 2016 14:21:00 +0100 Message-Id: <1452691267-32240-15-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1452691267-32240-1-git-send-email-tn@semihalf.com> References: <1452691267-32240-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Arches in subject are the only one who use pcibios_{add|remove}_bus hooks and implement it in the same way. Moreover ARM64 is going to do the same. So it seams that acpi_pci_{add|remove}_bus is generic enough to be default option for pcibios_{add|remove}_bus hooks. Also, it is always safe to run acpi_pci_{add|remove}_bus as they have empty stubs for !ACPI case and return if ACPI has been switched off in run time. After all we can remove x86 and ia64 pcibios_{add|remove}_bus implementation. Signed-off-by: Tomasz Nowicki Reviewed-by: Lorenzo Pieralisi --- arch/ia64/pci/pci.c | 10 ---------- arch/x86/pci/common.c | 10 ---------- drivers/pci/probe.c | 3 +++ 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index 978d6af..be4c9ef 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c @@ -358,16 +358,6 @@ void pcibios_fixup_bus(struct pci_bus *b) platform_pci_fixup_bus(b); } -void pcibios_add_bus(struct pci_bus *bus) -{ - acpi_pci_add_bus(bus); -} - -void pcibios_remove_bus(struct pci_bus *bus) -{ - acpi_pci_remove_bus(bus); -} - void pcibios_set_master (struct pci_dev *dev) { /* No special bus mastering setup handling */ diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index eccd4d9..ed3236d 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -171,16 +171,6 @@ void pcibios_fixup_bus(struct pci_bus *b) pcibios_fixup_device_resources(dev); } -void pcibios_add_bus(struct pci_bus *bus) -{ - acpi_pci_add_bus(bus); -} - -void pcibios_remove_bus(struct pci_bus *bus) -{ - acpi_pci_remove_bus(bus); -} - /* * Only use DMI information to set this if nothing was passed * on the kernel command line (which was parsed earlier). diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index cad836f..2fbf840 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -2067,10 +2068,12 @@ int __weak pcibios_root_bridge_prepare(struct pci_host_bridge *bridge) void __weak pcibios_add_bus(struct pci_bus *bus) { + acpi_pci_add_bus(bus); } void __weak pcibios_remove_bus(struct pci_bus *bus) { + acpi_pci_remove_bus(bus); } struct pci_bus *pci_create_root_bus(struct device *parent, int bus,