From patchwork Wed Dec 16 15:16:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 557503 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EB31A140323 for ; Thu, 17 Dec 2015 02:18:08 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b=qGyDiQpi; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934012AbbLPPSB (ORCPT ); Wed, 16 Dec 2015 10:18:01 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36875 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933927AbbLPPR7 (ORCPT ); Wed, 16 Dec 2015 10:17:59 -0500 Received: by mail-wm0-f54.google.com with SMTP id p187so5610401wmp.0 for ; Wed, 16 Dec 2015 07:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cyL7E9gs9uQmXw5P8F3pqt9ky9ZrdTnl+L/3rC21jXg=; b=qGyDiQpiK50OZTwebTSA+xglRv6LYbraXsGomPT/MN1k/RM8nbUkXx0OnZIWhgu8Uz uSLWTm98kvI2cA5ATjBpR7nvyY8YhBQU3NaO5Fuetkmso6Z85d+6UlPUXflQs6A4FTuS cLyYgWMZ9F/BD8Eu9y9yxyVxYgTPNRdoCyC0CkMP2yDpJ6EDGkM0jDXKvY4j18A0VYpZ yjEucObPpt7sgaZ1kU2RKlxbIrlP7ncTjyS5JhCCtLS9Vek8NNPW8Rkr0NL/I67bjsRK 85G9Usb+BaWsLhDQJCsCz6T13dXbAOXS6o2nbs50BUmLZ2mnPipulH/Bv+GMyMr7lwfL 67PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cyL7E9gs9uQmXw5P8F3pqt9ky9ZrdTnl+L/3rC21jXg=; b=CCgL9aa4hEA7zf7mp2cXmhHq+aAAjzI1+m+eAW5pKAzCpg03SmhO/Dog3eJWBfRmbE PVhesgXtNp/7vfZyhfIlKF9c+vyBpip9gQ8Zm9QUFyFeD2jIuaHPTsiDoy9ulgvY7Z67 Hc/RxRRkkeDeCezirjrCxIvlY97jFi4jvGl+Ij7NeR7Kn9PmG69b8+QeK7/7uGO03Kyl QPUPhmehPCq0p/zvfQqA8vwZyR11w6YKO9RRzli6idcgS+Kcsht7u8ieQ+i8iA7veqry fcagmTd5gFsDvDr1/F5wDGaM8ETPs4xtjhrOAqZa3PSkyBYE3eOF78irsXlBRkmJAzP3 vLPQ== X-Gm-Message-State: ALoCoQlCVID5DPialNdgVROCd45uqQdVaRVE5/XWanf3mR7a9c1jLOzpmcnOP8u4SSfZ/SwNISgbk1fCX3kqg6gntg5t7IKwPA== X-Received: by 10.28.68.133 with SMTP id r127mr12328681wma.71.1450279077539; Wed, 16 Dec 2015 07:17:57 -0800 (PST) Received: from tn-HP-4.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id z17sm6438761wjq.1.2015.12.16.07.17.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 07:17:57 -0800 (PST) From: Tomasz Nowicki To: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, tglx@linutronix.de, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com, Tomasz Nowicki Subject: [PATCH V2 10/23] x86, pci: Cleanup platform specific MCFG data using previously added ECAM hot_added flag. Date: Wed, 16 Dec 2015 16:16:20 +0100 Message-Id: <1450278993-12664-11-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1450278993-12664-1-git-send-email-tn@semihalf.com> References: <1450278993-12664-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Now that we have hot_added flag and all information in struct acpi_pci_root we need, we can get rid of arch specific mcfg data from struct pci_root_info. Signed-off-by: Tomasz Nowicki Tested-by: Suravee Suthikulpanit --- arch/x86/pci/acpi.c | 36 ++++++++++++++---------------------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c index 64caf2b..56714a9 100644 --- a/arch/x86/pci/acpi.c +++ b/arch/x86/pci/acpi.c @@ -12,11 +12,6 @@ struct pci_root_info { struct acpi_pci_root_info common; struct pci_sysdata sd; -#ifdef CONFIG_PCI_MMCONFIG - bool mcfg_added; - u8 start_bus; - u8 end_bus; -#endif }; static bool pci_use_crs = true; @@ -180,16 +175,13 @@ static int check_segment(u16 seg, struct device *dev, char *estr) static int setup_mcfg_map(struct acpi_pci_root_info *ci) { - int result, seg; - struct pci_root_info *info; + int result, seg, start, end; struct acpi_pci_root *root = ci->root; struct device *dev = &ci->bridge->dev; - info = container_of(ci, struct pci_root_info, common); - info->start_bus = (u8)root->secondary.start; - info->end_bus = (u8)root->secondary.end; - info->mcfg_added = false; - seg = info->sd.domain; + seg = root->segment; + start = root->secondary.start; + end = root->secondary.end; /* return success if MMCFG is not in use */ if (raw_pci_ext_ops && raw_pci_ext_ops != &pci_mmcfg) @@ -198,13 +190,11 @@ static int setup_mcfg_map(struct acpi_pci_root_info *ci) if (!(pci_probe & PCI_PROBE_MMCONF)) return check_segment(seg, dev, "MMCONFIG is disabled,"); - result = pci_mmconfig_insert(dev, seg, info->start_bus, info->end_bus, - root->mcfg_addr); + result = pci_mmconfig_insert(dev, seg, start, end, root->mcfg_addr); if (result == 0) { /* enable MMCFG if it hasn't been enabled yet */ if (raw_pci_ext_ops == NULL) raw_pci_ext_ops = &pci_mmcfg; - info->mcfg_added = true; } else if (result != -EEXIST) return check_segment(seg, dev, "fail to add MMCONFIG information,"); @@ -214,14 +204,16 @@ static int setup_mcfg_map(struct acpi_pci_root_info *ci) static void teardown_mcfg_map(struct acpi_pci_root_info *ci) { - struct pci_root_info *info; + struct acpi_pci_root *root = ci->root; + struct pci_mmcfg_region *cfg; - info = container_of(ci, struct pci_root_info, common); - if (info->mcfg_added) { - pci_mmconfig_delete(info->sd.domain, - info->start_bus, info->end_bus); - info->mcfg_added = false; - } + cfg = pci_mmconfig_lookup(root->segment, root->secondary.start); + if (!cfg) + return; + + if (cfg->hot_added) + pci_mmconfig_delete(root->segment, root->secondary.start, + root->secondary.end); } #else static int setup_mcfg_map(struct acpi_pci_root_info *ci)