From patchwork Mon Oct 20 02:19:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Zhu X-Patchwork-Id: 400957 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1491B140095 for ; Mon, 20 Oct 2014 13:51:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbaJTCvl (ORCPT ); Sun, 19 Oct 2014 22:51:41 -0400 Received: from [207.46.100.141] ([207.46.100.141]:26448 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751993AbaJTCvf (ORCPT ); Sun, 19 Oct 2014 22:51:35 -0400 Received: from CO2PR03CA0012.namprd03.prod.outlook.com (10.141.194.139) by DM2PR0301MB0863.namprd03.prod.outlook.com (25.160.215.149) with Microsoft SMTP Server (TLS) id 15.0.1054.13; Mon, 20 Oct 2014 02:49:47 +0000 Received: from BN1AFFO11FD024.protection.gbl (2a01:111:f400:7c10::119) by CO2PR03CA0012.outlook.office365.com (2a01:111:e400:1414::11) with Microsoft SMTP Server (TLS) id 15.0.1054.13 via Frontend Transport; Mon, 20 Oct 2014 02:49:40 +0000 Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD024.mail.protection.outlook.com (10.58.52.84) with Microsoft SMTP Server (TLS) id 15.0.1049.20 via Frontend Transport; Mon, 20 Oct 2014 02:49:39 +0000 Received: from shlinux1.ap.freescale.net (shlinux1.ap.freescale.net [10.192.225.216]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id s9K2nZem019775; Sun, 19 Oct 2014 19:49:38 -0700 Received: by shlinux1.ap.freescale.net (Postfix, from userid 1003) id 004E71AE210; Mon, 20 Oct 2014 10:19:17 +0800 (CST) From: Richard Zhu To: CC: , , , , Richard Zhu , Richard Zhu Subject: [PATCH v7 06/13] PCI: designware: Fix one potential assignment error of cfg start Date: Mon, 20 Oct 2014 10:19:09 +0800 Message-ID: <1413771556-32212-7-git-send-email-richard.zhu@freescale.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1413771556-32212-1-git-send-email-richard.zhu@freescale.com> References: <1413771556-32212-1-git-send-email-richard.zhu@freescale.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:CAL; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(428002)(199003)(189002)(2351001)(107046002)(6806004)(229853001)(44976005)(19580395003)(92566001)(92726001)(19580405001)(68736004)(69596002)(93916002)(105586002)(99396003)(85852003)(95666004)(4396001)(103686003)(50226001)(47776003)(20776003)(84676001)(76482002)(89996001)(64706001)(52956003)(88136002)(120916001)(106466001)(81156004)(87936001)(87286001)(33646002)(26826002)(77096002)(102836001)(85306004)(110136001)(104166001)(16796002)(31966008)(97736003)(101416001)(21056001)(42186005)(46102003)(80022003)(48376002)(50466002)(76176999)(50986999)(46386002)(36756003)(77156001)(45336002)(62966002)(90966001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR0301MB0863; H:az84smr01.freescale.net; FPR:; MLV:ovrnspm; PTR:InfoDomainNonexistent; A:0; MX:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0863; X-Forefront-PRVS: 03706074BC Received-SPF: None (protection.outlook.com: shlinux1.ap.freescale.net does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is 192.88.158.2) smtp.mailfrom=r65037@shlinux1.ap.freescale.net; X-OriginatorOrg: freescale.com Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Richard Zhu if va_cfg0_base/va_cfg1_base are initialized by designware core, the pp->cfg.start is not initialized properly, when IORESOURCE_MEM "config" is represented as cfg space resource. solution: assign cfg_res->start to pp->cfg.start. Signed-off-by: Richard Zhu --- drivers/pci/host/pcie-designware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 1a2b477..3edd94d 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -450,6 +450,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp) if (cfg_res) { pp->config.cfg0_size = resource_size(cfg_res)/2; pp->config.cfg1_size = resource_size(cfg_res)/2; + pp->cfg.start = cfg_res->start; pp->cfg0_base = cfg_res->start; pp->cfg1_base = cfg_res->start + pp->config.cfg0_size;