mbox series

[v2,0/2] PCI/VPD: Improve handling binary sysfs attribute

Message ID 305704a7-f1da-a5a0-04e6-ee884be4f6da@gmail.com
Headers show
Series PCI/VPD: Improve handling binary sysfs attribute | expand

Message

Heiner Kallweit Feb. 3, 2021, 8:46 a.m. UTC 
Since 104daa71b396 ("PCI: Determine actual VPD size on first access")
there's nothing that keeps us from using a static attribute.
This allows to significantly simplify the code.

v2:
- switch to using PCI sysfs core code in patch 2

Heiner Kallweit (2):
  PCI/VPD: Remove dead code from sysfs access functions
  PCI/VPD: Let PCI sysfs core code handle VPD binary attribute

 drivers/pci/pci-sysfs.c | 54 +++++++++++++++++++++++---------
 drivers/pci/pci.h       |  2 --
 drivers/pci/vpd.c       | 68 -----------------------------------------
 3 files changed, 40 insertions(+), 84 deletions(-)

Comments

Bjorn Helgaas March 30, 2021, 9:53 p.m. UTC | #1 
On Wed, Feb 03, 2021 at 09:46:58AM +0100, Heiner Kallweit wrote:
> Since 104daa71b396 ("PCI: Determine actual VPD size on first access")
> there's nothing that keeps us from using a static attribute.
> This allows to significantly simplify the code.
> 
> v2:
> - switch to using PCI sysfs core code in patch 2
> 
> Heiner Kallweit (2):
>   PCI/VPD: Remove dead code from sysfs access functions
>   PCI/VPD: Let PCI sysfs core code handle VPD binary attribute
> 
>  drivers/pci/pci-sysfs.c | 54 +++++++++++++++++++++++---------
>  drivers/pci/pci.h       |  2 --
>  drivers/pci/vpd.c       | 68 -----------------------------------------
>  3 files changed, 40 insertions(+), 84 deletions(-)

Applied to pci/vpd for v5.13, thanks!