mbox series

[PATCHv2,0/2] pcie hotplug and error fixes

Message ID 20240612181625.3604512-1-kbusch@meta.com
Headers show
Series pcie hotplug and error fixes | expand

Message

Keith Busch June 12, 2024, 6:16 p.m. UTC 
From: Keith Busch <kbusch@kernel.org>

We' failures when dealing with certain overlapping pcie events. The
topology is essentially this:

  [Root Port] <-> [UpStream Port] <-> [DownStream Port] <-> [End Device]

An error between the DSP and ED triggers DPC. There's only inband
presence detection so it also triggers hotplug. Before the error
handling is completed, though, another error seen by the RP triggers its
own DPC handling.

The concurrent event handling reveals some interesting races, and this
patchset tries to address these without fundamentally changing the
locking scheme.

v1->v2:

  Fixed compiler error for !CONFIG_PCI (lkp)

Keith Busch (2):
  PCI: pciehp: fix concurrent sub-tree removal deadlock
  PCI: err: ensure stable topology during handling

 drivers/pci/hotplug/pciehp_pci.c | 12 +++++++++---
 drivers/pci/pci.h                |  1 +
 drivers/pci/pcie/err.c           |  8 +++++++-
 drivers/pci/probe.c              | 24 ++++++++++++++++++++++++
 include/linux/pci.h              |  2 ++
 5 files changed, 43 insertions(+), 4 deletions(-)