From patchwork Wed Apr 3 21:38:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 1919431 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=BwRCcLQh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-pci+bounces-5638-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V8ynN2jNpz1yZH for ; Thu, 4 Apr 2024 08:39:20 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 581AEB2194D for ; Wed, 3 Apr 2024 21:39:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55A52156877; Wed, 3 Apr 2024 21:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="BwRCcLQh" X-Original-To: linux-pci@vger.kernel.org Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7845F156258 for ; Wed, 3 Apr 2024 21:39:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712180350; cv=none; b=dnHo5mEANUN+5USBY/YlbpWYMZPR/GWqhmR/hSasWsfWLp2b2PVgWZvLxPS2IrXdB2Lhk2E85ZS4Sn5qdH0XSrt+Vf5/jUtHwwxVTB4BEambMY6oPFu8FampbgAFxPz+wEwcvyzkbopxrQ4TJNnnTmKfm29EUz5KPVTP6L6Vs84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712180350; c=relaxed/simple; bh=nEIPQ6XK51d8j65ufSxu0Wy3s7qOfcnZHH7/EHrsrCs=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type; b=Sz3zwN82106xKAb6Jpysya4rmqKMfgy3ZrniVBa9uA5w/0/QOGBGPkFKZ6lzeb636a6ut4md4U5AjzUYZMzw/qZDIMz+Id/2ZqMpqKdQ4pPHTfXXfD2J9r/Kj5MQGR/jP11MuGBEAz6F4gZUCaBlHqxFxZeP+KHNR4PpySMtNAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=BwRCcLQh; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-699312b101fso841636d6.1 for ; Wed, 03 Apr 2024 14:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1712180346; x=1712785146; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vp4sdfJe3BTx0dtdR+UBCMXUsH+qYgWG40Z+x43+SXE=; b=BwRCcLQhX8umVwSQwf8W78YGeZ2mcuwMr+diz+KOxXfqssP6U5BIbCPbq8hYyPoFri A+HRRCBRkPBKMOJER3uETTAroqzGey700tGBOHLR+7i30U/DgKDJ+dA6mUjKnQiQAB0L kH/4UKgNEg09InLBRtLI15csb2rAxjYpJbMiM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712180346; x=1712785146; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vp4sdfJe3BTx0dtdR+UBCMXUsH+qYgWG40Z+x43+SXE=; b=nkI29wBSGOo6B4c185pJgpMgr0ws367cup7HA72f90rbNcFSj5FYpwYEANHMxcglxz wmsxohXkYYuF3YrK2LIKkWHk7VQyKwHQjdZ/rqZapJQBiJ/T4NPvnBw/NDFTHX5GK6h7 XkB9txITUkmH8veqIUsEigVVmCealfdjJstsAVXyt6Lb0MVdh4/0iloUPZTsdgrEx3oP UqvBwq/tyuMtXyWe5XNJQx7PKlnqEuFy5cYxbH2ibjcKXB0LnI/9U+K/kD3pp2JLu9pN SBUYisxgRzP6RdD+WcO2aIKkTDmcKor9HpiR6DN7W7gBpIGr3z7cU8OLIgSVVBTegUzG +PDg== X-Gm-Message-State: AOJu0Yz//hUWu6SIYF0VeEfTRJx9pDZrnvMaF0XPw7/xw8SLwpBVT9Z5 bNGfM6+L4LAThEBKzsP7BETYqa1VOxCzoNqcvlWyM05wxpQ3cAsfjr3B4HWpBzH4465FdmS+yiW TpPtWAbcatnIcH03vftshczmX+kig01uPKiqMYWoDfQPq0O+hz0QElwX1ghupa7aZaQxjLdjru2 rpEQU+zF8dQLsVr9VXEzztBxAQnZZfqWSG80bGtiROPB6goA== X-Google-Smtp-Source: AGHT+IGni7gUlENPqzNkj4V/aInZkN+dBK2xlOx2HZCXjX4JhCqOiBtP3UpMHcyGVCDFWcHfeVazag== X-Received: by 2002:ad4:4eef:0:b0:699:3051:a7e5 with SMTP id dv15-20020ad44eef000000b006993051a7e5mr624650qvb.30.1712180346234; Wed, 03 Apr 2024 14:39:06 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id pi10-20020a0562144a8a00b0069903cddc96sm1750739qvb.18.2024.04.03.14.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 14:39:05 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , =?utf-8?q?Krzyszto?= =?utf-8?q?f_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi , Rob Herring Subject: [PATCH v9 0/4] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Date: Wed, 3 Apr 2024 17:38:57 -0400 Message-Id: <20240403213902.26391-1-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: v9 -- v8 was setting an internal bus timeout to accomodate large L1 exit latencies. After meeting the PCIe HW team it was revealed that the HW default timeout value was set low for the purposes of HW debugging convenience; for nominal operation it needs to be set to a higher value independent of this submission's purpose. This is now a separate commit. -- With v8, Bjorne asked what was preventing a device from exceeding the time required for the above internal bus timeout. The answer to this is for us to set the endpoints' max latency {no-,}snoop value to something below this internal timeout value. If the endpoint respects this value as it should, it will not send an LTR request with a larger latency value and not put itself in a situation that requires more latency than is possible for the platform. Typically, ACPI or FW sets these max latency values. In most of our systems we do not have this happening so it is up to the RC driver to set these values in the endpoint devices. If the endpoints already have non-zero values that are lower than what we are setting, we let them be, as it is possible ACPI or FW set them and knows something that we do not. -- The "clkreq" commit has only been changed to remove the code that was setting the timeout value, as this code is now its own commit. v8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn) -- Squashed last two commits of v7 (Bjorn) -- Fix DT binding description text wrapping (Bjorn) -- Fix incorrect Spec reference (Bjorn) s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/ -- Text substitutions (Bjorn) s/WRT/With respect to/ s/Tclron/T_CLRon/ v7 -- Manivannan Sadhasivam suggested (a) making the property look like a network phy-mode and (b) keeping the code simple (not counting clkreq signal appearances, un-advertising capabilites, etc). This is what I have done. The property is now "brcm,clkreq-mode" and the values may be one of "safe", "default", and "no-l1ss". The default setting is to employ the most capable power savings mode. v6 -- No code has been changed. -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) -- Changed sign-off and author email address for all commits. This was due to a change in Broadcom's upstreaming policy. v5 -- Remove DT property "brcm,completion-timeout-us" from "DT bindings" commit. Although this error may be reported as a completion timeout, its cause was traced to an internal bus timeout which may occur even when there is no PCIe access being processed. We set a timeout of four seconds only if we are operating in "L1SS CLKREQ#" mode. -- Correct CEM 2.0 reference provided by HW engineer, s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) -- Add newline to dev_info() string (Stefan) -- Change variable rval to unsigned (Stefan) -- s/implementaion/implementation/ (Bjorn) -- s/superpowersave/powersupersave/ (Bjorn) -- Slightly modify message on "PERST#" commit. -- Rebase to torvalds master v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC driver probe() time. This is done in Raspian Linux and its absence may be the cause of a failing test case. -- New commit that removes stale comment. v3 -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) -- Put binding names in DT commit Subject (Bjorn) -- Add a verb to a commit's subject line (Bjorn) -- s/accomodat(\w+)/accommodat$1/g (Bjorn) -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) v2 -- Changed binding property 'brcm,completion-timeout-msec' to 'brcm,completion-timeout-us'. (StefanW for standard suffix). -- Warn when clamping timeout value, and include clamped region in message. Also add min and max in YAML. (StefanW) -- Qualify description of "brcm,completion-timeout-us" so that it refers to PCIe transactions. (StefanW) -- Remvove mention of Linux specifics in binding description. (StefanW) -- s/clkreq#/CLKREQ#/g (Bjorn) -- Refactor completion-timeout-us code to compare max and min to value given by the property (as opposed to the computed value). v1 -- The current driver assumes the downstream devices can provide CLKREQ# for ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle L1SS-capable devices. -- The Raspian Linux folks have already been using a PCIe RC property "brcm,enable-l1ss". These commits use the same property, in a backward-compatible manner, and the implementaion adds more detail and also automatically identifies devices w/o a clkreq# signal, i.e. most devices plugged into an RPi CM4 IO board. Jim Quinlan (4): dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" PCI: brcmstb: Set reasonable value for internal bus timeout PCI: brcmstb: Set downstream maximum {no-}snoop LTR values PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device .../bindings/pci/brcm,stb-pcie.yaml | 18 ++ drivers/pci/controller/pcie-brcmstb.c | 161 +++++++++++++++++- 2 files changed, 170 insertions(+), 9 deletions(-) base-commit: 9f8413c4a66f2fb776d3dc3c9ed20bf435eb305e Tested-by: Cyril Brulebois