| Message ID | 20240126-dt-bindings-pci-qcom-split-v3-0-f23cda4d74c0@linaro.org |
|---|---|
| Headers | show |
| Series | dt-bindings: PCI: qcom: move to dedicated schema (part one) | expand |
On 26/01/2024 09:56, Krzysztof Kozlowski wrote: > Hi, > > Changes in v3: > - sm8450: add missing allOf: to common schema, which also fixes issue > reported by Rob's robot. > - Link to v2: https://lore.kernel.org/r/20240125-dt-bindings-pci-qcom-split-v2-0-6b58efd91a7a@linaro.org > > Changes in v2: > - Switch on SM8[123456]50 to 8 MSI interrupts. > - Simplify SM8450 clocks. > - Add Acks/Rb. > - Link to v1: https://lore.kernel.org/r/20240108-dt-bindings-pci-qcom-split-v1-0-d541f05f4de0@linaro.org > > DTS fixes for interrupts will be send separately > > The qcom,pcie.yaml containing all devices results in huge allOf: section > with a lot of if:then: clauses making review and changes quite > difficult. > > Split common parts into common schema and then move few devices to > dedicated files, so that each file will be easier to review. > > I did not split/move all devices yet, so if this gets accepted I plan to > send more patches. Krzysztof W., Bjorn H., Lorenzo, Any comments from your side? If not, could you apply the series? I already have work on top of this and other people are sending patches touching same diff-context, so they should rebase on top of this. Best regards, Krzysztof
Hello, > Changes in v3: > - sm8450: add missing allOf: to common schema, which also fixes issue > reported by Rob's robot. > - Link to v2: https://lore.kernel.org/r/20240125-dt-bindings-pci-qcom-split-v2-0-6b58efd91a7a@linaro.org > > Changes in v2: > - Switch on SM8[123456]50 to 8 MSI interrupts. > - Simplify SM8450 clocks. > - Add Acks/Rb. > - Link to v1: https://lore.kernel.org/r/20240108-dt-bindings-pci-qcom-split-v1-0-d541f05f4de0@linaro.org > > DTS fixes for interrupts will be send separately > > The qcom,pcie.yaml containing all devices results in huge allOf: section > with a lot of if:then: clauses making review and changes quite > difficult. > > Split common parts into common schema and then move few devices to > dedicated files, so that each file will be easier to review. > > I did not split/move all devices yet, so if this gets accepted I plan to > send more patches. Applied to qcom, thank you! [01/06] dt-bindings: PCI: qcom,pcie-sm8550: Move SM8550 to dedicated schema https://git.kernel.org/pci/pci/c/b8d3404058a6 [02/06] dt-bindings: PCI: qcom,pcie-sm8450: Move SM8450 to dedicated schema https://git.kernel.org/pci/pci/c/88c9b3af4e31 [03/06] dt-bindings: PCI: qcom,pcie-sm8250: Move SM8250 to dedicated schema https://git.kernel.org/pci/pci/c/4891b66185c1 [04/06] dt-bindings: PCI: qcom,pcie-sm8150: Move SM8150 to dedicated schema https://git.kernel.org/pci/pci/c/51bc04d5b49d [05/06] dt-bindings: PCI: qcom,pcie-sm8350: Move SM8350 to dedicated schema https://git.kernel.org/pci/pci/c/2278b8b54773 [06/06] dt-bindings: PCI: qcom,pcie-sc8280xp: Move SC8280XP to dedicated schema https://git.kernel.org/pci/pci/c/c007a5505504 Krzysztof
Hello, > Krzysztof W., Bjorn H., Lorenzo, > > Any comments from your side? If not, could you apply the series? I > already have work on top of this and other people are sending patches > touching same diff-context, so they should rebase on top of this. Both series were applied some time ago. Apologies for the delay. Krzysztof
Hi, Changes in v3: - sm8450: add missing allOf: to common schema, which also fixes issue reported by Rob's robot. - Link to v2: https://lore.kernel.org/r/20240125-dt-bindings-pci-qcom-split-v2-0-6b58efd91a7a@linaro.org Changes in v2: - Switch on SM8[123456]50 to 8 MSI interrupts. - Simplify SM8450 clocks. - Add Acks/Rb. - Link to v1: https://lore.kernel.org/r/20240108-dt-bindings-pci-qcom-split-v1-0-d541f05f4de0@linaro.org DTS fixes for interrupts will be send separately The qcom,pcie.yaml containing all devices results in huge allOf: section with a lot of if:then: clauses making review and changes quite difficult. Split common parts into common schema and then move few devices to dedicated files, so that each file will be easier to review. I did not split/move all devices yet, so if this gets accepted I plan to send more patches. Best regards, Krzysztof --- Krzysztof Kozlowski (6): dt-bindings: PCI: qcom,pcie-sm8550: move SM8550 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8450: move SM8450 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8250: move SM8250 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8150: move SM8150 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8350: move SM8350 to dedicated schema dt-bindings: PCI: qcom,pcie-sc8280xp: move SC8280XP to dedicated schema .../devicetree/bindings/pci/qcom,pcie-common.yaml | 98 ++++++++ .../bindings/pci/qcom,pcie-sc8280xp.yaml | 180 ++++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8150.yaml | 158 ++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8250.yaml | 173 +++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8350.yaml | 184 ++++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8450.yaml | 178 ++++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8550.yaml | 171 +++++++++++++ .../devicetree/bindings/pci/qcom,pcie.yaml | 268 --------------------- 8 files changed, 1142 insertions(+), 268 deletions(-) --- base-commit: 9357735abbd23457a3e06ba0142b7e88e7424410 change-id: 20240108-dt-bindings-pci-qcom-split-624737f7ba67 Best regards,