From patchwork Thu Aug 25 23:54:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William McVicker X-Patchwork-Id: 1670468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=T4+VXUmx; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4MDKYy3tyhz1yhN for ; Fri, 26 Aug 2022 09:54:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243737AbiHYXyK (ORCPT ); Thu, 25 Aug 2022 19:54:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244022AbiHYXyI (ORCPT ); Thu, 25 Aug 2022 19:54:08 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2EE1C59C2 for ; Thu, 25 Aug 2022 16:54:07 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id x25-20020aa79199000000b005358eeebf49so9748491pfa.17 for ; Thu, 25 Aug 2022 16:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc; bh=Iz+Fc3AXb8dLZ4mX3Mgbx3efWp93wo58I27EBlqSLxo=; b=T4+VXUmx1xdJxgSBWRyLx2UnPcil+44wnJP2E/zsfDwLP5Ilsrcjtp/NZ9abuKxm5G G47IGaf3NQn/fSBDMjdFkBsV8vcGBAD9GF1W94A8nXn+MGGtGuwe7MtAHcqXj2H957GZ WycLes5UWv3Idezjs64bo9cmzq/sxvtWwKPVTPcI2yiDaWMlc361CJrIglCIHLGupwQA PKa6VqMo0qX1LxzpjT3EnwPd8Em+E2RvwE3T4PxLERsGioDXRISg3jks8BzCt5EHnYf5 IhOskMj+IuzdZf754L6aYKWEYP57nSa7KAWvSY7zo7N5ervmfCg2aNbJxlV/9d7h/37D OVBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc; bh=Iz+Fc3AXb8dLZ4mX3Mgbx3efWp93wo58I27EBlqSLxo=; b=teFcNqV0yDb90uDIrJYM23tDb7g7JK4G34eQedikU47k4Hgtl0U34KeG8JiWus2jDi mmXOTLSEwEs+VPIOD+V4iBIbdX4FBHGBZl0Z0K+LgosmaJ89XORHwy8v/uH+OMzjDKNz ZFmNMQf+QM/wfPbPIk8N8EY3FtL2rAeWWuMZ8C1YW3fBEGasPACDBMdmTGByagTKkWmn sxbD68FBVCXkll8yIk42TxDZjzkrRf6FWihfqth9JJjIOtqGbUbvnL3xjYcjKFlkuTfq sjWFap/bmP/u9q3Ja18r7VARHYgYnnJ9nUrzNekBCVSZ4wZ7dxq8ulHuZ3cDK15jmvbg kZFA== X-Gm-Message-State: ACgBeo2c2MLkfyUdW8EwchVyC618WpLOsYeZLNPQJBehvrQtGYWLvlhy OaqX5/OCCIryg3o1WdOQ3sr8YCGmrvgjGsGV938= X-Google-Smtp-Source: AA6agR4XW1up7g6vcQ5pspby6TOQetmMBtqIH4cL6KO7i9zeE0uIlRdZusdeSi4RTg0vlkmIyX2xAHVuePdT+3gtl5c= X-Received: from wmcvicker.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5ebe]) (user=willmcvicker job=sendgmr) by 2002:a17:902:ce12:b0:172:dc6e:18f6 with SMTP id k18-20020a170902ce1200b00172dc6e18f6mr1394260plg.34.1661471647366; Thu, 25 Aug 2022 16:54:07 -0700 (PDT) Date: Thu, 25 Aug 2022 23:54:01 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220825235404.4132818-1-willmcvicker@google.com> Subject: [PATCH v6 0/2] PCI: dwc: Add support for 64-bit MSI target addresses From: Will McVicker To: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Rob Herring , " =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= " , Bjorn Helgaas , Will McVicker Cc: kernel-team@android.com, Vidya Sagar , Christoph Hellwig , Robin Murphy , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi All, I've update patch 2/2 to address Robin's suggestions. This includes: * Dropping the while-loop for retrying with a 64-bit mask in favor of retrying within the error if-statement. * Using an int for the DMA mask instead of a bool and ternary operation. Thanks again for the reviews and sorry for the extra revision today! Hopefully this is the last one :) If not, I'd be fine to submit patch 1/2 without 2/2 to avoid resending patch 1/2 for future revisions of patch 2/2 (unless I don't need to do that anyway). Thanks, Will Will McVicker (2): PCI: dwc: Drop dependency on ZONE_DMA32 v6: * Retrying DMA allocation with 64-bit mask within the error if-statement. * Use an int for the DMA mask instead of a bool and ternary operation. v5: * Updated patch 2/2 to first try with a 32-bit DMA mask. On failure, retry with a 64-bit mask if supported. v4: * Updated commit descriptions. * Renamed msi_64b -> msi_64bit. * Dropped msi_64bit ternary use. * Dropped export of dw_pcie_msi_capabilities. v3: * Switched to a managed DMA allocation. * Simplified the DMA allocation cleanup. * Dropped msi_page from struct dw_pcie_rp. * Allocating a u64 instead of a full page. v2: * Fixed build error caught by kernel test robot * Fixed error handling reported by Isaac Manjarres PCI: dwc: Add support for 64-bit MSI target address .../pci/controller/dwc/pcie-designware-host.c | 43 +++++++++---------- drivers/pci/controller/dwc/pcie-designware.c | 8 ++++ drivers/pci/controller/dwc/pcie-designware.h | 2 +- 3 files changed, 30 insertions(+), 23 deletions(-) base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868