mbox series

[v3,0/3] agp: convert to generic power management

Message ID 20211208193305.147072-1-helgaas@kernel.org
Headers show
Series agp: convert to generic power management | expand

Message

Bjorn Helgaas Dec. 8, 2021, 7:33 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

Vaibhav has converted around 180 drivers to generic power management, and
over 100 of those conversions have made it upstream.  If we can finish off
the remaining ones, we'll be able to remove quite a bit of ugly legacy code
from the PCI core.

This is a repost of Vaibhav's patches for AGP.  I rebased them to v5.16-rc1
and updated the commit logs to try to make it easier to verify them.

In the most recent posting here:

  https://lore.kernel.org/linux-pci/20211201025419.2797624-1-helgaas@kernel.org/

my commit log updates were incorrect.  This v3 has updates that I believe
to be correct, but of course I'd be grateful for more corrections.

Vaibhav Gupta (3):
  amd64-agp: convert to generic power management
  sis-agp: convert to generic power management
  via-agp: convert to generic power management

 drivers/char/agp/amd64-agp.c | 24 ++++++------------------
 drivers/char/agp/sis-agp.c   | 25 ++++++-------------------
 drivers/char/agp/via-agp.c   | 25 +++++--------------------
 3 files changed, 17 insertions(+), 57 deletions(-)

Comments

Dave Airlie Dec. 8, 2021, 7:55 p.m. UTC | #1
On Wed, 8 Dec 2021, Bjorn Helgaas wrote:

> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Vaibhav has converted around 180 drivers to generic power management, and
> over 100 of those conversions have made it upstream.  If we can finish off
> the remaining ones, we'll be able to remove quite a bit of ugly legacy code
> from the PCI core.
> 
> This is a repost of Vaibhav's patches for AGP.  I rebased them to v5.16-rc1
> and updated the commit logs to try to make it easier to verify them.
> 
> In the most recent posting here:
> 
>   https://lore.kernel.org/linux-pci/20211201025419.2797624-1-helgaas@kernel.org/
> 
> my commit log updates were incorrect.  This v3 has updates that I believe
> to be correct, but of course I'd be grateful for more corrections.

Hi Bjorn,

Do you want to merge these via your tree?

if so,
Acked-by: Dave Airlie <airlied@redhat.com>

Dave.

> 
> Vaibhav Gupta (3):
>   amd64-agp: convert to generic power management
>   sis-agp: convert to generic power management
>   via-agp: convert to generic power management
> 
>  drivers/char/agp/amd64-agp.c | 24 ++++++------------------
>  drivers/char/agp/sis-agp.c   | 25 ++++++-------------------
>  drivers/char/agp/via-agp.c   | 25 +++++--------------------
>  3 files changed, 17 insertions(+), 57 deletions(-)
> 
>
Bjorn Helgaas Dec. 8, 2021, 8:16 p.m. UTC | #2
On Wed, Dec 08, 2021 at 07:55:08PM +0000, Dave Airlie wrote:
> On Wed, 8 Dec 2021, Bjorn Helgaas wrote:
> 
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > Vaibhav has converted around 180 drivers to generic power management, and
> > over 100 of those conversions have made it upstream.  If we can finish off
> > the remaining ones, we'll be able to remove quite a bit of ugly legacy code
> > from the PCI core.
> > 
> > This is a repost of Vaibhav's patches for AGP.  I rebased them to v5.16-rc1
> > and updated the commit logs to try to make it easier to verify them.
> > 
> > In the most recent posting here:
> > 
> >   https://lore.kernel.org/linux-pci/20211201025419.2797624-1-helgaas@kernel.org/
> > 
> > my commit log updates were incorrect.  This v3 has updates that I believe
> > to be correct, but of course I'd be grateful for more corrections.
> 
> Hi Bjorn,
> 
> Do you want to merge these via your tree?
> 
> if so,
> Acked-by: Dave Airlie <airlied@redhat.com>

Either way is fine; I'll merge them to save you the trouble.  I put
them on pci/legacy-pm-removal for v5.17 with your ack.  Thanks!

> > Vaibhav Gupta (3):
> >   amd64-agp: convert to generic power management
> >   sis-agp: convert to generic power management
> >   via-agp: convert to generic power management
> > 
> >  drivers/char/agp/amd64-agp.c | 24 ++++++------------------
> >  drivers/char/agp/sis-agp.c   | 25 ++++++-------------------
> >  drivers/char/agp/via-agp.c   | 25 +++++--------------------
> >  3 files changed, 17 insertions(+), 57 deletions(-)
> > 
> >