| Message ID | 20210330174318.1289680-1-helgaas@kernel.org |
|---|---|
| Headers | show |
| Series | PCI: Disable parity checking | expand |
On 30.03.2021 19:43, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > I think this is essentially the same as Heiner's v3 posting, with these > changes: > > - Added a pci_disable_parity() interface in pci.c instead of making a > public pci_quirk_broken_parity() because quirks.c is only compiled when > CONFIG_PCI_QUIRKS=y. > > - Removed the setting of dev->broken_parity_status because it's really > only used by EDAC error reporting, and if we disable parity error > reporting, we shouldn't get there. This change will be visible in the > sysfs "broken_parity_status" file, but I doubt that's important. > > I dropped Leon's reviewed-by because I fiddled with the code. Similarly I > haven't added your signed-off-by, Heiner, because I don't want you blamed > for my errors. But if this looks OK to you I'll add it. > > v1: https://lore.kernel.org/r/a6f09e1b-4076-59d1-a4e3-05c5955bfff2@gmail.com > v2: https://lore.kernel.org/r/bbc33d9b-af7c-8910-cdb3-fa3e3b2e3266@gmail.com > - reduce scope of N2100 change to using the new PCI core quirk > v3: https://lore.kernel.org/r/992c800e-2e12-16b0-4845-6311b295d932@gmail.com/ > - improve commit message of patch 2 > > v4: > - add pci_disable_parity() (not conditional on CONFIG_PCI_QUIRKS) > - remove setting of dev->broken_parity_status > > > Bjorn Helgaas (1): > PCI: Add pci_disable_parity() > > Heiner Kallweit (2): > IB/mthca: Disable parity reporting > ARM: iop32x: disable N2100 PCI parity reporting > > arch/arm/mach-iop32x/n2100.c | 8 ++++---- > drivers/net/ethernet/realtek/r8169_main.c | 14 -------------- > drivers/pci/pci.c | 17 +++++++++++++++++ > drivers/pci/quirks.c | 13 ++++--------- > include/linux/pci.h | 1 + > 5 files changed, 26 insertions(+), 27 deletions(-) > LGTM. Thanks!
Hi Bjorn, > I think this is essentially the same as Heiner's v3 posting, with these > changes: > > - Added a pci_disable_parity() interface in pci.c instead of making a > public pci_quirk_broken_parity() because quirks.c is only compiled when > CONFIG_PCI_QUIRKS=y. Very nice idea to add pci_disable_parity(), looks very clean. > - Removed the setting of dev->broken_parity_status because it's really > only used by EDAC error reporting, and if we disable parity error > reporting, we shouldn't get there. This change will be visible in the > sysfs "broken_parity_status" file, but I doubt that's important. > > I dropped Leon's reviewed-by because I fiddled with the code. Similarly I > haven't added your signed-off-by, Heiner, because I don't want you blamed > for my errors. But if this looks OK to you I'll add it. [...] Thank you Bjorn and Heiner! Reviewed-by: Krzysztof Wilczyński <kw@linux.com> Krzysztof
From: Bjorn Helgaas <bhelgaas@google.com> I think this is essentially the same as Heiner's v3 posting, with these changes: - Added a pci_disable_parity() interface in pci.c instead of making a public pci_quirk_broken_parity() because quirks.c is only compiled when CONFIG_PCI_QUIRKS=y. - Removed the setting of dev->broken_parity_status because it's really only used by EDAC error reporting, and if we disable parity error reporting, we shouldn't get there. This change will be visible in the sysfs "broken_parity_status" file, but I doubt that's important. I dropped Leon's reviewed-by because I fiddled with the code. Similarly I haven't added your signed-off-by, Heiner, because I don't want you blamed for my errors. But if this looks OK to you I'll add it. v1: https://lore.kernel.org/r/a6f09e1b-4076-59d1-a4e3-05c5955bfff2@gmail.com v2: https://lore.kernel.org/r/bbc33d9b-af7c-8910-cdb3-fa3e3b2e3266@gmail.com - reduce scope of N2100 change to using the new PCI core quirk v3: https://lore.kernel.org/r/992c800e-2e12-16b0-4845-6311b295d932@gmail.com/ - improve commit message of patch 2 v4: - add pci_disable_parity() (not conditional on CONFIG_PCI_QUIRKS) - remove setting of dev->broken_parity_status Bjorn Helgaas (1): PCI: Add pci_disable_parity() Heiner Kallweit (2): IB/mthca: Disable parity reporting ARM: iop32x: disable N2100 PCI parity reporting arch/arm/mach-iop32x/n2100.c | 8 ++++---- drivers/net/ethernet/realtek/r8169_main.c | 14 -------------- drivers/pci/pci.c | 17 +++++++++++++++++ drivers/pci/quirks.c | 13 ++++--------- include/linux/pci.h | 1 + 5 files changed, 26 insertions(+), 27 deletions(-)