mbox series

[net-next,v3,0/2] realtek ethernet : use generic power management.

Message ID 20200518150214.100491-1-vaibhavgupta40@gmail.com
Headers show
Series realtek ethernet : use generic power management. | expand

Message

Vaibhav Gupta May 18, 2020, 3:02 p.m. UTC 
The purpose of this patch series is to remove legacy power management callbacks
from realtek ethernet drivers.

The callbacks performing suspend() and resume() operations are still calling
pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement
themselves, which is not recommended.

The conversion requires the removal of the those function calls and change the
callback definition accordingly.

All Changes are compile-tested only.

Vaibhav Gupta (2):
  realtek/8139too: use generic power management
  realtek/8139cp: use generic power management

 drivers/net/ethernet/realtek/8139cp.c  | 25 ++++++++-----------------
 drivers/net/ethernet/realtek/8139too.c | 26 +++++++-------------------
 2 files changed, 15 insertions(+), 36 deletions(-)

Comments

David Miller May 19, 2020, 10:32 p.m. UTC | #1 
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Date: Mon, 18 May 2020 20:32:12 +0530

> The purpose of this patch series is to remove legacy power management callbacks
> from realtek ethernet drivers.
> 
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement
> themselves, which is not recommended.
> 
> The conversion requires the removal of the those function calls and change the
> callback definition accordingly.
> 
> All Changes are compile-tested only.

Series applied, thanks.
Vaibhav Gupta June 24, 2020, 4:31 p.m. UTC | #2 
On Wed, 20 May 2020 at 04:02, David Miller <davem@davemloft.net> wrote:
>
> From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> Date: Mon, 18 May 2020 20:32:12 +0530
>
> > The purpose of this patch series is to remove legacy power management callbacks
> > from realtek ethernet drivers.
> >
> > The callbacks performing suspend() and resume() operations are still calling
> > pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement
> > themselves, which is not recommended.
> >
> > The conversion requires the removal of the those function calls and change the
> > callback definition accordingly.
> >
> > All Changes are compile-tested only.
>
> Series applied
Thanks !
-- Vaibhav Gupta
> , thanks.