From patchwork Tue Jul 23 09:25:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chocron, Jonathan" X-Patchwork-Id: 1135504 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amazon.com header.i=@amazon.com header.b="Q9GCmTyr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45tClM3nh6z9sBF for ; Tue, 23 Jul 2019 19:26:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729397AbfGWJZu (ORCPT ); Tue, 23 Jul 2019 05:25:50 -0400 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:29958 "EHLO smtp-fw-4101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728809AbfGWJZu (ORCPT ); Tue, 23 Jul 2019 05:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1563873949; x=1595409949; h=from:to:cc:subject:date:message-id:mime-version; bh=VDsDOEHhvQQsv24n5KRVR3T7vqAzJLQlWdXaSZiqvVw=; b=Q9GCmTyr3qea5Kejc1IKtOVvMJZs1a15vj/pnQE8ShCP5nEMUWf21bci zhGNnMpwONNNalYF1+Zcd9e7UbwDc5eQsAFWgqFzhLBGZFiimQcPBolkb 5/X67/4kIw2W0ScjL5Ub64owvhn42d1s3fU3hglaXcFU1fvPtvU9eN7H4 o=; X-IronPort-AV: E=Sophos;i="5.64,298,1559520000"; d="scan'208";a="775793900" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-e7be2041.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 23 Jul 2019 09:25:46 +0000 Received: from EX13MTAUWA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-e7be2041.us-west-2.amazon.com (Postfix) with ESMTPS id DEE1AA2397; Tue, 23 Jul 2019 09:25:45 +0000 (UTC) Received: from EX13D13UWA001.ant.amazon.com (10.43.160.136) by EX13MTAUWA001.ant.amazon.com (10.43.160.58) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 23 Jul 2019 09:25:45 +0000 Received: from u9ff250417f405e.ant.amazon.com (10.43.160.245) by EX13D13UWA001.ant.amazon.com (10.43.160.136) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 23 Jul 2019 09:25:40 +0000 From: Jonathan Chocron To: , , , , , CC: , , , , , , , , , , , Subject: [PATCH v3 0/8] Amazon's Annapurna Labs DT-based PCIe host controller driver Date: Tue, 23 Jul 2019 12:25:25 +0300 Message-ID: <20190723092529.11310-1-jonnyc@amazon.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.43.160.245] X-ClientProxiedBy: EX13D24UWB004.ant.amazon.com (10.43.161.4) To EX13D13UWA001.ant.amazon.com (10.43.160.136) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This series adds support for Amazon's Annapurna Labs DT-based PCIe host controller driver. Additionally, it adds 3 quirks (ACS, VPD and MSI-X) and 2 generic DWC patches. Regarding the 2nd DWC patch (PCI flags support), do you think this should be done in the context of a host-bridge driver at all (as opposed to PCI system-wide code)? Changes since v2: - Added al_pcie_controller_readl/writel() wrappers - Reorganized local vars in several functions according to reverse tree structure - Removed unnecessary check of ret value - Changed return type of al_pcie_config_prepare() from int to void - Removed check if link is up from probe() [done internally in dw_pcie_rd/wr_conf()] Changes since v1: - Added comment regarding 0x0031 being used as a dev_id for non root-port devices as well - Fixed different message/comment/print wordings - Added panic stacktrace to commit message of MSI-x quirk patch - Changed to pci_warn() instead of dev_warn() - Added unit_address after node_name in dt-binding - Updated Kconfig help description - Used GENMASK and FIELD_PREP/GET where appropriate - Removed leftover field from struct al_pcie and moved all ptrs to the beginning - Re-wrapped function definitions and invocations to use fewer lines - Change %p to %px in dbg prints in rd/wr_conf() functions - Removed validation that the port is configured to RC mode (as this is added generically in PATCH 7/8) - Removed unnecessary variable initializations - Swtiched to %pR for printing resources Ali Saidi (1): PCI: Add ACS quirk for Amazon Annapurna Labs root ports Jonathan Chocron (7): PCI: Add Amazon's Annapurna Labs vendor ID PCI/VPD: Add VPD release quirk for Amazon's Annapurna Labs Root Port PCI: Add quirk to disable MSI-X support for Amazon's Annapurna Labs Root Port dt-bindings: PCI: Add Amazon's Annapurna Labs PCIe host bridge binding PCI: al: Add support for DW based driver type PCI: dw: Add validation that PCIe core is set to correct mode PCI: dw: Add support for PCI_PROBE_ONLY/PCI_REASSIGN_ALL_BUS flags .../devicetree/bindings/pci/pcie-al.txt | 45 +++ MAINTAINERS | 3 +- drivers/pci/controller/dwc/Kconfig | 12 + drivers/pci/controller/dwc/pcie-al.c | 367 ++++++++++++++++++ .../pci/controller/dwc/pcie-designware-ep.c | 8 + .../pci/controller/dwc/pcie-designware-host.c | 31 +- drivers/pci/quirks.c | 34 ++ drivers/pci/vpd.c | 16 + include/linux/pci_ids.h | 2 + 9 files changed, 513 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/pcie-al.txt