From patchwork Tue Dec 12 14:16:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 847516 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yx22C4jlPz9s9Y for ; Wed, 13 Dec 2017 01:16:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdLLOQt (ORCPT ); Tue, 12 Dec 2017 09:16:49 -0500 Received: from bastet.se.axis.com ([195.60.68.11]:56124 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbdLLOQt (ORCPT ); Tue, 12 Dec 2017 09:16:49 -0500 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 8BC94180D2; Tue, 12 Dec 2017 15:16:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id yrQbEmUK58wT; Tue, 12 Dec 2017 15:16:47 +0100 (CET) Received: from boulder03.se.axis.com (boulder03.se.axis.com [10.0.8.17]) by bastet.se.axis.com (Postfix) with ESMTPS id 06FEB18383; Tue, 12 Dec 2017 15:16:46 +0100 (CET) Received: from boulder03.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C6AA51E084; Tue, 12 Dec 2017 15:16:46 +0100 (CET) Received: from boulder03.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB6651E082; Tue, 12 Dec 2017 15:16:46 +0100 (CET) Received: from thoth.se.axis.com (unknown [10.0.2.173]) by boulder03.se.axis.com (Postfix) with ESMTP; Tue, 12 Dec 2017 15:16:46 +0100 (CET) Received: from lnxartpec1.se.axis.com (lnxartpec1.se.axis.com [10.88.4.10]) by thoth.se.axis.com (Postfix) with ESMTP id AF539DA4; Tue, 12 Dec 2017 15:16:46 +0100 (CET) Received: by lnxartpec1.se.axis.com (Postfix, from userid 20283) id A85A6401A4; Tue, 12 Dec 2017 15:16:46 +0100 (CET) From: Niklas Cassel To: linux-pci@vger.kernel.org Cc: kishon@ti.com, Niklas Cassel , linux-kernel@vger.kernel.org Subject: [PATCH v4 0/3] Fix find_first_zero_bit() usage Date: Tue, 12 Dec 2017 15:16:31 +0100 Message-Id: <20171212141634.5985-1-niklas.cassel@axis.com> X-Mailer: git-send-email 2.14.2 X-TM-AS-GCONF: 00 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org find_first_zero_bit()'s parameter 'size' is defined in bits, not in bytes. Calling find_first_zero_bit() with the wrong size unit will lead to insidious bugs. Fix all uses of find_first_zero_bit() called with sizeof() as size argument in drivers/pci. Also had to fix broken error handling in pci_epc_epf_link() in order to do proper error handling for find_first_zero_bit(). Niklas Cassel (3): PCI: designware-ep: Fix find_first_zero_bit() usage PCI: endpoint: Fix error handling in pci_epc_epf_link() PCI: endpoint: Fix find_first_zero_bit() usage drivers/pci/dwc/pcie-designware-ep.c | 34 ++++++++++++++++++++++++++-------- drivers/pci/dwc/pcie-designware.h | 8 ++++++-- drivers/pci/endpoint/pci-ep-cfs.c | 13 ++++++++----- 3 files changed, 40 insertions(+), 15 deletions(-)