| Message ID | 1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com |
|---|---|
| Headers | show |
| Series | PCI: uniphier: Fix INTx masking/unmasking | expand |
Gentle ping, are there any comments about this series? Thank you, On 2021/08/30 11:22, Kunihiko Hayashi wrote: > This series includes some fixes to INTx masking/unmasking for UniPhier PCIe > host controller driver. > > - Remove unnecessary bit clears to INTX mask field > - Remove unnecessary irq_ack() function because write access to status field > doesn't work > - Add lock into callback functions to avoid race condition > > Kunihiko Hayashi (2): > PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack > function > PCI: uniphier: Serialize INTx masking/unmasking > > drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- > 1 file changed, 10 insertions(+), 16 deletions(-) > --- Best Regards Kunihiko Hayashi
On Thu, 16 Sep 2021 12:30:52 +0100, Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote: > > Gentle ping, are there any comments about this series? > > Thank you, > > On 2021/08/30 11:22, Kunihiko Hayashi wrote: > > This series includes some fixes to INTx masking/unmasking for UniPhier PCIe > > host controller driver. > > > > - Remove unnecessary bit clears to INTX mask field > > - Remove unnecessary irq_ack() function because write access to status field > > doesn't work > > - Add lock into callback functions to avoid race condition > > > > Kunihiko Hayashi (2): > > PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack > > function > > PCI: uniphier: Serialize INTx masking/unmasking > > > > drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- > > 1 file changed, 10 insertions(+), 16 deletions(-) > > Patches look OK, although I would personally squash them into a single one (INTx masking never really worked before that). FWIW: Acked-by: Marc Zyngier <maz@kernel.org> N,
Hi Marc, Thank you for your comment. On 2021/09/17 22:54, Marc Zyngier wrote: > On Thu, 16 Sep 2021 12:30:52 +0100, > Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote: >> >> Gentle ping, are there any comments about this series? >> >> Thank you, >> >> On 2021/08/30 11:22, Kunihiko Hayashi wrote: >>> This series includes some fixes to INTx masking/unmasking for UniPhier PCIe >>> host controller driver. >>> >>> - Remove unnecessary bit clears to INTX mask field >>> - Remove unnecessary irq_ack() function because write access to status field >>> doesn't work >>> - Add lock into callback functions to avoid race condition >>> >>> Kunihiko Hayashi (2): >>> PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack >>> function >>> PCI: uniphier: Serialize INTx masking/unmasking >>> >>> drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- >>> 1 file changed, 10 insertions(+), 16 deletions(-) >>> > > Patches look OK, although I would personally squash them into a single > one (INTx masking never really worked before that). FWIW: Surely applying only the first patch leaves the issue with the second one. I'll squash them in v3. Thank you, > > Acked-by: Marc Zyngier <maz@kernel.org> > > N, > --- Best Regards Kunihiko Hayashi
This series includes some fixes to INTx masking/unmasking for UniPhier PCIe host controller driver. - Remove unnecessary bit clears to INTX mask field - Remove unnecessary irq_ack() function because write access to status field doesn't work - Add lock into callback functions to avoid race condition Kunihiko Hayashi (2): PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack function PCI: uniphier: Serialize INTx masking/unmasking drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-)