From patchwork Wed Jan 26 22:43:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: david regan X-Patchwork-Id: 1584701 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wg5kGxaw; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=mail.com header.i=@mail.com header.a=rsa-sha256 header.s=dbd5af2cbaf7 header.b=gLLE7hTu; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jkf1K4l4dz9tB1 for ; Thu, 27 Jan 2022 09:44:53 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:From:Message-ID: MIME-Version:Reply-To:To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=hCFQ3p7eQJlidX3ItuDo+tncU+MCeYNbX7NWer9jB2U=; b=wg5 kGxawMVi5dyBh6Be1odbguEktUIAY0wqVV8298nDludoTeJUETWlvEKT0obYRsM0MxxtEDs3Qrhwq lktqq5DvbMeyVo5aSe9T4duPJMX/YNo/xMr8+LbE7Nlne7/hSaBLKFp0EPfQ2+/liSBe2HssKsCeF VCOaOQr4y9hxFzKfmI/qh4HpDgnMZ3/2MVHcpUSPuMl+Stqu8qJecXYxMUugBGdyWLJ788VOLgaqf nLQnfJCHnN9qgzpbEkPY9k9a/fVwhJNvspGItmqTRt4L+RJoU2dNOWivu0EWP63a3A7LbAiqMWaqN mbWCKPKyU0fB8FpDRJg7bw0vkq+0CKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCr1Q-00DgiY-7G; Wed, 26 Jan 2022 22:44:12 +0000 Received: from mout.gmx.com ([74.208.4.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCr1M-00DghU-MY for linux-mtd@lists.infradead.org; Wed, 26 Jan 2022 22:44:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.com; s=dbd5af2cbaf7; t=1643237024; bh=wU+S7FjBDGYOFP4tzn+yIp52M0akeGKRlL3rsegLOCA=; h=X-UI-Sender-Class:From:Subject:Date; b=gLLE7hTuMht+jXOXgufitAjzaM3MNeTkDZ4Vd/t4vSc+JIOR4WYeSIxo0De42/cpK IlVdVDrGUYQu3Sge4ufC6XJnxnqJOwVYjfUPvvPxAHtODy7foJaeEjqO0GufWodS8T 0SJ8N5nqW4cPhWjoTQ9m/r4kdC3vFNtklHz83dOI= X-UI-Sender-Class: 214d933f-fd2f-45c7-a636-f5d79ae31a79 Received: from [70.187.180.83] ([70.187.180.83]) by web-mail.mail.com (3c-app-mailcom-lxa02.server.lan [10.76.45.3]) (via HTTP); Wed, 26 Jan 2022 23:43:44 +0100 MIME-Version: 1.0 Message-ID: From: david regan Subject: [PATCH v2] mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status Date: Wed, 26 Jan 2022 23:43:44 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:1c0PNrBtmjr9eU+az5SGDr4j/r/J5B59MGAD6JaxKYJbmNY/SkZuJo42VtwVPjfSr/IPi YuSeAVHgWk4YcZjW9NYtnn8JNhKY7NSQHcmLEy3DW5LXj9eeILuA+hvpT/7kFt+g7lB18gkEpBge yMOXZ64wat/eRZjiMbz56Cirxdwp4Ky2tAXUlCEV4IwmxloPW/9WbnJl0IUr4irSXfO/f6mL22uh BxZvGXIFLNQCWIXdGIzz3qZ+IqhC4fICO+hYPGR0HMIsyPEjMAuTnVhT1T9fMJaOg5zsCB9/Qfcw JA= X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:cuW/21ipZws=:RSQSzvBlcyLSZpl7ChUDKW cMpDS5VEr9E5RaYBfo9QrRioG4sw1wpeQjNdIqaPE/nToHvS7uY0YJLAEYiiN9Tiq+3lmbHZ5 DAFfrkQswbCDxb+7+7SAhgEFR47bO8XKX1TV/dDWIMc+yF151i8ut5poVRgOvn+rSpMwEsmaw EzaIXNbRKpwv+ii2WW+6NunTLRGEPqjTsIrnZaNJ328bXqTPwfLdTJIbv/uea9W1B29fJHxEF rf4vYHcJMWtQBSj1jaSu9PcZ7Esxoyo5HAGFsbwOCB7d+gnoypzBBnprnbgRX8nZA5tes4td+ roJ8Jy2RGOyyjCMAA5l2ZtPVndGv7XKC+5h8n6+KFMepNqC6FV9QULps5NaZf3DQuASv1K4UT d2im3bOX0f8Z+I+Te41tXAfW4vsvak1LL3MnX+zrQiDQomkUVlk3da/f2qcD9uUN7X4JhUfkg orjbjWjbbuG8UU+QBX/a0IOsAWIB6WvY5OTAZAkq3UI1kmHTzyQzUg5QNEPvVVMjvW/G3qEuk MWtEckKz+1x4Nb3XVUpcs8K7raEdDUzTMUOotCggH5pMIcI56YQwaxk8IqwIN2LERNy0+H+Os f5JhOmYdUjtMhRMlkCcsF3Xx+dk4iJ6x7ulx/DGGLRwkdd6JSl89HUoviVvnjuS7F3Nj+Tpct iUahHIxoZ4W32EYW1W+TQKqK/ek/kRkA1jaUFFnprtDbgzeDB9RrQfqFyg65378Ch+SaiyDze uRuZbtJWovfNdIJ7p/8FgRr+KluvpYloWLD5640ADqXn73m5HjwBL4OVzXIdl6mPbKRPWZWoW se8o8hG X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_144408_889888_1A270D68 X-CRM114-Status: GOOD ( 12.37 ) X-Spam-Score: 0.3 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The brcmnand driver contains a bug in which if a page (example 2k byte) is read from the parallel/ONFI NAND and within that page a subpage (512 byte) has correctable errors which is followed by a subp [...] Content analysis details: (0.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [74.208.4.201 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [dregan[at]mail.com] 1.2 MISSING_HEADERS Missing To: header -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The brcmnand driver contains a bug in which if a page (example 2k byte) is read from the parallel/ONFI NAND and within that page a subpage (512 byte) has correctable errors which is followed by a subpage with uncorrectable errors, the page read will return the wrong status of correctable (as opposed to the actual status of uncorrectable.) The bug is in function brcmnand_read_by_pio where there is a check for uncorrectable bits which will be preempted if a previous status for correctable bits is detected. The fix is to stop checking for bad bits only if we already have a bad bits status. Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") Signed-off-by: david regan Reviewed-by: Florian Fainelli --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index c412f79..703ff00 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -2135,7 +2135,7 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip, mtd->oobsize / trans, host->hwcfg.sector_size_1k); - if (!ret) { + if (ret != -EBADMSG) { *err_addr = brcmnand_get_uncorrecc_addr(ctrl); if (*err_addr)