From patchwork Wed Jul 10 17:28:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mirsad Todorovac X-Patchwork-Id: 1958943 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1mrM19tR; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=IbvBCo9+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WK4bp6Pn5z1xqc for ; Thu, 11 Jul 2024 03:29:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:From:Cc:To:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6osoJnDuEQQlAB/KSFh76oNBCRTsmLkbmdpwdI9qAo8=; b=1mrM19tRCvrR/L NANPfGmuym1qqmMcX6hDkYWVJ9lBMBZO5vhgX2+IIiW7EwP3heI796UrHReaF5acPJ/FVyOedtnH9 BSh7Y8cvcisTt0z5mI/DSmZZo9ZMTxHBZTAtC1L3vPwMzRki3B6drbX+n5z3f/2Km07ZJoZp5F3DV eBE4ltW4hi+yDWnMZkg19OehzCvofUZls0VtV4WE4MSZLRbJlu4MxGaSKTkxx/Syq57wkhMPBaVAM 39IfdtMfq2vPSezzHgnEjmlh2ElXOzbxGZzt/SDyeuk65vXB5DMvtcVJNd5QtBmhdeaI2psqLJKNL uA+cIfGOTt22rMYVoxIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRb7s-0000000BIeW-0Ahy; Wed, 10 Jul 2024 17:29:08 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRb7o-0000000BIdL-39hI for linux-mtd@lists.infradead.org; Wed, 10 Jul 2024 17:29:06 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-356c4e926a3so4262728f8f.1 for ; Wed, 10 Jul 2024 10:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720632541; x=1721237341; darn=lists.infradead.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=W8AmXmDZ9UKk1+/Op1aszku3ECYfba0yWQH9jueXqCs=; b=IbvBCo9+4/RawxtJ3XTgtH0JABdz/C0Mu8Z+aevtEKrsoBUy0gAi/nE98sEcuIeM2I XreKJMXhzcFxFQnmpbJ5eJWDlUk4Oi3ki+acILCh8sFuEBVk6gbMM2NtA0IcaBbr+aut Y4nKEfDC7MtCriVLiYOPBTO9dInRz17gbpvrKeWuDUK64mEp+ceecnYUqikmNKnMtukc jIFKCxBT0VhU7zoApdKgDxQioqj0ipfZI6GGcYZnmqLCQsuhwZszqkw7ikV1nxep6lnj vGZQgcmRSsGpvIruz2gHUU/9b+7q+1EeI6sFp8AsHB0Hb1VOED0xc+ITpkQBlMOrtRHV afBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720632541; x=1721237341; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W8AmXmDZ9UKk1+/Op1aszku3ECYfba0yWQH9jueXqCs=; b=dEcuspEh/ixtvbH0S7d80X0hpZZeydFTL14A1EqUCgQRajnIcjOLx1XZtpGUk9iapv KsxYNT9kiLzU3W6w9+etGli0fDsHxRWWFVBbmPKXhTKGkvBMKMin/Ov6piqHFaxtXKeu 5t6kEdRIuM4q/P2/r8PzqC+xmd/v+EbYbduPTDbF+kVYSVJIA0rgDEFTcpkabSJD/Ek1 WUdIAowlOqiSiLEFlGHmw0racOquvBmXuA18boS8AytuIZG6sxtIGknFVOsGL5SR4vfe aZ4Z59UbKvKbITAqcbwxw7KUfVEWliPaFBhexF5a2g5GTJMozxQSgf4E2O4KbzVVPtg9 5KMA== X-Forwarded-Encrypted: i=1; AJvYcCUupwW3iupYwmH5cPug+2Yooy/+sDBhjy5FW46Zn+c1t6hXAomsDBjWs1SMR+VxbuvdBssanzG5k86vPV7qOldQLCeJE30pFkPazhSR1g== X-Gm-Message-State: AOJu0YzQ9cSSUzKmwQj/nBbmSEHQ/AkZWuYyHSkFE4fvPnVb9CIA4nVk CDnicMFxlnDOy7YuCcZUJyk+dkdLZnEI7o0YLs8x869jefDQcadi/E2Llg== X-Google-Smtp-Source: AGHT+IGEugKesaHDyp/MX6Mr5mcQL14OSWfE3NQfaJnQuXUz5fJJ8TcZCYBCzzQXu06kgIHaHM+Gaw== X-Received: by 2002:a5d:47c3:0:b0:362:52d8:6788 with SMTP id ffacd0b85a97d-367cea46642mr6130362f8f.2.1720632541052; Wed, 10 Jul 2024 10:29:01 -0700 (PDT) Received: from [192.168.178.20] (dh207-43-148.xnet.hr. [88.207.43.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfab753sm5767858f8f.107.2024.07.10.10.29.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 10:29:00 -0700 (PDT) Message-ID: Date: Wed, 10 Jul 2024 19:28:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Linux Kernel Mailing List Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org From: Mirsad Todorovac Subject: =?utf-8?q?=5BPROBLEM_linux-next=5D_=2E/include/linux/kern=5Flevels?= =?utf-8?q?=2Eh=3A5=3A25=3A_error=3A_=E2=80=98=25s=E2=80=99_directive_argume?= =?utf-8?q?nt_is_null_=5B-Werror=3Dformat-overflow=3D=5D?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_102904_818021_FC41EC5F X-CRM114-Status: GOOD ( 12.40 ) X-Spam-Score: -1.8 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi all, On the linux-next vanilla next-20240709 tree, I have attempted the seed KCONFIG_SEED=0xEE7AB52F which was known from before to trigger various errors in compile and build process. Though this might seem as contributing to channel noise, Linux refuses to build this config, treating warnings as errors, using this build line: Content analysis details: (-1.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42a listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [mtodorovac69(at)gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [mtodorovac69(at)gmail.com] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Hi all, On the linux-next vanilla next-20240709 tree, I have attempted the seed KCONFIG_SEED=0xEE7AB52F which was known from before to trigger various errors in compile and build process. Though this might seem as contributing to channel noise, Linux refuses to build this config, treating warnings as errors, using this build line: $ time nice make W=1 -k -j 36 |& tee ../err-next-20230709-01a.log; date As I know that the Chief Penguin doesn't like warnings, but I am also aware that there are plenty left, there seems to be more tedious work ahead to make the compilers happy. The compiler output is: ./include/linux/kern_levels.h:5:25: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ ./include/linux/printk.h:462:25: note: in definition of macro ‘printk_index_wrap’ 462 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ drivers/mtd/devices/slram.c:52:25: note: in expansion of macro ‘printk’ 52 | #define T(fmt, args...) printk(KERN_DEBUG fmt, ## args) | ^~~~~~ ./include/linux/kern_levels.h:15:25: note: in expansion of macro ‘KERN_SOH’ 15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */ | ^~~~~~~~ drivers/mtd/devices/slram.c:52:32: note: in expansion of macro ‘KERN_DEBUG’ 52 | #define T(fmt, args...) printk(KERN_DEBUG fmt, ## args) | ^~~~~~~~~~ drivers/mtd/devices/slram.c:304:17: note: in expansion of macro ‘T’ 304 | T("slram: devlength = %s\n", devlength); | ^ cc1: all warnings being treated as errors cc1: all warnings being treated as errors make[5]: *** [scripts/Makefile.build:244: drivers/mtd/devices/slram.o] Error 1 make[5]: Target 'drivers/mtd/devices/' not remade because of errors. cc1: all warnings being treated as errors The problem seems to originate from pre-git era < 2005-04-16 ^1da177e4c3f4 ("Linux-2.6.12-rc2"). ---------------------------------------- drivers/mtd/devices/slram.c ---------------------------------------- 277 static int __init init_slram(void) 278 { 279 char *devname; 280 281 #ifndef MODULE 282 char *devstart; 283 char *devlength; 284 285 if (!map) { 286 E("slram: not enough parameters.\n"); 287 return(-EINVAL); 288 } 289 while (map) { 290 devname = devstart = devlength = NULL; 291 292 if (!(devname = strsep(&map, ","))) { 293 E("slram: No devicename specified.\n"); 294 break; 295 } 296 T("slram: devname = %s\n", devname); 297 if ((!map) || (!(devstart = strsep(&map, ",")))) { 298 E("slram: No devicestart specified.\n"); 299 } 300 T("slram: devstart = %s\n", devstart); → 301 if ((!map) || (!(devlength = strsep(&map, ",")))) { 302 E("slram: No devicelength / -end specified.\n"); 303 } → 304 T("slram: devlength = %s\n", devlength); 305 if (parse_cmdline(devname, devstart, devlength) != 0) { 306 return(-EINVAL); 307 } 308 } 309 #else 310 int count; 311 int i; 312 313 for (count = 0; count < SLRAM_MAX_DEVICES_PARAMS && map[count]; 314 count++) { 315 } 316 317 if ((count % 3 != 0) || (count == 0)) { 318 E("slram: not enough parameters.\n"); 319 return(-EINVAL); 320 } 321 for (i = 0; i < (count / 3); i++) { 322 devname = map[i * 3]; 323 324 if (parse_cmdline(devname, map[i * 3 + 1], map[i * 3 + 2])!=0) { 325 return(-EINVAL); 326 } 327 328 } 329 #endif /* !MODULE */ 330 331 return(0); 332 } ---------------------------------------- NOTE, in line 301, in case of lazy evaluation, if (map == NULL, then (!(devlength = strsep(&map, ","))) will not be evaluated, and devlength will not be assigned. As a diff speaks more than a thousand words, here is the proposed fix: ----------------------------------><----------------------------------------------- --- Hope this helps. Best regards, Mirsad Todorovac diff --git a/drivers/mtd/devices/slram.c b/drivers/mtd/devices/slram.c index 28131a127d06..8297b366a066 100644 --- a/drivers/mtd/devices/slram.c +++ b/drivers/mtd/devices/slram.c @@ -296,10 +296,12 @@ static int __init init_slram(void) T("slram: devname = %s\n", devname); if ((!map) || (!(devstart = strsep(&map, ",")))) { E("slram: No devicestart specified.\n"); + break; } T("slram: devstart = %s\n", devstart); if ((!map) || (!(devlength = strsep(&map, ",")))) { E("slram: No devicelength / -end specified.\n"); + break; } T("slram: devlength = %s\n", devlength); if (parse_cmdline(devname, devstart, devlength) != 0) {