From patchwork Wed Dec 2 14:28:08 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: vimal singh X-Patchwork-Id: 40046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4FBB8B7BCA for ; Thu, 3 Dec 2009 01:30:22 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NFqC3-0002lh-Do; Wed, 02 Dec 2009 14:28:35 +0000 Received: from mail-bw0-f212.google.com ([209.85.218.212]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NFqBx-0002kB-Cr for linux-mtd@lists.infradead.org; Wed, 02 Dec 2009 14:28:33 +0000 Received: by bwz4 with SMTP id 4so218984bwz.2 for ; Wed, 02 Dec 2009 06:28:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=tlD58C2pbcmnyP5tgqhcghEzC9nB5VNXNb4TQe31z1E=; b=O/uz3/PI9OWRItqiQfiX7ER4mAx2h/dehTLSI/bce/4YXIwYIWQWySI+MOZpa7csWj CzhbISBUieiKB0ZkiKmYZUjnC6OT7b7frYAc5rQ9yzPcyVMwajiZ53cfLoVpcAND/4QX TbDs3vUyMcrHDE9uqvoQk6gGcp3yuXY9x2RvM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Pb9sZi39ubpMwoj2WBHhXhFdg9Ch4hzcjOinB4+5ykuRrB2+7OoIZIXFv+A+TOVeTo rgl/BmPY3EC8fdibLpnyHNlex65X4KJtvyn+6/KXfQhhN67CIRsMR1flebtCz+riOZA9 P2jwJSsfCxNp1hCc8XCCCYnkRCukl+2DGS9Hs= MIME-Version: 1.0 Received: by 10.204.10.19 with SMTP id n19mr225366bkn.19.1259764108126; Wed, 02 Dec 2009 06:28:28 -0800 (PST) From: Vimal Singh Date: Wed, 2 Dec 2009 19:58:08 +0530 Message-ID: Subject: [RFC] [PATCH] [MTD-UTILS]: flash_lock: fix length being passed To: Linux MTD X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091202_092829_609170_343CBB0D X-CRM114-Status: UNSURE ( 8.02 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch fixes the 'length' calculation. Making it: + mtdLockInfo.length = (num_sectors - 1) * mtdInfo.erasesize; Rather: - mtdLockInfo.length = num_sectors * mtdInfo.erasesize; Say there are 240 blocks present in the device. Then: offset starts from: 0x0 and full size of device: 0x1E00000 doing: 240 * 0x20000 gives -> 0x1E00000 But last block address should be 0x1DE0000 (which spans for 0x20000 bytes, adding upto size of 0x1E00000) Signed-off-by: Vimal Singh --- flash_lock.c.org 2009-11-24 19:33:18.000000000 +0530 +++ flash_lock.c 2009-11-24 19:33:13.000000000 +0530 @@ -71,7 +71,7 @@ int main(int argc, char *argv[]) } mtdLockInfo.start = ofs; - mtdLockInfo.length = num_sectors * mtdInfo.erasesize; + mtdLockInfo.length = (num_sectors - 1) * mtdInfo.erasesize; if(ioctl(fd, MEMLOCK, &mtdLockInfo)) { fprintf(stderr, "Could not lock MTD device: %s\n", argv[1]); @@ -81,4 +81,3 @@ int main(int argc, char *argv[]) return 0; } -