| Message ID | a4e43e367b09184a7caa0bb9b9f1bc3fa8be54d1.1513230484.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtd: onenand: samsung: Simplify code and fix leaks in error handling paths | expand |
diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c index b650290611d2..b5497c5a35f1 100644 --- a/drivers/mtd/onenand/samsung.c +++ b/drivers/mtd/onenand/samsung.c @@ -936,6 +936,11 @@ static int s3c_onenand_probe(struct platform_device *pdev) err = mtd_device_parse_register(mtd, NULL, NULL, pdata ? pdata->parts : NULL, pdata ? pdata->nr_parts : 0); + if (err) { + dev_err(&pdev->dev, "failed to parse partitions and register the MTD device\n"); + onenand_release(mtd); + return err; + } platform_set_drvdata(pdev, mtd);
If 'mtd_device_parse_register()' fails, we still return 0 which mean success. Return the error code instead, as done in all the other error handling paths. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Cross-compiled tested-only v2: call 'onenand_release()' to undo 'onenand_scan()' v3: no change --- drivers/mtd/onenand/samsung.c | 5 +++++ 1 file changed, 5 insertions(+)