From patchwork Wed Apr 20 22:34:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Xu X-Patchwork-Id: 612883 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qqxZZ00Kzz9t43 for ; Thu, 21 Apr 2016 08:36:53 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=rtXPr0SB; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1at0hx-0005r9-HN; Wed, 20 Apr 2016 22:34:53 +0000 Received: from mail-am1on0057.outbound.protection.outlook.com ([157.56.112.57] helo=emea01-am1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1at0hu-0005fS-4j; Wed, 20 Apr 2016 22:34:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-nxp-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lk+HQGESqfMvDdfli2IYJN2MNRRPI754Eagm77kbjSY=; b=rtXPr0SBtuq1QEMbievmxlmYHw7GpkW5rE9iYhhM1ruN4WGTmcVRNse257QvGOzNOUsJK5AGF885fcJDqaSkpu5moMGqZMBBYXlK7TINAIT5TCNjRM0yOKNbG7x1WWRkjQ9Zv4Nex3q7EmrIE5PHgG/BRkREVFNpqoJ66+YXTWg= Received: from DB5PR0401MB1845.eurprd04.prod.outlook.com (10.165.6.15) by DB5PR0401MB1909.eurprd04.prod.outlook.com (10.166.10.144) with Microsoft SMTP Server (TLS) id 15.1.466.19; Wed, 20 Apr 2016 22:34:27 +0000 Received: from DB5PR0401MB1845.eurprd04.prod.outlook.com ([10.165.6.15]) by DB5PR0401MB1845.eurprd04.prod.outlook.com ([10.165.6.15]) with mapi id 15.01.0466.023; Wed, 20 Apr 2016 22:34:27 +0000 From: Han Xu To: Yunhui Cui , "computersforpeace@gmail.com" , "han.xu@freescale.com" Subject: Re: [PATCH 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash Thread-Topic: [PATCH 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash Thread-Index: AQHRlgI01jJdxtMBXEePGSXWClockp+TfFnE Date: Wed, 20 Apr 2016 22:34:27 +0000 Message-ID: References: <1460605855-6689-1-git-send-email-B56489@freescale.com>, <1460605855-6689-7-git-send-email-B56489@freescale.com> In-Reply-To: <1460605855-6689-7-git-send-email-B56489@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [132.245.53.5] x-ms-office365-filtering-correlation-id: 2a7ade2d-57c6-4c4b-ddc2-08d3696bee6e x-microsoft-exchange-diagnostics: 1; DB5PR0401MB1909; 5:fxykQsKLjZD8CqpirD62W7SCYyWWhiEIbQkctdzR0u5KNLoK3GhKIJrXTuHYkMICCyMt4Zld4lTMsCk+p+MHu1rqIHq7ZKJIMxOkfeM4Cr8uhCAQlHw/96LxXs10EJxm0wHk3cW9ltKmKftK0Wqtu0j02cu2VhEOSfbOepULI01PTbBfcn/x09yUO0LXW6VF; 24:Yzd82mBYMsoFHlYtKQHmyeGIgJN+fiE7+goxDXD1ImpAxpS99XO+DIT+dH5bAECCln6BdOSTBwH2MehKDIyMm8UQeRxuiL59Hvr2sGdq84Y=; 7:OgYxV35sKHA9N3AkHI3KxCFS8tDf1kmXjuXLxELRI3YsYsRn9+Ha9b99j3KkEhDTugRQGVZ1v6L9Dlo9UMVRcCataOI478/hqWlQ0mKO6WESzRMmGxivtIU7s9totgqWHpoi6CSQFQu5G/57o0R5p7Os3oC9/MykvC7T6zJ/vTouLwsEtZz02YgjY10R3DmX2LYcHDrCXzGg7EeypBFeUAX1TfHMym0aNN1nG/ZwApI= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB1909; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(9101521026)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:DB5PR0401MB1909; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0401MB1909; x-forefront-prvs: 0918748D70 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(377454003)(11100500001)(2950100001)(5004730100002)(189998001)(2900100001)(76176999)(586003)(50986999)(86362001)(1096002)(33656002)(1220700001)(5008740100001)(66066001)(77096005)(102836003)(6116002)(5002640100001)(2906002)(3900700001)(92566002)(54356999)(4326007)(10400500002)(3660700001)(19580405001)(122556002)(3280700002)(19580395003)(5001770100001)(3846002)(5003600100002)(2501003)(87936001)(9686002)(76576001)(81166005)(74316001)(2201001)(106116001)(586874002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0401MB1909; H:DB5PR0401MB1845.eurprd04.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2016 22:34:27.0157 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB1909 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160420_153450_517722_D6704649 X-CRM114-Status: GOOD ( 13.79 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [157.56.112.57 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [157.56.112.57 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yunhui Cui , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , Yao Yuan , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 157841d..91ee920 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -39,6 +39,10 @@ #define SPI_NOR_MAX_ID_LEN 6 #define SPI_NOR_MAX_ADDR_WIDTH 4 +/* Added for S25FS-S family flash */ +#define SPINOR_CONFIG_REG3_OFFSET 0x800004 +#define CR3V_4KB_ERASE_UNABLE 0x8 +#define SPINOR_S25FS_FAMILY_ID 0x81 struct flash_info { char *name; @@ -78,6 +82,7 @@ struct flash_info { }; #define JEDEC_MFR(info) ((info)->id[0]) +#define EXT_ID(info) ((info)->id[5]) static const struct flash_info *spi_nor_match_id(const char *name); @@ -881,6 +886,7 @@ static const struct flash_info spi_nor_ids[] = { */ { "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, + { "s25fs256s1", INFO6(0x010219, 0x4d0181, 64 * 1024, 512, 0)}, { "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) }, { "s25fl256s1", INFO(0x010219, 0x4d01, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "s25fl512s", INFO(0x010220, 0x4d00, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, @@ -1018,6 +1024,53 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor) return ERR_PTR(-ENODEV); } +/* + * The S25FS-S family physical sectors may be configured as a + * hybrid combination of eight 4-kB parameter sectors + * at the top or bottom of the address space with all + * but one of the remaining sectors being uniform size. + * The Parameter Sector Erase commands (20h or 21h) must + * be used to erase the 4-kB parameter sectors individually. + * The Sector (uniform sector) Erase commands (D8h or DCh) + * must be used to erase any of the remaining + * sectors, including the portion of highest or lowest address + * sector that is not overlaid by the parameter sectors. + * The uniform sector erase command has no effect on parameter sectors. + */ +static int spansion_s25fs_disable_4kb_erase(struct spi_nor *nor) +{ + struct fsl_qspi *q; + u32 cr3v_addr = SPINOR_CONFIG_REG3_OFFSET; + u8 cr3v = 0x0; + int ret = 0x0; + + q = nor->priv; + + nor->cmd_buf[2] = cr3v_addr >> 16; + nor->cmd_buf[1] = cr3v_addr >> 8; + nor->cmd_buf[0] = cr3v_addr >> 0; I feel it's hacking code. Hi Brian, do we have any plan to support this special case? The RDAR( Read Any Register) needs an extra address parameter. + + ret = nor->read_reg(nor, SPINOR_OP_SPANSION_RDAR, &cr3v, 1); + if (ret) + return ret; + if (cr3v & CR3V_4KB_ERASE_UNABLE) + return 0; + ret = nor->write_reg(nor, SPINOR_OP_WREN, NULL, 0); + if (ret) + return ret; + cr3v = CR3V_4KB_ERASE_UNABLE; + nor->program_opcode = SPINOR_OP_SPANSION_WRAR; + nor->write(nor, cr3v_addr, 1, NULL, &cr3v); + + ret = nor->read_reg(nor, SPINOR_OP_SPANSION_RDAR, &cr3v, 1); + if (ret) + return ret; + if (!(cr3v & CR3V_4KB_ERASE_UNABLE)) + return -EPERM; +