From patchwork Thu Aug 20 06:18:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Andreas_Gr=C3=BCnbacher?= X-Patchwork-Id: 508912 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 528091401F0 for ; Thu, 20 Aug 2015 16:20:35 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=QwAoAlbs; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZSJBd-0005Ym-Ja; Thu, 20 Aug 2015 06:18:53 +0000 Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZSJBb-0005Ts-G7 for linux-mtd@lists.infradead.org; Thu, 20 Aug 2015 06:18:52 +0000 Received: by laba3 with SMTP id a3so16351808lab.1 for ; Wed, 19 Aug 2015 23:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ujm+lp6xkvrdWIXd/NeR+Y78a0h+aD5yH4VWjazAeMY=; b=QwAoAlbsq9Lh8raTHtDtHpLYaL3Yv+AFnyvHjokJ6Sx+vwADRvf5JSMhOs+75UcJLH G+wi5EW3yGaUvSisBUNXrZDVmbk2DcYhzOah1tNBxP2M++cUzyJCuA/uPAsPhy7kWVsc 1t8UvXM9lkS6SeXLU9JbPGoBAcephuMIkwY9Qqb9sUzP5J8pxF9ZAhkfZmT4n3y77Iq+ 8IthgllmZxUOKM1qUa7BZrcfK8Ti7QMHFqKLHEiar7C/rXU2H35kgTYH9XIqhYPmOE+y mF4E4cYuaKT32X1aDHlYbxHVCqnzKAF7QCeEVJdb7GlNlVrpge2252y12FjsaSLiLfbM g8yw== MIME-Version: 1.0 X-Received: by 10.112.156.137 with SMTP id we9mr1384604lbb.110.1440051508374; Wed, 19 Aug 2015 23:18:28 -0700 (PDT) Received: by 10.112.97.76 with HTTP; Wed, 19 Aug 2015 23:18:28 -0700 (PDT) In-Reply-To: <1440032464-17626-1-git-send-email-yangds.fnst@cn.fujitsu.com> References: <55D52473.7050209@cn.fujitsu.com> <1440032464-17626-1-git-send-email-yangds.fnst@cn.fujitsu.com> Date: Thu, 20 Aug 2015 08:18:28 +0200 Message-ID: Subject: Re: [PATCH] fstests: link .out to correct output when we set USE_ATTR_SECURE=yes From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= To: Dongsheng Yang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150819_231851_718162_82C7E682 X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:4010:c03:0:0:0:233 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andreas.gruenbacher[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: richard.weinberger@gmail.com, linux-mtd@lists.infradead.org, fstests@vger.kernel.org Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Dongsheng, 2015-08-20 3:01 GMT+02:00 Dongsheng Yang : > > When we set USE_ATTR_SECURE to yes or no, the expected outputs of generic/062 > would be different. So we need to link the .out to different file. Can the tests for the different namespaces please be separated from each other here (see below)? Next, can the security namespace tests be put in their own test case so that we don't need to switch between two different .out files? This could be done by setting ATTR_MODES and then invoking tests/generic/062 to avoid duplicating the entire test script. Thanks, Andreas diff --git a/tests/generic/062 b/tests/generic/062 index 194b638..9dd4498 100755 --- a/tests/generic/062 +++ b/tests/generic/062 @@ -142,6 +142,7 @@ for nsp in $ATTR_MODES; do echo "*** final list (strings, type=$inode, nsp=$nsp)" getfattr -m '.' -e hex $SCRATCH_MNT/$inode + # FIXME: Remove all remaining xattrs done done