| Message ID | 946079fe606d18b97578db42dd57a31acf38b26a.1693407641.git.geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: arm: realview: Fix development chip ROM compatible value | expand |
On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > When the development chip ROM was added, the "direct-mapped" compatible > value was already obsolete. In addition, the device node lacked the > accompanying "probe-type" property, causing the old physmap_of_core > driver to fall back to trying all available probe types. > Unfortunately this fallback was lost when the DT and pdata cases were > merged. > > Fix this by using the modern "mtd-rom" compatible value instead. > > Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS") > Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Patch applied! Yours, Linus Walleij
Hi Linus, On Tue, Sep 12, 2023 at 9:18 AM Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > > When the development chip ROM was added, the "direct-mapped" compatible > > value was already obsolete. In addition, the device node lacked the > > accompanying "probe-type" property, causing the old physmap_of_core > > driver to fall back to trying all available probe types. > > Unfortunately this fallback was lost when the DT and pdata cases were > > merged. > > > > Fix this by using the modern "mtd-rom" compatible value instead. > > > > Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS") > > Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Patch applied! Looks like this fell through the cracks? Shall I resend? Thanks! Gr{oetje,eeting}s, Geert
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts index efed325af88d206f..d99bac02232b3703 100644 --- a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts +++ b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts @@ -451,7 +451,7 @@ pb1176_serial3: serial@1010f000 { /* Direct-mapped development chip ROM */ pb1176_rom@10200000 { - compatible = "direct-mapped"; + compatible = "mtd-rom"; reg = <0x10200000 0x4000>; bank-width = <1>; };
When the development chip ROM was added, the "direct-mapped" compatible value was already obsolete. In addition, the device node lacked the accompanying "probe-type" property, causing the old physmap_of_core driver to fall back to trying all available probe types. Unfortunately this fallback was lost when the DT and pdata cases were merged. Fix this by using the modern "mtd-rom" compatible value instead. Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS") Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Untested due to lack of hardware. --- arch/arm/boot/dts/arm/arm-realview-pb1176.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)