| Message ID | 83fbf31ad895446837f8e01f77a1ff7c63d62251.1439911625.git.hramrach@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Aug 18, 2015 at 03:34:08PM -0000, Michal Suchanek wrote: > The lock flag of ofpart is undocumented. Add to binding doc. Good catch. There are a lot of small corners of very old code that never really got reviewed properly, I expect... (And the flag looks very odd. Why exactly is it in the partitions?) And now that I'm looking further...does this flag even *do* anything? AFAICT, it doesn't set the master device flags -- only the partition flags. But MTD drivers currently never see the partition flags -- they only see the master struct mtd_info. I think the only way anyone could observe the effect of this flag is to read the MTD flags from sysfs. And that's pretty useless. If my understanding is correct, then I'd rather completely remove the code that "handles" this flag, rather than codify it in the docs. > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > --- > Documentation/devicetree/bindings/mtd/partition.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mtd/partition.txt b/Documentation/devicetree/bindings/mtd/partition.txt > index 8c2aff7..7fa9c08 100644 > --- a/Documentation/devicetree/bindings/mtd/partition.txt > +++ b/Documentation/devicetree/bindings/mtd/partition.txt > @@ -29,6 +29,7 @@ Optional properties: > partition should only be mounted read-only. This is usually used for flash > partitions containing early-boot firmware images or data which should not be > clobbered. > +- lock : Clear always locked after reset flag This seems more like a SW description. I've reworded slightly locally. Is my above analysis sensible? If so, I'll patch this to kill the DT parsing code for "lock" entirely. If I'm wrong, then I can push this patch. Let me know what you think. Brian P.S. IIUC, then most of the 'mask_flags' stuff for partitioned devices really does nothing. These flags don't seem to ever be checked. Ugh.
On Sun, Oct 11, 2015 at 01:04:12PM -0700, Brian Norris wrote: > On Tue, Aug 18, 2015 at 03:34:08PM -0000, Michal Suchanek wrote: > > The lock flag of ofpart is undocumented. Add to binding doc. > > Good catch. There are a lot of small corners of very old code that never > really got reviewed properly, I expect... > > (And the flag looks very odd. Why exactly is it in the partitions?) > > And now that I'm looking further...does this flag even *do* anything? > AFAICT, it doesn't set the master device flags -- only the partition > flags. But MTD drivers currently never see the partition flags -- they > only see the master struct mtd_info. I think the only way anyone could > observe the effect of this flag is to read the MTD flags from sysfs. And > that's pretty useless. > > If my understanding is correct, then I'd rather completely remove the > code that "handles" this flag, rather than codify it in the docs. I've tested and confirmed: this only sets the flags for the partition (*NOT* for the master device), so the only visible effect of this property is to change sysfs flags. I'll send out a patch to kill this property entirely. Brian
diff --git a/Documentation/devicetree/bindings/mtd/partition.txt b/Documentation/devicetree/bindings/mtd/partition.txt index 8c2aff7..7fa9c08 100644 --- a/Documentation/devicetree/bindings/mtd/partition.txt +++ b/Documentation/devicetree/bindings/mtd/partition.txt @@ -29,6 +29,7 @@ Optional properties: partition should only be mounted read-only. This is usually used for flash partitions containing early-boot firmware images or data which should not be clobbered. +- lock : Clear always locked after reset flag Examples:
The lock flag of ofpart is undocumented. Add to binding doc. Signed-off-by: Michal Suchanek <hramrach@gmail.com> --- Documentation/devicetree/bindings/mtd/partition.txt | 1 + 1 file changed, 1 insertion(+)