| Message ID | 5b636f504e32c9fe83df22694656075f4f45c710.1439911625.git.hramrach@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Aug 18, 2015 at 03:34:07PM -0000, Michal Suchanek wrote: > The probe of a mtd device can fail when a partition parser returns > error. The failure due to partition parsing can be quite mysterious when > multiple partitioning schemes are comiled in and any of them can fail > the probe. > > Add debug prints which show what parsers were tried and what they > returned. > > Signed-off-by: Michal Suchanek <hramrach@gmail.com> > --- > v2: > > - reformat debug messages Looks OK to me. Applied to l2-mtd.git.
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index cafdb88..31888c2 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtdpart.c @@ -759,12 +759,17 @@ int parse_mtd_partitions(struct mtd_info *master, const char *const *types, types = default_mtd_part_types; for ( ; ret <= 0 && *types; types++) { + pr_debug("%s: parsing partitions %s\n", master->name, *types); parser = get_partition_parser(*types); if (!parser && !request_module("%s", *types)) parser = get_partition_parser(*types); + pr_debug("%s: got parser %s\n", master->name, + parser ? parser->name : NULL); if (!parser) continue; ret = (*parser->parse_fn)(master, pparts, data); + pr_debug("%s: parser %s: %i\n", + master->name, parser->name, ret); put_partition_parser(parser); if (ret > 0) { printk(KERN_NOTICE "%d %s partitions found on MTD device %s\n",
The probe of a mtd device can fail when a partition parser returns error. The failure due to partition parsing can be quite mysterious when multiple partitioning schemes are comiled in and any of them can fail the probe. Add debug prints which show what parsers were tried and what they returned. Signed-off-by: Michal Suchanek <hramrach@gmail.com> --- v2: - reformat debug messages --- drivers/mtd/mtdpart.c | 5 +++++ 1 file changed, 5 insertions(+)