From patchwork Fri Oct 16 12:00:17 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 36197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 99FE6B7BC7 for ; Fri, 16 Oct 2009 22:52:26 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MylKc-0002wo-CY; Fri, 16 Oct 2009 11:50:50 +0000 Received: from mail-ew0-f228.google.com ([209.85.219.228]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MylKV-0002w2-9i for linux-mtd@lists.infradead.org; Fri, 16 Oct 2009 11:50:48 +0000 Received: by ewy28 with SMTP id 28so1901457ewy.18 for ; Fri, 16 Oct 2009 04:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=vxL+3yoEQyaaB3J5Hf+MJ+WtIF7MgUGzfuJWTR/O0zg=; b=nQ22099/j89WXqr076yc90ECg+ZHAJ1Dwh1d9AwaOTu8F4w2R+x3jqZtAcCj33EUDT G1eXkMv5TyHvH8O9ZrR2Nu4m3hGfHaJVq8b8hfF9FHQm9IDyUMIRmRVnlvlSibLFMFU5 CkreBXp3ZzaLE49A563Pfsjd8Bos7Dq04tgfM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=hpFqeH/ZkhTbzDgZdnmzCBGbzGy1Qi2vx0pXMxeR1bDyaUnwrycsbH18padGHb6B9A AKtyy64C293DTsmthLt867xo7tL7/IJz2Qq0u9Pedi097AmG7v9XF4HHzY+sYeWPhMWn LAou/G3KMK4j3VmbmlGrHn2lt6CeDfykxtUmY= Received: by 10.210.2.22 with SMTP id 22mr785109ebb.62.1255693840985; Fri, 16 Oct 2009 04:50:40 -0700 (PDT) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 23sm383924eya.4.2009.10.16.04.50.39 (version=SSLv3 cipher=RC4-MD5); Fri, 16 Oct 2009 04:50:39 -0700 (PDT) Message-ID: <4AD86051.2040302@gmail.com> Date: Fri, 16 Oct 2009 14:00:17 +0200 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Artem Bityutskiy , linux-mtd@lists.infradead.org, Andrew Morton Subject: [PATCH] UBI: Fix check on unsigned in ytes_str_to_int() X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091016_075043_529070_1641F785 X-CRM114-Status: GOOD ( 17.74 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org result is unsigned, the wrong check was used. Signed-off-by: Roel Kluin diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index e1f7d0a..14cec04 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -42,6 +42,7 @@ #include #include #include +#include #include "ubi.h" /* Maximum length of the 'mtd=' parameter */ @@ -1257,7 +1258,7 @@ static int __init bytes_str_to_int(const char *str) unsigned long result; result = simple_strtoul(str, &endp, 0); - if (str == endp || result < 0) { + if (str == endp || result >= INT_MAX) { printk(KERN_ERR "UBI error: incorrect bytes count: \"%s\"\n", str); return -EINVAL;