From patchwork Sat Jan 10 05:16:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 17714 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 949CFDE059 for ; Sat, 10 Jan 2009 16:19:07 +1100 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1LLWDg-0007li-7U; Sat, 10 Jan 2009 05:17:12 +0000 Received: from acsinet12.oracle.com ([141.146.126.234]) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1LLWDS-00074q-Lf; Sat, 10 Jan 2009 05:17:10 +0000 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0A5GNd6002570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 10 Jan 2009 05:16:25 GMT Received: from acsmt700.oracle.com (acsmt700.oracle.com [141.146.40.70]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0A5HUv2022650; Sat, 10 Jan 2009 05:17:31 GMT Received: from [192.168.1.4] (/71.117.247.66) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 09 Jan 2009 21:16:51 -0800 Message-ID: <49682F42.8070304@oracle.com> Date: Fri, 09 Jan 2009 21:16:50 -0800 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Alexander Beregalov Subject: Re: mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled References: <20090110021641.GA26951@orion> In-Reply-To: <20090110021641.GA26951@orion> X-Source-IP: acsmt700.oracle.com [141.146.40.70] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.49682F45.0007:SCFSTAT928724,ss=1,fgs=0 X-Spam-Score: -4.0 (----) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (-4.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -4.0 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [141.146.126.234 listed in list.dnswl.org] Cc: David Woodhouse , linux-mtd@lists.infradead.org, akorolev@infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Alexander Beregalov wrote: > drivers/built-in.o: In function `lpddr_probe': > drivers/mtd/lpddr/qinfo_probe.c:215: > undefined reference to `lpddr_cmdset' > > # CONFIG_MTD_LPDDR is not set > CONFIG_MTD_QINFO_PROBE=y > -- This patch has been posted, just needs to be merged (hint): --- Signed-off-by: Alexey Korolev --- diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig index acd4ea9..5a401d8 100644 --- a/drivers/mtd/lpddr/Kconfig +++ b/drivers/mtd/lpddr/Kconfig @@ -12,6 +12,7 @@ config MTD_LPDDR DDR memories, intended for battery-operated systems. config MTD_QINFO_PROBE + depends on MTD_LPDDR tristate "Detect flash chips by QINFO probe" help Device Information for LPDDR chips is offered through the Overlay