diff mbox series

[05/18] mtd: tests: Include <linux/prandom.h> instead of <linux/random.h>

Message ID 20240905122020.872466-6-ubizjak@gmail.com
State Accepted
Headers show
Series random: Include <linux/percpu.h> and resolve circular include dependency | expand

Commit Message

Uros Bizjak Sept. 5, 2024, 12:17 p.m. UTC
Usage of pseudo-random functions requires inclusion of
<linux/prandom.h> header instead of <linux/random.h>.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
---
 drivers/mtd/tests/oobtest.c     | 2 +-
 drivers/mtd/tests/pagetest.c    | 2 +-
 drivers/mtd/tests/subpagetest.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Miquel Raynal Sept. 6, 2024, 3:10 p.m. UTC | #1
On Thu, 2024-09-05 at 12:17:13 UTC, Uros Bizjak wrote:
> Usage of pseudo-random functions requires inclusion of
> <linux/prandom.h> header instead of <linux/random.h>.
> 
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel
Uros Bizjak Sept. 6, 2024, 3:58 p.m. UTC | #2
On Fri, Sep 6, 2024 at 5:10 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> On Thu, 2024-09-05 at 12:17:13 UTC, Uros Bizjak wrote:
> > Usage of pseudo-random functions requires inclusion of
> > <linux/prandom.h> header instead of <linux/random.h>.
> >
> > Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Vignesh Raghavendra <vigneshr@ti.com>
> > Cc: linux-mtd@lists.infradead.org
>
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel, is it possible to just ACK the patch for now? The series
touches many parts of the kernel, so I guess it is best to harvest
Acked-by:s in this stage of development and commit all the patches
some time after the merge window. This will avoid merge conflicts with
the series.

Thanks,
Uros.
Miquel Raynal Sept. 9, 2024, 9:49 a.m. UTC | #3
Hi Uros,

ubizjak@gmail.com wrote on Fri, 6 Sep 2024 17:58:39 +0200:

> On Fri, Sep 6, 2024 at 5:10 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > On Thu, 2024-09-05 at 12:17:13 UTC, Uros Bizjak wrote:  
> > > Usage of pseudo-random functions requires inclusion of
> > > <linux/prandom.h> header instead of <linux/random.h>.
> > >
> > > Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> > > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > > Cc: Richard Weinberger <richard@nod.at>
> > > Cc: Vignesh Raghavendra <vigneshr@ti.com>
> > > Cc: linux-mtd@lists.infradead.org  
> >
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.  
> 
> Miquel, is it possible to just ACK the patch for now? The series
> touches many parts of the kernel, so I guess it is best to harvest
> Acked-by:s in this stage of development and commit all the patches
> some time after the merge window. This will avoid merge conflicts with
> the series.

Changing an include with a more specific include didn't look like a
dangerous change, but I'm fine dropping the patch. Please mention it
next time, because I didn't see it.

Thanks,
Miquèl
diff mbox series

Patch

diff --git a/drivers/mtd/tests/oobtest.c b/drivers/mtd/tests/oobtest.c
index 13fed398937e..e1ee68f8b8f8 100644
--- a/drivers/mtd/tests/oobtest.c
+++ b/drivers/mtd/tests/oobtest.c
@@ -17,7 +17,7 @@ 
 #include <linux/mtd/mtd.h>
 #include <linux/slab.h>
 #include <linux/sched.h>
-#include <linux/random.h>
+#include <linux/prandom.h>
 
 #include "mtd_test.h"
 
diff --git a/drivers/mtd/tests/pagetest.c b/drivers/mtd/tests/pagetest.c
index 8eb40b6e6dfa..6878700d2fc0 100644
--- a/drivers/mtd/tests/pagetest.c
+++ b/drivers/mtd/tests/pagetest.c
@@ -17,7 +17,7 @@ 
 #include <linux/mtd/mtd.h>
 #include <linux/slab.h>
 #include <linux/sched.h>
-#include <linux/random.h>
+#include <linux/prandom.h>
 
 #include "mtd_test.h"
 
diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c
index 05250a080139..f34bbf033c4d 100644
--- a/drivers/mtd/tests/subpagetest.c
+++ b/drivers/mtd/tests/subpagetest.c
@@ -15,7 +15,7 @@ 
 #include <linux/mtd/mtd.h>
 #include <linux/slab.h>
 #include <linux/sched.h>
-#include <linux/random.h>
+#include <linux/prandom.h>
 
 #include "mtd_test.h"