| Message ID | 20240828092427.128177-1-hanchunchao@inspur.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: powernv: Add check devm_kasprintf() returned value | expand |
On Wed, 2024-08-28 at 09:24:27 UTC, Charles Han wrote: > devm_kasprintf() can return a NULL pointer on failure but this > returned value is not checked. > > Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name") > Signed-off-by: Charles Han <hanchunchao@inspur.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index 66044f4f5bad..10cd1d9b4885 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -207,6 +207,9 @@ static int powernv_flash_set_driver_info(struct device *dev, * get them */ mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%pOFP", dev->of_node); + if (!mtd->name) + return -ENOMEM; + mtd->type = MTD_NORFLASH; mtd->flags = MTD_WRITEABLE; mtd->size = size;
devm_kasprintf() can return a NULL pointer on failure but this returned value is not checked. Fixes: acfe63ec1c59 ("mtd: Convert to using %pOFn instead of device_node.name") Signed-off-by: Charles Han <hanchunchao@inspur.com> --- drivers/mtd/devices/powernv_flash.c | 3 +++ 1 file changed, 3 insertions(+)