| Message ID | 20240826153158.67334-1-miquel.raynal@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: rawnand: meson: Fix typo in function name | expand |
On Mon, Aug 26 2024, Miquel Raynal wrote: > There is a reason why sometime we write "NAND chip" with an 's'. It > usually means several chips can be managed by the same controller. So > when initializing a single chip at a time, the wording "chip" must be > used, otherwise when talking about all the chips managed by the > controller, we want to use "chips". Fix the function name to clarify the > meson_nfc_nand_chip*s*_cleanup() helper intend. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
On Mon, 2024-08-26 at 15:31:58 UTC, Miquel Raynal wrote: > There is a reason why sometime we write "NAND chip" with an 's'. It > usually means several chips can be managed by the same controller. So > when initializing a single chip at a time, the wording "chip" must be > used, otherwise when talking about all the chips managed by the > controller, we want to use "chips". Fix the function name to clarify the > meson_nfc_nand_chip*s*_cleanup() helper intend. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Reviewed-by: Pratyush Yadav <pratyush@kernel.org> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c index 8806a06462ac..fbb06aa305cb 100644 --- a/drivers/mtd/nand/raw/meson_nand.c +++ b/drivers/mtd/nand/raw/meson_nand.c @@ -1475,7 +1475,7 @@ meson_nfc_nand_chip_init(struct device *dev, return 0; } -static void meson_nfc_nand_chip_cleanup(struct meson_nfc *nfc) +static void meson_nfc_nand_chips_cleanup(struct meson_nfc *nfc) { struct meson_nfc_nand_chip *meson_chip; struct mtd_info *mtd; @@ -1500,7 +1500,7 @@ static int meson_nfc_nand_chips_init(struct device *dev, for_each_child_of_node_scoped(np, nand_np) { ret = meson_nfc_nand_chip_init(dev, nfc, nand_np); if (ret) { - meson_nfc_nand_chip_cleanup(nfc); + meson_nfc_nand_chips_cleanup(nfc); return ret; } } @@ -1614,7 +1614,7 @@ static void meson_nfc_remove(struct platform_device *pdev) { struct meson_nfc *nfc = platform_get_drvdata(pdev); - meson_nfc_nand_chip_cleanup(nfc); + meson_nfc_nand_chips_cleanup(nfc); meson_nfc_disable_clk(nfc); }
There is a reason why sometime we write "NAND chip" with an 's'. It usually means several chips can be managed by the same controller. So when initializing a single chip at a time, the wording "chip" must be used, otherwise when talking about all the chips managed by the controller, we want to use "chips". Fix the function name to clarify the meson_nfc_nand_chip*s*_cleanup() helper intend. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/meson_nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)