From patchwork Mon Aug 26 09:46:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 1976743 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pDGnn11z; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=bTvx87Tr; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WsmBz3WXVz1yfF for ; Mon, 26 Aug 2024 19:50:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxvXoAYkgc//nmfulx/MGT2MBCqR649qyZSu/gn1PyA=; b=pDGnn11zN/lai3 5pfjvDRtLFGB4wOrOkoUcNbtz6Qma4bUvz8M803hLmtbBrCzAvjEduWGKe+qg2GWRFS+5i/N1cOuF fAGiRDNV0CyYfYLC42ldsht1KgIh8wYOuvLFXB1ekeJZwZzzp6u4vR/PaKL/IqhC5kXOj2KF668hK rez4t6dkFYElCi8GRK16Qn2cvXQ465b84/3PZgbz0Hb4DtDc9h+Z+/jvNpvtxfWWpXdLTjPseR/dQ QDgzTCDr4jvgOUpX5hOmx/7qTbtB9pjsmBZpIuTF7vwhAke0hrkIENxGXbx8CriOWSCNl6h9P+9tw sNtkgijQC5/SBqEes9rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWMx-00000006lpc-0c0c; Mon, 26 Aug 2024 09:50:39 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWJ3-00000006kUV-1X1j for linux-mtd@lists.infradead.org; Mon, 26 Aug 2024 09:46:39 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6C11BC000B; Mon, 26 Aug 2024 09:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724665596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98/GyyqNmsf2nYRjYC2j52ntHiuGsC2XFpthS0Dap2s=; b=bTvx87TrVdDYNMaNisiKxbW83ijus/WqPXdtucaTuECxDykPnm32J1Nl/zt61FgF4WYGCf WBxH10UiUgtdMrmDBwSgloS2LfYrQhB7IRXfsoHz6F6x7JdGdRmfcZvMtJsXti4kAbBuwi GPF56y2g2ET2/Cq/LH0kAJGZiGCFFkpMlTGr3WPUg175AZrlRqU7GPlxGpK7de1YdDhFEs NL19vmOsNZJJjzXq2k9PUssSAKvs4DtNbUvoN7GSI3yOHRCPSh1W3Jzy1UL5V+yPNAIJgo LFwQx+/z46tFWE+9kppeFyI+BhEbsv61X/lluo0vaTzfLVIaBwpSk+x5nAhvdg== From: Miquel Raynal To: David Oberhollenzer Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Julien Su , Alvin Zhou , Thomas Petazzoni , Miquel Raynal Subject: [PATCH mtd-utils 06/10] mtd-tests: flash_speed: Drop an apparently useless block Date: Mon, 26 Aug 2024 11:46:25 +0200 Message-ID: <20240826094629.19065-7-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240826094629.19065-1-miquel.raynal@bootlin.com> References: <20240826094629.19065-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_024637_605409_0D36422C X-CRM114-Status: GOOD ( 10.13 ) X-Spam-Score: -2.8 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I know no device without a multiple of 2 number of pages in each block. Even though it might be the case, it is clearly not a big deal and we don't really care about reading the last page, we are doin [...] Content analysis details: (-2.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [217.70.183.198 listed in sa-accredit.habeas.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.198 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [217.70.183.198 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [217.70.183.198 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org I know no device without a multiple of 2 number of pages in each block. Even though it might be the case, it is clearly not a big deal and we don't really care about reading the last page, we are doing a speed benchmark; so as long as the throughput calculation knows how much data has been read it's fine. Eitherway, I don't think we ever have fallen in this block because we would read the content of two pages (so one past the block) and put it in a page-wide buffer, which would probably lead to an out-of-bound abort. Just drop the block. Signed-off-by: Miquel Raynal --- tests/mtd-tests/flash_speed.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/mtd-tests/flash_speed.c b/tests/mtd-tests/flash_speed.c index 3489233..f542a8d 100644 --- a/tests/mtd-tests/flash_speed.c +++ b/tests/mtd-tests/flash_speed.c @@ -265,13 +265,6 @@ static int read_eraseblock_by_2pages(int ebnum) } buf += sz; } - if (pgcnt % 2) { - err = mtd_read(&mtd, fd, ebnum, i * sz, iobuf, pgsize); - if (err) { - fprintf(stderr, "Error reading block %d, page %d!\n", - ebnum, i*2); - } - } return err; }