Message ID | 20240826094629.19065-3-miquel.raynal@bootlin.com |
---|---|
State | New |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mT5VgbN9; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=DiUNd4c9; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WsmBv6fyVz1yZd for <incoming@patchwork.ozlabs.org>; Mon, 26 Aug 2024 19:50:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XSE+i2mJ9ddsoQ2jOzan13FvEuwXMjWApmeFsuISu20=; b=mT5VgbN9M4rdGg RrPW3Px7wAycpa+vQjhPrMBQhHwtW1xjRlAr1YMhJsADBIAtYbu9j0krA62uk4Oyv6CBRzUF4MNn5 sCB1DZ/nB9u8gRXR5b54AUOKkWCXcSiQyh+JqNahkblqg0DDk5xQRpXYNXSCZgche+5Tyiko0lTIx 2i5p1M6Xetwv9DiNuxU9lmg2phQ3fnAXzirPYwlo+zKb6g51GhDAthSiEAACWJgqdOZKmmgv/Oi8T it+SXIE6fKAF2HpBzmC80J0K2HILWBg37MIC+kZN/PY4LkK+iZfQ3DLLDaQ8LBlDo1/FcJxeip53k ptDx+c/ZRjBLPfc/IYqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWMt-00000006lnM-3aft; Mon, 26 Aug 2024 09:50:35 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siWJ0-00000006kT1-3ShP for linux-mtd@lists.infradead.org; Mon, 26 Aug 2024 09:46:37 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id D13C3C0009; Mon, 26 Aug 2024 09:46:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724665593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4Q0/2jgc6LZIODwosP5WDugdKaSA0UY1CaE5Fcrrz4=; b=DiUNd4c9FB+H2Zx83vRytN2l+t6Xb5ZCxCjyWto5ln92x5sIrlqej+y/IBKQBjZoYlWzAB xSnoctbDTYLV+yJF8PRZewB6GQllT8RGyrHTA5dv3YhpNvg+OG/Scbu6oX1gCZ8X21/pnk tRWWPEEi42M5xAMHxAj5RK9DgYYmVjuJzZsHwW/Y4Jtr4nITKZ7Vp0NA3SUSli2tP8qTiC zNml9yMNCDbmCXK4bsQVNqZyftiC5UbXhLu4pNzTE4JC83PCcK7+Axjf88ln/kgScSMu7i lInRbEl9qoRUftb7pI0mCQKiZAIcqoO+pagnXIP8YLu2v1UbUrn3FTy4YiD1Yg== From: Miquel Raynal <miquel.raynal@bootlin.com> To: David Oberhollenzer <david.oberhollenzer@sigma-star.at> Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <tudor.ambarus@linaro.org>, Pratyush Yadav <pratyush@kernel.org>, Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>, Julien Su <juliensu@mxic.com.tw>, Alvin Zhou <alvinzhou@mxic.com.tw>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH mtd-utils 02/10] nand-utils: nanddump: Explicitely use the page size when relevant Date: Mon, 26 Aug 2024 11:46:21 +0200 Message-ID: <20240826094629.19065-3-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240826094629.19065-1-miquel.raynal@bootlin.com> References: <20240826094629.19065-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240826_024635_039831_C8CF83E9 X-CRM114-Status: GOOD ( 11.08 ) X-Spam-Score: -2.8 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Using bs when skipping the bad sector is abusive as what we want is using the size of a block and the size of a page. The fact that bs currently is the size of a page is misleading here, has I intend [...] Content analysis details: (-2.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.198 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [217.70.183.198 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [217.70.183.198 listed in sa-trusted.bondedsender.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [217.70.183.198 listed in bl.score.senderscore.com] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
New options for hardening continuous read support
|
expand
|
diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c index 346af1e..a3e6e92 100644 --- a/nand-utils/nanddump.c +++ b/nand-utils/nanddump.c @@ -458,7 +458,7 @@ int main(int argc, char * const argv[]) /* skip bad block, increase end_addr */ if (bb_method == skipbad) { end_addr += mtd.eb_size; - ofs += mtd.eb_size - bs; + ofs += mtd.eb_size - mtd.min_io_size; if (end_addr > mtd.size) end_addr = mtd.size; continue;
Using bs when skipping the bad sector is abusive as what we want is using the size of a block and the size of a page. The fact that bs currently is the size of a page is misleading here, has I intend to make this amount grow. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- nand-utils/nanddump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)