diff mbox series

[-next,1/2] ubifs: remove unused ioctl flags GETFLAGS/SETFLAGS

Message ID 20240826091700.2812779-2-lihongbo22@huawei.com
State New
Headers show
Series ubifs: remove unused ioctl flags and support FS_IOC_GETFSSYSFSPATH | expand

Commit Message

Hongbo Li Aug. 26, 2024, 9:16 a.m. UTC
In the ubifs, ubifs_fileattr_get and ubifs_fileattr_set
have been implemented, GETFLAGS and SETFLAGS ioctl are not
handled in filesystem's own ioctl helper. Additionally,
these flags' cases are not handled in ubifs's ioctl helper,
so we can remove them.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
---
 fs/ubifs/ioctl.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Zhihao Cheng Aug. 26, 2024, 10:34 a.m. UTC | #1
在 2024/8/26 17:16, Hongbo Li 写道:
> In the ubifs, ubifs_fileattr_get and ubifs_fileattr_set
> have been implemented, GETFLAGS and SETFLAGS ioctl are not
> handled in filesystem's own ioctl helper. Additionally,
> these flags' cases are not handled in ubifs's ioctl helper,
> so we can remove them.
> 
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> ---
>   fs/ubifs/ioctl.c | 6 ------
>   1 file changed, 6 deletions(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> 
> diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c
> index d79cabe193c3..2c99349cf537 100644
> --- a/fs/ubifs/ioctl.c
> +++ b/fs/ubifs/ioctl.c
> @@ -213,12 +213,6 @@ long ubifs_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>   long ubifs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>   {
>   	switch (cmd) {
> -	case FS_IOC32_GETFLAGS:
> -		cmd = FS_IOC_GETFLAGS;
> -		break;
> -	case FS_IOC32_SETFLAGS:
> -		cmd = FS_IOC_SETFLAGS;
> -		break;
>   	case FS_IOC_SET_ENCRYPTION_POLICY:
>   	case FS_IOC_GET_ENCRYPTION_POLICY:
>   	case FS_IOC_GET_ENCRYPTION_POLICY_EX:
>
diff mbox series

Patch

diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c
index d79cabe193c3..2c99349cf537 100644
--- a/fs/ubifs/ioctl.c
+++ b/fs/ubifs/ioctl.c
@@ -213,12 +213,6 @@  long ubifs_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 long ubifs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
 	switch (cmd) {
-	case FS_IOC32_GETFLAGS:
-		cmd = FS_IOC_GETFLAGS;
-		break;
-	case FS_IOC32_SETFLAGS:
-		cmd = FS_IOC_SETFLAGS;
-		break;
 	case FS_IOC_SET_ENCRYPTION_POLICY:
 	case FS_IOC_GET_ENCRYPTION_POLICY:
 	case FS_IOC_GET_ENCRYPTION_POLICY_EX: