| Message ID | 20240825083515.4074081-1-wangzhaolong1@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | mtd: ubi: remove unused parameter 'pnum' from add_volume() | expand |
在 2024/8/25 16:35, Wang Zhaolong 写道: > The parameter 'pnum' in the function add_volume() is not used inside the > function body. This patch removes this unused parameter to clean up the > code and improve readability. > > This change does not affect the functionality of add_volume() or any other > part of the UBI subsystem, as the removed parameter is not utilized. > > Signed-off-by: Wang Zhaolong <wangzhaolong1@huawei.com> > --- > drivers/mtd/ubi/attach.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> > > diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c > index ae5abe492b52..fe9784c90ea4 100644 > --- a/drivers/mtd/ubi/attach.c > +++ b/drivers/mtd/ubi/attach.c > @@ -393,8 +393,7 @@ static int validate_vid_hdr(const struct ubi_device *ubi, > * to the allocated "av" object in case of success and a negative error code in > * case of failure. > */ > -static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, > - int vol_id, int pnum, > +static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, int vol_id, > const struct ubi_vid_hdr *vid_hdr) > { > struct ubi_ainf_volume *av; > @@ -576,7 +575,7 @@ int ubi_add_to_av(struct ubi_device *ubi, struct ubi_attach_info *ai, int pnum, > dbg_bld("PEB %d, LEB %d:%d, EC %d, sqnum %llu, bitflips %d", > pnum, vol_id, lnum, ec, sqnum, bitflips); > > - av = add_volume(ai, vol_id, pnum, vid_hdr); > + av = add_volume(ai, vol_id, vid_hdr); > if (IS_ERR(av)) > return PTR_ERR(av); > >
Hi Wang,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rw-ubifs/next]
[also build test WARNING on rw-ubifs/fixes linus/master v6.11-rc5 next-20240826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wang-Zhaolong/mtd-ubi-remove-unused-parameter-pnum-from-add_volume/20240826-142424
base: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next
patch link: https://lore.kernel.org/r/20240825083515.4074081-1-wangzhaolong1%40huawei.com
patch subject: [PATCH] mtd: ubi: remove unused parameter 'pnum' from add_volume()
config: i386-buildonly-randconfig-005-20240827 (https://download.01.org/0day-ci/archive/20240827/202408271041.ttLMjF8z-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408271041.ttLMjF8z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408271041.ttLMjF8z-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/mtd/ubi/attach.c:398: warning: Excess function parameter 'pnum' description in 'add_volume'
vim +398 drivers/mtd/ubi/attach.c
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 382
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 383 /**
a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 384 * add_volume - add volume to the attaching information.
a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 385 * @ai: attaching information
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 386 * @vol_id: ID of the volume to add
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 387 * @pnum: physical eraseblock number
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 388 * @vid_hdr: volume identifier header
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 389 *
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 390 * If the volume corresponding to the @vid_hdr logical eraseblock is already
a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 391 * present in the attaching information, this function does nothing. Otherwise
a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 392 * it adds corresponding volume to the attaching information. Returns a pointer
fbd0107f4d33be0 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 393 * to the allocated "av" object in case of success and a negative error code in
fbd0107f4d33be0 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 394 * case of failure.
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 395 */
beba9855702e14c drivers/mtd/ubi/attach.c Wang Zhaolong 2024-08-25 396 static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, int vol_id,
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 397 const struct ubi_vid_hdr *vid_hdr)
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 @398 {
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 399 struct ubi_ainf_volume *av;
de4c455b3e9f630 drivers/mtd/ubi/attach.c Boris Brezillon 2016-09-16 400 bool created;
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 401
3261ebd7d4194ff drivers/mtd/ubi/scan.c Christoph Hellwig 2007-05-21 402 ubi_assert(vol_id == be32_to_cpu(vid_hdr->vol_id));
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 403
de4c455b3e9f630 drivers/mtd/ubi/attach.c Boris Brezillon 2016-09-16 404 av = ubi_find_or_add_av(ai, vol_id, &created);
de4c455b3e9f630 drivers/mtd/ubi/attach.c Boris Brezillon 2016-09-16 405 if (IS_ERR(av) || !created)
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 406 return av;
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 407
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 408 av->used_ebs = be32_to_cpu(vid_hdr->used_ebs);
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 409 av->data_pad = be32_to_cpu(vid_hdr->data_pad);
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 410 av->compat = vid_hdr->compat;
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 411 av->vol_type = vid_hdr->vol_type == UBI_VID_DYNAMIC ? UBI_DYNAMIC_VOLUME
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 412 : UBI_STATIC_VOLUME;
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 413
517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 414 return av;
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 415 }
801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 416
在 2024/8/27 11:26, kernel test robot 写道: > Hi Wang, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on rw-ubifs/next] > [also build test WARNING on rw-ubifs/fixes linus/master v6.11-rc5 next-20240826] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Wang-Zhaolong/mtd-ubi-remove-unused-parameter-pnum-from-add_volume/20240826-142424 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs.git next > patch link: https://lore.kernel.org/r/20240825083515.4074081-1-wangzhaolong1%40huawei.com > patch subject: [PATCH] mtd: ubi: remove unused parameter 'pnum' from add_volume() > config: i386-buildonly-randconfig-005-20240827 (https://download.01.org/0day-ci/archive/20240827/202408271041.ttLMjF8z-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408271041.ttLMjF8z-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202408271041.ttLMjF8z-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> drivers/mtd/ubi/attach.c:398: warning: Excess function parameter 'pnum' description in 'add_volume' > > > vim +398 drivers/mtd/ubi/attach.c > > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 382 > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 383 /** > a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 384 * add_volume - add volume to the attaching information. > a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 385 * @ai: attaching information > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 386 * @vol_id: ID of the volume to add > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 387 * @pnum: physical eraseblock number Hi ZhaoLong, you need to remove the parameter description from comments too. > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 388 * @vid_hdr: volume identifier header > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 389 * > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 390 * If the volume corresponding to the @vid_hdr logical eraseblock is already > a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 391 * present in the attaching information, this function does nothing. Otherwise > a4e6042f1d07307 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 392 * it adds corresponding volume to the attaching information. Returns a pointer > fbd0107f4d33be0 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 393 * to the allocated "av" object in case of success and a negative error code in > fbd0107f4d33be0 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 394 * case of failure. > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 395 */ > beba9855702e14c drivers/mtd/ubi/attach.c Wang Zhaolong 2024-08-25 396 static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, int vol_id, > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 397 const struct ubi_vid_hdr *vid_hdr) > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 @398 { > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 399 struct ubi_ainf_volume *av; > de4c455b3e9f630 drivers/mtd/ubi/attach.c Boris Brezillon 2016-09-16 400 bool created; > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 401 > 3261ebd7d4194ff drivers/mtd/ubi/scan.c Christoph Hellwig 2007-05-21 402 ubi_assert(vol_id == be32_to_cpu(vid_hdr->vol_id)); > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 403 > de4c455b3e9f630 drivers/mtd/ubi/attach.c Boris Brezillon 2016-09-16 404 av = ubi_find_or_add_av(ai, vol_id, &created); > de4c455b3e9f630 drivers/mtd/ubi/attach.c Boris Brezillon 2016-09-16 405 if (IS_ERR(av) || !created) > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 406 return av; > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 407 > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 408 av->used_ebs = be32_to_cpu(vid_hdr->used_ebs); > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 409 av->data_pad = be32_to_cpu(vid_hdr->data_pad); > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 410 av->compat = vid_hdr->compat; > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 411 av->vol_type = vid_hdr->vol_type == UBI_VID_DYNAMIC ? UBI_DYNAMIC_VOLUME > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 412 : UBI_STATIC_VOLUME; > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 413 > 517af48c0540e61 drivers/mtd/ubi/scan.c Artem Bityutskiy 2012-05-17 414 return av; > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 415 } > 801c135ce73d5df drivers/mtd/ubi/scan.c Artem B. Bityutskiy 2006-06-27 416 >
diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c index ae5abe492b52..fe9784c90ea4 100644 --- a/drivers/mtd/ubi/attach.c +++ b/drivers/mtd/ubi/attach.c @@ -393,8 +393,7 @@ static int validate_vid_hdr(const struct ubi_device *ubi, * to the allocated "av" object in case of success and a negative error code in * case of failure. */ -static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, - int vol_id, int pnum, +static struct ubi_ainf_volume *add_volume(struct ubi_attach_info *ai, int vol_id, const struct ubi_vid_hdr *vid_hdr) { struct ubi_ainf_volume *av; @@ -576,7 +575,7 @@ int ubi_add_to_av(struct ubi_device *ubi, struct ubi_attach_info *ai, int pnum, dbg_bld("PEB %d, LEB %d:%d, EC %d, sqnum %llu, bitflips %d", pnum, vol_id, lnum, ec, sqnum, bitflips); - av = add_volume(ai, vol_id, pnum, vid_hdr); + av = add_volume(ai, vol_id, vid_hdr); if (IS_ERR(av)) return PTR_ERR(av);
The parameter 'pnum' in the function add_volume() is not used inside the function body. This patch removes this unused parameter to clean up the code and improve readability. This change does not affect the functionality of add_volume() or any other part of the UBI subsystem, as the removed parameter is not utilized. Signed-off-by: Wang Zhaolong <wangzhaolong1@huawei.com> --- drivers/mtd/ubi/attach.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)