| Message ID | 20240713073519.25325-1-richard@nod.at |
|---|---|
| State | New |
| Headers | show |
| Series | ubi: Fix ubi_init() ubiblock_exit() section mismatch | expand |
在 2024/7/13 15:35, Richard Weinberger 写道: > Since ubiblock_exit() is now called from an init function, > the __exit section no longer makes sense. > > Cc: Ben Hutchings <bwh@kernel.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/ > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/mtd/ubi/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks like that you prefer a simpler fix. Feel fine to add Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> > > diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c > index bf7308e8ec2fe..60d0155be869f 100644 > --- a/drivers/mtd/ubi/block.c > +++ b/drivers/mtd/ubi/block.c > @@ -670,7 +670,7 @@ int __init ubiblock_init(void) > return ret; > } > > -void __exit ubiblock_exit(void) > +void ubiblock_exit(void) > { > ubi_unregister_volume_notifier(&ubiblock_notifier); > ubiblock_remove_all(); >
----- Ursprüngliche Mail ----- > Von: "chengzhihao1" <chengzhihao1@huawei.com> > An: "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org> > CC: "linux-kernel" <linux-kernel@vger.kernel.org>, "Ben Hutchings" <bwh@kernel.org>, "kernel test robot" <lkp@intel.com> > Gesendet: Samstag, 13. Juli 2024 10:16:15 > Betreff: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch > 在 2024/7/13 15:35, Richard Weinberger 写道: >> Since ubiblock_exit() is now called from an init function, >> the __exit section no longer makes sense. >> >> Cc: Ben Hutchings <bwh@kernel.org> >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: >> https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/ >> Signed-off-by: Richard Weinberger <richard@nod.at> >> --- >> drivers/mtd/ubi/block.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Looks like that you prefer a simpler fix. Feel fine to add Yes, and Ben sent the patch first. :) > Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> Thanks for the review! And especially thanks for reviewing so many UBI/UBIFS patches, I appreciate your help. Thanks, //richard
在 2024/7/13 16:46, Richard Weinberger 写道: > ----- Ursprüngliche Mail ----- >> Von: "chengzhihao1" <chengzhihao1@huawei.com> >> An: "richard" <richard@nod.at>, "linux-mtd" <linux-mtd@lists.infradead.org> >> CC: "linux-kernel" <linux-kernel@vger.kernel.org>, "Ben Hutchings" <bwh@kernel.org>, "kernel test robot" <lkp@intel.com> >> Gesendet: Samstag, 13. Juli 2024 10:16:15 >> Betreff: Re: [PATCH] ubi: Fix ubi_init() ubiblock_exit() section mismatch > >> 在 2024/7/13 15:35, Richard Weinberger 写道: >>> Since ubiblock_exit() is now called from an init function, >>> the __exit section no longer makes sense. >>> >>> Cc: Ben Hutchings <bwh@kernel.org> >>> Reported-by: kernel test robot <lkp@intel.com> >>> Closes: >>> https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/ >>> Signed-off-by: Richard Weinberger <richard@nod.at> >>> --- >>> drivers/mtd/ubi/block.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Looks like that you prefer a simpler fix. Feel fine to add > > Yes, and Ben sent the patch first. :) > >> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> > > Thanks for the review! > And especially thanks for reviewing so many UBI/UBIFS patches, > I appreciate your help. You're welcome. BTW, I have two favors to need your help. 1. Give me some feedbacks about the fsck.ubifs patch series [https://patchwork.ozlabs.org/project/linux-mtd/list/?series=409935], maybe you have started looking at them. I know it is a huge reviewing work, maybe you can start with using, testing or reading the documents. 2. I reported a BUG[https://lore.kernel.org/linux-ext4/346993f2-87f6-e20f-8f5a-d19f84c1604c@huaweicloud.com/T/#m36825671b018880ca17e4c093a4dbfc1b66d5db8] recently, please let me know if you have a good solution. > > Thanks, > //richard > > . >
diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c index bf7308e8ec2fe..60d0155be869f 100644 --- a/drivers/mtd/ubi/block.c +++ b/drivers/mtd/ubi/block.c @@ -670,7 +670,7 @@ int __init ubiblock_init(void) return ret; } -void __exit ubiblock_exit(void) +void ubiblock_exit(void) { ubi_unregister_volume_notifier(&ubiblock_notifier); ubiblock_remove_all();
Since ubiblock_exit() is now called from an init function, the __exit section no longer makes sense. Cc: Ben Hutchings <bwh@kernel.org> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/ Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/mtd/ubi/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)